You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by "Till Westmann (Code Review)" <do...@asterixdb.incubator.apache.org> on 2016/08/02 22:53:34 UTC
Change in asterixdb[master]: Pass compilation provider to QueryServiceServlet
Till Westmann has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/1043
Change subject: Pass compilation provider to QueryServiceServlet
......................................................................
Pass compilation provider to QueryServiceServlet
Change-Id: I795a2dab622ab40b39f6aaf548a27ffbd40c9efd
---
M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
M asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
2 files changed, 6 insertions(+), 2 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/43/1043/1
diff --git a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
index 2e6ee58..f208694 100644
--- a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
+++ b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
@@ -61,7 +61,7 @@
private static final Logger LOGGER = Logger.getLogger(QueryServiceServlet.class.getName());
- private transient final ILangCompilationProvider compilationProvider = new SqlppCompilationProvider();
+ private transient final ILangCompilationProvider compilationProvider;
public enum Parameter {
// Standard
@@ -210,6 +210,10 @@
}
}
+ public QueryServiceServlet(final ILangCompilationProvider compilationProvider) {
+ this.compilationProvider = compilationProvider;
+ }
+
private static String getParameterValue(String content, String attribute) {
int sc = content.indexOf(';');
if (sc < 0) {
diff --git a/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java b/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
index b77544e..916c81f 100644
--- a/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
+++ b/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
@@ -233,7 +233,7 @@
case QUERY_RESULT:
return new QueryResultAPIServlet();
case QUERY_SERVICE:
- return new QueryServiceServlet();
+ return new QueryServiceServlet(new SqlppCompilationProvider());
case CONNECTOR:
return new ConnectorAPIServlet();
case SHUTDOWN:
--
To view, visit https://asterix-gerrit.ics.uci.edu/1043
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I795a2dab622ab40b39f6aaf548a27ffbd40c9efd
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Change in asterixdb[master]: Pass compilation provider to QueryServiceServlet
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: Pass compilation provider to QueryServiceServlet
......................................................................
Patch Set 1: Integration-Tests+1
Integration Tests Successful
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/233/ : SUCCESS
--
To view, visit https://asterix-gerrit.ics.uci.edu/1043
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I795a2dab622ab40b39f6aaf548a27ffbd40c9efd
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: Pass compilation provider to QueryServiceServlet
Posted by "Till Westmann (Code Review)" <do...@asterixdb.incubator.apache.org>.
Till Westmann has submitted this change and it was merged.
Change subject: Pass compilation provider to QueryServiceServlet
......................................................................
Pass compilation provider to QueryServiceServlet
Change-Id: I795a2dab622ab40b39f6aaf548a27ffbd40c9efd
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1043
Sonar-Qube: Jenkins <je...@fulliautomatix.ics.uci.edu>
Tested-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
Integration-Tests: Jenkins <je...@fulliautomatix.ics.uci.edu>
Reviewed-by: Yingyi Bu <bu...@gmail.com>
---
M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
M asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
2 files changed, 6 insertions(+), 2 deletions(-)
Approvals:
Yingyi Bu: Looks good to me, approved
Jenkins: Verified; No violations found; Verified
diff --git a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
index 2e6ee58..f208694 100644
--- a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
+++ b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
@@ -61,7 +61,7 @@
private static final Logger LOGGER = Logger.getLogger(QueryServiceServlet.class.getName());
- private transient final ILangCompilationProvider compilationProvider = new SqlppCompilationProvider();
+ private transient final ILangCompilationProvider compilationProvider;
public enum Parameter {
// Standard
@@ -210,6 +210,10 @@
}
}
+ public QueryServiceServlet(final ILangCompilationProvider compilationProvider) {
+ this.compilationProvider = compilationProvider;
+ }
+
private static String getParameterValue(String content, String attribute) {
int sc = content.indexOf(';');
if (sc < 0) {
diff --git a/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java b/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
index b77544e..916c81f 100644
--- a/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
+++ b/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
@@ -233,7 +233,7 @@
case QUERY_RESULT:
return new QueryResultAPIServlet();
case QUERY_SERVICE:
- return new QueryServiceServlet();
+ return new QueryServiceServlet(new SqlppCompilationProvider());
case CONNECTOR:
return new ConnectorAPIServlet();
case SHUTDOWN:
--
To view, visit https://asterix-gerrit.ics.uci.edu/1043
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I795a2dab622ab40b39f6aaf548a27ffbd40c9efd
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Yingyi Bu <bu...@gmail.com>
Change in asterixdb[master]: Pass compilation provider to QueryServiceServlet
Posted by "Yingyi Bu (Code Review)" <do...@asterixdb.incubator.apache.org>.
Yingyi Bu has posted comments on this change.
Change subject: Pass compilation provider to QueryServiceServlet
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://asterix-gerrit.ics.uci.edu/1043
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I795a2dab622ab40b39f6aaf548a27ffbd40c9efd
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Yingyi Bu <bu...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: Pass compilation provider to QueryServiceServlet
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: Pass compilation provider to QueryServiceServlet
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2102/
--
To view, visit https://asterix-gerrit.ics.uci.edu/1043
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I795a2dab622ab40b39f6aaf548a27ffbd40c9efd
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: Pass compilation provider to QueryServiceServlet
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: Pass compilation provider to QueryServiceServlet
......................................................................
Patch Set 1:
Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/233/
--
To view, visit https://asterix-gerrit.ics.uci.edu/1043
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I795a2dab622ab40b39f6aaf548a27ffbd40c9efd
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No