[GitHub] [iotdb] mychaow commented on a change in pull request #1721: [IOTDB-868] fix comma bug for mlog

[GitBox <gi...@apache.org>]

mychaow commented on a change in pull request #1721:
URL: https://github.com/apache/iotdb/pull/1721#discussion_r542152881



##########
File path: server/src/main/java/org/apache/iotdb/db/conf/IoTDBConfig.java
##########
@@ -204,12 +204,18 @@
 
   /**
    * Size of log buffer in each log node(in byte). If WAL is enabled and the size of a insert plan
-   * is smaller than this parameter, then the insert plan will be rejected by WAL.
+   * is larger than this parameter, then the insert plan will be rejected by WAL.
    */
   private int walBufferSize = 16 * 1024 * 1024;
 
   private int estimatedSeriesSize = 300;
 
+  /**
+   * Size of log buffer for every MetaData operation. If the size of a MetaData operation plan
+   * is larger than this parameter, then the MetaData operation plan will be rejected by MManager.
+   */
+  private int mlogBufferSize = 1024 * 1024;

Review comment:
       > There is not a thread to do the periodic Channel.force(true) for MLogWriter, is this meet our expectation?
   
   Not，just when we use thread pool to write, and we call shutdown to interrupt the thread, see this
   https://stackoverflow.com/questions/1161297/why-are-we-getting-closedbyinterruptexception-from-filechannel-map-in-java-1-6




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org