You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/06/05 08:24:30 UTC
[GitHub] [incubator-doris] imay commented on a change in pull request #3677: [WIP] Support materialized view load and insert
imay commented on a change in pull request #3677:
URL: https://github.com/apache/incubator-doris/pull/3677#discussion_r435660643
##########
File path: fe/src/main/java/org/apache/doris/analysis/InsertStmt.java
##########
@@ -453,6 +453,25 @@ private void analyzeSubquery(Analyzer analyzer) throws UserException {
}
}
+ Map<Integer, Integer> origColIdxsForMVCols = Maps.newHashMap();
Review comment:
Comment about what does this code do
##########
File path: fe/src/main/java/org/apache/doris/load/Load.java
##########
@@ -1013,6 +1013,13 @@ public static void initColumns(Table tbl, List<ImportColumnDesc> columnExprs,
slotDescByName.put(realColName, slotDesc);
}
}
+ //The extension column of the materialized view is added to the expression evaluation of load
Review comment:
```suggestion
// The extension column of the materialized view is added to the expression evaluation of load
```
##########
File path: fe/src/main/java/org/apache/doris/analysis/InsertStmt.java
##########
@@ -453,6 +453,25 @@ private void analyzeSubquery(Analyzer analyzer) throws UserException {
}
}
+ Map<Integer, Integer> origColIdxsForMVCols = Maps.newHashMap();
Review comment:
In general, use `to` in map's name.
```suggestion
Map<Integer, Integer> origColIdx2MvColIdx = Maps.newHashMap();
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org