You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2025/11/05 19:44:55 UTC

[Impala-ASF-CR] IMPALA-14531: Ignore new Hive config

Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23639


Change subject: IMPALA-14531: Ignore new Hive config
......................................................................

IMPALA-14531: Ignore new Hive config

Change-Id: Ic59caffc1f8b2a4e8693cb5e2770787f4817167e
---
M fe/src/test/resources/.gitignore
1 file changed, 2 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/39/23639/1
-- 
To view, visit http://gerrit.cloudera.org:8080/23639
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic59caffc1f8b2a4e8693cb5e2770787f4817167e
Gerrit-Change-Number: 23639
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>

[Impala-ASF-CR] IMPALA-14531: Ignore new Hive config

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23639 )

Change subject: IMPALA-14531: Ignore new Hive config
......................................................................


Patch Set 1: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/23639
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic59caffc1f8b2a4e8693cb5e2770787f4817167e
Gerrit-Change-Number: 23639
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Comment-Date: Wed, 05 Nov 2025 22:40:49 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14531: Ignore new Hive config

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23639 )

Change subject: IMPALA-14531: Ignore new Hive config
......................................................................


Patch Set 1:

Basic build is sufficient.


-- 
To view, visit http://gerrit.cloudera.org:8080/23639
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic59caffc1f8b2a4e8693cb5e2770787f4817167e
Gerrit-Change-Number: 23639
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Comment-Date: Wed, 05 Nov 2025 22:40:58 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14531: Ignore new Hive config

Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/23639 )

Change subject: IMPALA-14531: Ignore new Hive config
......................................................................


Patch Set 1: Code-Review+2

Thanks for taking care of this Michael!


-- 
To view, visit http://gerrit.cloudera.org:8080/23639
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic59caffc1f8b2a4e8693cb5e2770787f4817167e
Gerrit-Change-Number: 23639
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Comment-Date: Wed, 05 Nov 2025 22:08:30 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14531: Ignore new Hive config

Posted by "Sai Hemanth Gantasala (Code Review)" <ge...@cloudera.org>.
Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/23639 )

Change subject: IMPALA-14531: Ignore new Hive config
......................................................................


Patch Set 1: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/23639
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic59caffc1f8b2a4e8693cb5e2770787f4817167e
Gerrit-Change-Number: 23639
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Comment-Date: Wed, 05 Nov 2025 19:50:45 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14531: Ignore new Hive config

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23639 )

Change subject: IMPALA-14531: Ignore new Hive config
......................................................................

IMPALA-14531: Ignore new Hive config

Change-Id: Ic59caffc1f8b2a4e8693cb5e2770787f4817167e
Reviewed-on: http://gerrit.cloudera.org:8080/23639
Reviewed-by: Sai Hemanth Gantasala <sa...@cloudera.com>
Reviewed-by: Fang-Yu Rao <fa...@cloudera.com>
Tested-by: Michael Smith <mi...@cloudera.com>
---
M fe/src/test/resources/.gitignore
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Sai Hemanth Gantasala: Looks good to me, but someone else must approve
  Fang-Yu Rao: Looks good to me, approved
  Michael Smith: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/23639
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic59caffc1f8b2a4e8693cb5e2770787f4817167e
Gerrit-Change-Number: 23639
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>

[Impala-ASF-CR] IMPALA-14531: Ignore new Hive config

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23639 )

Change subject: IMPALA-14531: Ignore new Hive config
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/20826/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/23639
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic59caffc1f8b2a4e8693cb5e2770787f4817167e
Gerrit-Change-Number: 23639
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Comment-Date: Wed, 05 Nov 2025 20:11:52 +0000
Gerrit-HasComments: No