You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/09 08:37:09 UTC
[GitHub] [spark] cloud-fan commented on a change in pull request #32037: [SPARK-34944][SQL][TESTS] Replace bigint with int for web_returns and store_returns in TPCDS tests to employ correct data type
cloud-fan commented on a change in pull request #32037:
URL: https://github.com/apache/spark/pull/32037#discussion_r610450645
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/TPCDSBase.scala
##########
@@ -21,6 +21,47 @@ import org.apache.spark.sql.catalyst.TableIdentifier
import org.apache.spark.sql.internal.SQLConf
import org.apache.spark.sql.test.SharedSparkSession
+
+/**
+ * Base trait for TPC-DS related tests.
+ *
+ * Datatype mapping for TPC-DS and Spark SQL, see more at:
+ * http://www.tpc.org/tpc_documents_current_versions/pdf/tpc-ds_v2.9.0.pdf
+ *
+ * |---------------|---------------|
+ * | TPC-DS | Spark SQL |
+ * |---------------|---------------|
+ * | Identifier | INT |
+ * |---------------|---------------|
+ * | Integer | INT |
+ * |---------------|---------------|
+ * | Decimal(d, f) | Decimal(d, f) |
+ * |---------------|---------------|
+ * | Char(N) | Char(N) |
+ * |---------------|---------------|
+ * | Varchar(N) | Varchar(N) |
+ * |---------------|---------------|
+ * | Date | Date |
+ * |---------------|---------------|
+ *
+ * Remarks:
Review comment:
these remarks don't seem to be useful. It's more important to mention that the table schema matches the official tpcds toolkit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org