You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2021/10/08 09:07:23 UTC

[GitHub] [zeppelin] zjffdu commented on a change in pull request #4116: [ZEPPELIN-5352] Support flink in k8s mode

zjffdu commented on a change in pull request #4116:
URL: https://github.com/apache/zeppelin/pull/4116#discussion_r724837493



##########
File path: zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterServer.java
##########
@@ -142,6 +141,7 @@
   private ScheduledExecutorService resultCleanService = Executors.newSingleThreadScheduledExecutor();
 
   private boolean isTest;
+  private boolean isFlinkK8sApplicationMode = false;

Review comment:
       Update this PR by change `isFlinkK8sApplicationMode` to `isForceShutdown` which is not interpreter specific. Each interpreter can not control this behavior by its interpreter setting properties. I just set this property in `FlinkInterpreterLauncher`.
   
   Ready for review again. @Reamer 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org