You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/12/15 08:06:03 UTC
[GitHub] [skywalking-nodejs] QuanjieDeng opened a new pull request #12: Init the client twoice,Make sure the config take effect
QuanjieDeng opened a new pull request #12:
URL: https://github.com/apache/skywalking-nodejs/pull/12
This may not be the optimal solution, but at present I can only modify it like this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] kezhenxu94 merged pull request #12: Init the client twoice,Make sure the config take effect
Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #12:
URL: https://github.com/apache/skywalking-nodejs/pull/12
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] kezhenxu94 commented on pull request #12: Init the client twoice,Make sure the config take effect
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #12:
URL: https://github.com/apache/skywalking-nodejs/pull/12#issuecomment-745160857
Another workaround is to set the config via environment variables
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] kezhenxu94 commented on pull request #12: Init the client twoice,Make sure the config take effect
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #12:
URL: https://github.com/apache/skywalking-nodejs/pull/12#issuecomment-745205592
Hey @QuanjieDeng , why do you close the PR, the fix is correct, I just wanted you to remove the duplicated initialization in the constructors
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] kezhenxu94 commented on a change in pull request #12: Init the client twoice,Make sure the config take effect
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #12:
URL: https://github.com/apache/skywalking-nodejs/pull/12#discussion_r543174774
##########
File path: src/agent/protocol/grpc/clients/HeartbeatClient.ts
##########
@@ -47,6 +47,13 @@ class HeartbeatClient implements Client {
}
start() {
+ /*
+ init the heartbeatClient again
+ */
Review comment:
Remove this comment and the initialization in the `constructor`
##########
File path: src/agent/protocol/grpc/clients/TraceReportClient.ts
##########
@@ -50,6 +50,14 @@ class TraceReportClient implements Client {
}
start() {
+ /*
+ init the reporterClient again
+ */
Review comment:
Remove this comment and the initialization in the `constructor`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] kezhenxu94 commented on pull request #12: Init the client twoice,Make sure the config take effect
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #12:
URL: https://github.com/apache/skywalking-nodejs/pull/12#issuecomment-747925775
> > Hey @QuanjieDeng , why do you close the PR, the fix is correct, I just wanted you to remove the duplicated initialization in the constructors
>
> yes,Im not good at TypeScript,Im trying fix this bug
It's OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] QuanjieDeng commented on pull request #12: Init the client twoice,Make sure the config take effect
Posted by GitBox <gi...@apache.org>.
QuanjieDeng commented on pull request #12:
URL: https://github.com/apache/skywalking-nodejs/pull/12#issuecomment-747918826
> Hey @QuanjieDeng , why do you close the PR, the fix is correct, I just wanted you to remove the duplicated initialization in the constructors
yes,Im not good at TypeScript,Im trying fix this bug
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] QuanjieDeng closed pull request #12: Init the client twoice,Make sure the config take effect
Posted by GitBox <gi...@apache.org>.
QuanjieDeng closed pull request #12:
URL: https://github.com/apache/skywalking-nodejs/pull/12
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org