You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by mgaido91 <gi...@git.apache.org> on 2018/06/04 11:18:52 UTC
[GitHub] nifi pull request #2754: NIFI-5262: Retrieve file attributes only once in Li...
GitHub user mgaido91 opened a pull request:
https://github.com/apache/nifi/pull/2754
NIFI-5262: Retrieve file attributes only once in ListFile
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mgaido91/nifi NIFI-5262
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2754.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2754
----
commit 9ab780f7f8ba0dd0782796b09e734102ffb9d42f
Author: Marco Gaido <ma...@...>
Date: 2018-06-04T11:16:49Z
[NIFI-5262] Retrieve file attributes only once in ListFile
----
---
[GitHub] nifi issue #2754: NIFI-5262: Retrieve file attributes only once in ListFile
Posted by pvillard31 <gi...@git.apache.org>.
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2754
@zenfenan - I've tested the change with a simple flow. Are you thinking about a specific edge case? I'm not sure to see how this would affect the logic.
---
[GitHub] nifi issue #2754: NIFI-5262: Retrieve file attributes only once in ListFile
Posted by pvillard31 <gi...@git.apache.org>.
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2754
Code LGTM, full build OK, merging to master, thanks @mgaido91
---
[GitHub] nifi pull request #2754: NIFI-5262: Retrieve file attributes only once in Li...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/2754
---
[GitHub] nifi issue #2754: NIFI-5262: Retrieve file attributes only once in ListFile
Posted by zenfenan <gi...@git.apache.org>.
Github user zenfenan commented on the issue:
https://github.com/apache/nifi/pull/2754
@pvillard31 My bad.. I understood the Jira description in the wrong way. Once I went through the changes, I understood the actual intention. Sorry about that. Thanks.
@mgaido91 Thanks for the contribution. :)
---
[GitHub] nifi issue #2754: NIFI-5262: Retrieve file attributes only once in ListFile
Posted by mgaido91 <gi...@git.apache.org>.
Github user mgaido91 commented on the issue:
https://github.com/apache/nifi/pull/2754
thanks @pvillard31
---