[GitHub] [arrow] kiszk commented on a change in pull request #10350: ARROW-12814: [C++][Gandiva] Implements ABS, FLOOR, PI, SQRT, SIGN, LSHIFT, RSHIFT, CEIL, TRUNC, LN and LOG2 functions

[GitBox <gi...@apache.org>]

kiszk commented on a change in pull request #10350:
URL: https://github.com/apache/arrow/pull/10350#discussion_r654332132



##########
File path: cpp/src/gandiva/gdv_function_stubs_test.cc
##########
@@ -484,4 +493,53 @@ TEST(TestGdvFnStubs, TestInitCap) {
                   "unexpected byte \\e0 encountered while decoding utf8 string"));
   ctx.Reset();
 }
+
+TEST(TestGdvFnStubs, TestAbs) {
+  gandiva::ExecutionContext ctx;
+  uint64_t ctx_ptr = reinterpret_cast<int64_t>(&ctx);
+
+  // Abs functions
+  EXPECT_EQ(gdv_fn_abs_int32(ctx_ptr, 0), 0);
+  EXPECT_EQ(gdv_fn_abs_uint32(ctx_ptr, 0), 0);
+  EXPECT_EQ(gdv_fn_abs_int64(ctx_ptr, 0), 0L);
+  EXPECT_EQ(gdv_fn_abs_uint64(ctx_ptr, 0), 0L);
+  VerifyAlmostEquals(gdv_fn_abs_float32(ctx_ptr, 0.0f), abs(0.0f));
+  VerifyAlmostEquals(gdv_fn_abs_float64(ctx_ptr, 0.0), abs(0.0));
+
+  VerifyAlmostEquals(gdv_fn_abs_int32(ctx_ptr, (INT32_MIN + 1)),
+                     abs(static_cast<double>(INT32_MIN + 1)));
+  VerifyAlmostEquals(gdv_fn_abs_int64(ctx_ptr, (INT32_MIN + 1)),
+                     abs(static_cast<double>(INT32_MIN + 1)));
+  VerifyAlmostEquals(gdv_fn_abs_float32(ctx_ptr, static_cast<float>(INT32_MIN + 1)),
+                     abs(static_cast<float>(INT32_MIN + 1)));
+  VerifyAlmostEquals(gdv_fn_abs_float64(ctx_ptr, static_cast<double>(INT32_MIN + 1)),
+                     abs(static_cast<double>(INT32_MIN + 1)));
+
+  EXPECT_EQ(gdv_fn_abs_int64(ctx_ptr, (INT64_MIN + 1)),
+            abs(static_cast<double>(INT64_MIN + 1)));
+  VerifyAlmostEquals(gdv_fn_abs_float64(ctx_ptr, static_cast<double>(INT64_MIN + 1)),
+                     abs(static_cast<double>(INT64_MIN + 1)));
+

Review comment:
       How about adding tests for min and max values of double and float by using `std::numeric_limits`?

##########
File path: cpp/src/gandiva/precompiled/extended_math_ops_test.cc
##########
@@ -273,4 +333,142 @@ TEST(TestExtendedMathOps, TestTrigonometricFunctions) {
   VerifyFuzzyEquals(cot_float64(M_PI / 2), tan(M_PI / 2 - M_PI / 2));
 }
 
+TEST(TestExtendedMathOps, TestCeil) {
+  // Ceil functions
+  VerifyFuzzyEquals(ceil_float32(0), ceil(0));
+  VerifyFuzzyEquals(ceil_float64(0), ceil(0));
+
+  VerifyFuzzyEquals(ceil_float32(-5), ceil(-5));
+  VerifyFuzzyEquals(ceil_float64(-5), ceil(-5));
+
+  VerifyFuzzyEquals(ceil_float32(-2371041), ceil(-2371041));
+  VerifyFuzzyEquals(ceil_float64(-2371041), ceil(-2371041));
+
+  VerifyFuzzyEquals(ceil_float32(5.45f), ceil(5.45));
+  VerifyFuzzyEquals(ceil_float64(5.45), ceil(5.45));
+
+  VerifyFuzzyEquals(ceil_float32(-3600.50f), ceil(-3600.50));
+  VerifyFuzzyEquals(ceil_float64(-3600.50), ceil(-3600.50));
+}
+
+TEST(TestExtendedMathOps, TestFloor) {
+  // Ceil functions
+  VerifyFuzzyEquals(floor_float32(0), floor(0));
+  VerifyFuzzyEquals(floor_float64(0), floor(0));
+
+  VerifyFuzzyEquals(floor_float32(-5), floor(-5));
+  VerifyFuzzyEquals(floor_float64(-5), floor(-5));
+
+  VerifyFuzzyEquals(floor_float32(-2371041), floor(-2371041));
+  VerifyFuzzyEquals(floor_float64(-2371041), floor(-2371041));
+
+  VerifyFuzzyEquals(floor_float32(5.45f), floor(5.45));
+  VerifyFuzzyEquals(floor_float64(5.45), floor(5.45));
+
+  VerifyFuzzyEquals(floor_float32(-3600.50f), floor(-3600.50));
+  VerifyFuzzyEquals(floor_float64(-3600.50), floor(-3600.50));
+}
+
+TEST(TestExtendedMathOps, TestConstants) {
+  // Constants functions
+  VerifyFuzzyEquals(pi(), M_PI);
+  VerifyFuzzyEquals(e(), exp(1.0));
+}
+
+TEST(TestExtendedMathOps, TestSqrt) {
+  // Sqrt functions
+  VerifyFuzzyEquals(sqrt_int32(0), sqrt(0));
+  VerifyFuzzyEquals(sqrt_int64(0), sqrt(0));
+  VerifyFuzzyEquals(sqrt_float32(0), sqrt(0));
+  VerifyFuzzyEquals(sqrt_float64(0), sqrt(0));
+
+  VerifyFuzzyEquals(sqrt_int32(5), sqrt(5));
+  VerifyFuzzyEquals(sqrt_int64(5), sqrt(5));
+  VerifyFuzzyEquals(sqrt_float32(5), sqrt(5));
+  VerifyFuzzyEquals(sqrt_float64(5), sqrt(5));
+
+  VerifyFuzzyEquals(sqrt_int32(2371041), sqrt(2371041));
+  VerifyFuzzyEquals(sqrt_int64(2371041), sqrt(2371041));
+  VerifyFuzzyEquals(sqrt_float32(2371041), sqrt(2371041));
+  VerifyFuzzyEquals(sqrt_float64(2371041), sqrt(2371041));
+
+  VerifyFuzzyEquals(sqrt_float32(3600.50f), sqrt(3600.50));
+  VerifyFuzzyEquals(sqrt_float64(3600.50), sqrt(3600.50));
+}
+
+TEST(TestExtendedMathOps, TestSign) {
+  // Sqrt functions
+  EXPECT_EQ(sign_int32(0), 0);
+  EXPECT_EQ(sign_int64(0), 0);
+  EXPECT_EQ(sign_float32(0), 0);
+  EXPECT_EQ(sign_float64(0), 0);
+
+  EXPECT_EQ(sign_int32(5), 1);
+  EXPECT_EQ(sign_int64(5), 1);
+  EXPECT_EQ(sign_float32(5), 1);
+  EXPECT_EQ(sign_float64(5), 1);
+
+  EXPECT_EQ(sign_int32(2371041), 1);
+  EXPECT_EQ(sign_int64(2371041), 1);
+  EXPECT_EQ(sign_float32(2371041), 1);
+  EXPECT_EQ(sign_float64(2371041), 1);
+
+  EXPECT_EQ(sign_int32(-3600), -1);
+  EXPECT_EQ(sign_int64(-3600), -1);
+  EXPECT_EQ(sign_float32(-3600.50f), -1);
+  EXPECT_EQ(sign_float64(-3600.50), -1);
+}
+
+TEST(TestExtendedMathOps, TestLshiftRshift) {

Review comment:
       How about adding tests with large shift values?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org