You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pivot.apache.org by Chris Bartlett <cb...@googlemail.com> on 2010/09/25 19:52:22 UTC
Re: svn commit: r1001212 - in /pivot/trunk: wtk-terra/src/org/apache/pivot/wtk/skin/terra/
wtk/src/org/apache/pivot/wtk/ wtk/src/org/apache/pivot/wtk/skin/
Greg,
GMail/Opera are having problems quoting this, so I'll have to rely on these
diff links
ApplicationContext.java - You have left a debug statement in here (assuming
you have finished working on PIVOT-646)
http://svn.apache.org/viewvc/pivot/trunk/wtk/src/org/apache/pivot/wtk/ApplicationContext.java?view=diff&r1=1001211&r2=1001212&pathrev=1001212
Component.java - This causes a NPE when starting ComponentExplorer
http://svn.apache.org/viewvc/pivot/trunk/wtk/src/org/apache/pivot/wtk/Component.java?view=diff&r1=1001211&r2=1001212&pathrev=1001212
Chris
On 25 September 2010 21:12, <gb...@apache.org> wrote:
> Author: gbrown
> Date: Sat Sep 25 14:12:16 2010
> New Revision: 1001212
>
> URL: http://svn.apache.org/viewvc?rev=1001212&view=rev
> Log:
> Resolve PIVOT-646.
>
> Modified:
>
> pivot/trunk/wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraCalendarButtonSkin.java
>
> pivot/trunk/wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraColorChooserButtonSkin.java
>
> pivot/trunk/wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraListButtonSkin.java
>
> pivot/trunk/wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraMenuButtonSkin.java
> pivot/trunk/wtk/src/org/apache/pivot/wtk/ApplicationContext.java
> pivot/trunk/wtk/src/org/apache/pivot/wtk/Component.java
> pivot/trunk/wtk/src/org/apache/pivot/wtk/skin/CalendarButtonSkin.java
>
> pivot/trunk/wtk/src/org/apache/pivot/wtk/skin/ColorChooserButtonSkin.java
> pivot/trunk/wtk/src/org/apache/pivot/wtk/skin/ListButtonSkin.java
> pivot/trunk/wtk/src/org/apache/pivot/wtk/skin/MenuButtonSkin.java
>
Re: svn commit: r1001212 - in /pivot/trunk:
wtk-terra/src/org/apache/pivot/wtk/skin/terra/ wtk/src/org/apache/pivot/wtk/
wtk/src/org/apache/pivot/wtk/skin/
Posted by Greg Brown <gk...@mac.com>.
>>> ApplicationContext.java - You have left a debug statement in here (assuming
>>> you have finished working on PIVOT-646)
>>>
>> http://svn.apache.org/viewvc/pivot/trunk/wtk/src/org/apache/pivot/wtk/ApplicationContext.java?view=diff&r1=1001211&r2=1001212&pathrev=1001212
>>
>> That was actually intentional. I found it helpful in identifying focus
>> problems, because it isn't always clear what component is being decorated by
>> the focus decorator (for example, when a list button popup opens, you can't
>> tell if the popup itself has the focus, or the ListView within the popup).
>> But it does sort of spam the output - if we could come up with a nicer way
>> to do it, that would be cool.
>>
>>
>>
> What about an OverlayDecorator with big bold text in the corner like you
> might see in a video game showing frames per second?
I had a similar thought, but had not thought of using OverlayDecorator...we could potentially set a Label with a semi-transparent background color as the overlay component.
Re: svn commit: r1001212 - in /pivot/trunk: wtk-terra/src/org/apache/pivot/wtk/skin/terra/
wtk/src/org/apache/pivot/wtk/ wtk/src/org/apache/pivot/wtk/skin/
Posted by Chris Bartlett <cb...@gmail.com>.
On 26 September 2010 02:14, Greg Brown <gk...@mac.com> wrote:
> > ApplicationContext.java - You have left a debug statement in here
> (assuming
> > you have finished working on PIVOT-646)
> >
> http://svn.apache.org/viewvc/pivot/trunk/wtk/src/org/apache/pivot/wtk/ApplicationContext.java?view=diff&r1=1001211&r2=1001212&pathrev=1001212
>
> That was actually intentional. I found it helpful in identifying focus
> problems, because it isn't always clear what component is being decorated by
> the focus decorator (for example, when a list button popup opens, you can't
> tell if the popup itself has the focus, or the ListView within the popup).
> But it does sort of spam the output - if we could come up with a nicer way
> to do it, that would be cool.
>
>
>
What about an OverlayDecorator with big bold text in the corner like you
might see in a video game showing frames per second?
Re: svn commit: r1001212 - in /pivot/trunk:
wtk-terra/src/org/apache/pivot/wtk/skin/terra/ wtk/src/org/apache/pivot/wtk/
wtk/src/org/apache/pivot/wtk/skin/
Posted by Greg Brown <gk...@mac.com>.
> ApplicationContext.java - You have left a debug statement in here (assuming
> you have finished working on PIVOT-646)
> http://svn.apache.org/viewvc/pivot/trunk/wtk/src/org/apache/pivot/wtk/ApplicationContext.java?view=diff&r1=1001211&r2=1001212&pathrev=1001212
That was actually intentional. I found it helpful in identifying focus problems, because it isn't always clear what component is being decorated by the focus decorator (for example, when a list button popup opens, you can't tell if the popup itself has the focus, or the ListView within the popup). But it does sort of spam the output - if we could come up with a nicer way to do it, that would be cool.
> Component.java - This causes a NPE when starting ComponentExplorer
> http://svn.apache.org/viewvc/pivot/trunk/wtk/src/org/apache/pivot/wtk/Component.java?view=diff&r1=1001211&r2=1001212&pathrev=1001212
(smacks forehead)
Thanks. :-P