You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Aias00 (via GitHub)" <gi...@apache.org> on 2026/10/20 07:05:29 UTC
[PR] fix(nameserver): make registry replacements atomic [rocketmq-dashboard]
Aias00 opened a new pull request, #7231:
URL: https://github.com/apache/rocketmq-dashboard/pull/7231
A registry edit first updates required/non-null values, then clears omitted optional values in a second statement. If that second write fails, the edit reports an error but the new name/address have already committed.
Make the existing public update operation transactional so the replacement commits or rolls back as one operation.
Fixes #7229
Validation:
- Added real H2/Spring-proxy integration tests for a second-write failure and a successful replacement. The failure test verifies that the first statement executed before the injected error and that all original values survive after rollback. It fails on the original code because the new name remains committed.
- Success control verifies committed name/address and null K8s namespace, K8s ID and description in both database and returned value.
- Full nameserver package with dev profile: **77 tests, 0 failures, 0 errors, 0 skipped**.
- Bound Checkstyle and `git diff --check` pass.
Tested with JDK 21 and H2 in MySQL compatibility mode; no live MySQL/Broker or full-repository suite was run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(nameserver): make registry replacements atomic [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins merged PR #7231:
URL: https://github.com/apache/rocketmq-dashboard/pull/7231
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org