You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2019/12/26 01:03:33 UTC

[GitHub] [incubator-hudi] lamber-ken opened a new pull request #1138: [HUDI-470] Fix NPE when print result via hudi-cli

lamber-ken opened a new pull request #1138: [HUDI-470] Fix NPE when print result via hudi-cli
URL: https://github.com/apache/incubator-hudi/pull/1138
 
 
   ## What is the purpose of the pull request
   
   The size of `rows` is error, for example 
   ```
   List<String> allRecords = Arrays.asList();
   
   String[][] rows = new String[allRecords.size() + 1][];
   int i = 0;
   for (String record : allRecords) {
       String[] data = new String[1];
       data[0] = record;
       rows[i++] = data;
   }
   
   HoodiePrintHelper.print(new String[]{"Partition Path"}, rows);
   ```
   Result is:
   ```
   Exception in thread "main" java.lang.NullPointerException
   	at com.jakewharton.fliptables.FlipTable.<init>(FlipTable.java:37)
   	at com.jakewharton.fliptables.FlipTable.of(FlipTable.java:20)
   	at org.apache.hudi.cli.HoodiePrintHelper.printTextTable(HoodiePrintHelper.java:110)
   	at org.apache.hudi.cli.HoodiePrintHelper.print(HoodiePrintHelper.java:43)
   	at org.apache.hudi.cli.commands.RepairsCommand.main(RepairsCommand.java:127)
   ```
   
   ## Brief change log
   
     - Fix NPE when print result via hudi-cli
   
   ## Verify this pull request
   
   This pull request is a code cleanup without any test coverage.
   
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-hudi] vinothchandar commented on issue #1138: [HUDI-470] Fix NPE when print result via hudi-cli

Posted by GitBox <gi...@apache.org>.
vinothchandar commented on issue #1138: [HUDI-470] Fix NPE when print result via hudi-cli
URL: https://github.com/apache/incubator-hudi/pull/1138#issuecomment-569755666
 
 
   https://issues.apache.org/jira/browse/HUDI-487 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-hudi] yanghua commented on issue #1138: [HUDI-470] Fix NPE when print result via hudi-cli

Posted by GitBox <gi...@apache.org>.
yanghua commented on issue #1138: [HUDI-470] Fix NPE when print result via hudi-cli
URL: https://github.com/apache/incubator-hudi/pull/1138#issuecomment-569001616
 
 
   It's a pity. These methods have not unit tests. It would be good to find these issues if we have. Additionally, we can give more detailed information in Jira Description just like what you did in the PR's description. WDYT?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-hudi] lamber-ken commented on issue #1138: [HUDI-470] Fix NPE when print result via hudi-cli

Posted by GitBox <gi...@apache.org>.
lamber-ken commented on issue #1138: [HUDI-470] Fix NPE when print result via hudi-cli
URL: https://github.com/apache/incubator-hudi/pull/1138#issuecomment-569002628
 
 
   > It's a pity. These methods have not unit tests. It would be good to find these issues if we have. Additionally, we can give more detailed information in Jira Description just like what you did in the PR's description. WDYT?
   
   +1, manay methods need unit tests, will rich the jira description.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-hudi] yanghua merged pull request #1138: [HUDI-470] Fix NPE when print result via hudi-cli

Posted by GitBox <gi...@apache.org>.
yanghua merged pull request #1138: [HUDI-470] Fix NPE when print result via hudi-cli
URL: https://github.com/apache/incubator-hudi/pull/1138
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services