You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2022/09/01 11:47:32 UTC
[GitHub] [mynewt-nimble] sjanc opened a new pull request, #1345: Improvements fro SKY66112
sjanc opened a new pull request, #1345:
URL: https://github.com/apache/mynewt-nimble/pull/1345
This add support for runtime configuration of SKY66112 FEM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1345: Improvements for SKY66112
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on PR #1345:
URL: https://github.com/apache/mynewt-nimble/pull/1345#issuecomment-1241843770
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1345: Improvements for SKY66112
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on PR #1345:
URL: https://github.com/apache/mynewt-nimble/pull/1345#issuecomment-1241836640
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### nimble/drivers/nrf5340/src/ble_phy.c
<details>
```diff
@@ -60,7 +60,7 @@
DPPIC_CHEN_CH3_Msk | DPPIC_CHEN_CH4_Msk | DPPIC_CHEN_CH5_Msk)
#define DPPI_CH_MASK_FEM (DPPI_CH_MASK(TIMER0_EVENTS_COMPARE_4) | \
- DPPI_CH_MASK(RADIO_EVENTS_DISABLED))
+ DPPI_CH_MASK(RADIO_EVENTS_DISABLED))
extern uint8_t g_nrf_num_irks;
extern uint32_t g_nrf_irk_list[];
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] sjanc merged pull request #1345: Improvements for SKY66112
Posted by GitBox <gi...@apache.org>.
sjanc merged PR #1345:
URL: https://github.com/apache/mynewt-nimble/pull/1345
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1345: Improvements fro SKY66112
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on PR #1345:
URL: https://github.com/apache/mynewt-nimble/pull/1345#issuecomment-1234169813
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1345: Improvements for SKY66112
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on PR #1345:
URL: https://github.com/apache/mynewt-nimble/pull/1345#issuecomment-1240982078
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### nimble/controller/src/ble_ll_hci_vs.c
<details>
```diff
@@ -355,7 +355,7 @@
#if MYNEWT_VAL(BLE_LL_FEM_ANTENNA)
static int
ble_ll_hci_vs_set_antenna(uint16_t ocf, const uint8_t *cmdbuf, uint8_t cmdlen,
- uint8_t *rspbuf, uint8_t *rsplen)
+ uint8_t *rspbuf, uint8_t *rsplen)
{
const struct ble_hci_vs_set_antenna_cp *cmd = (const void *) cmdbuf;
```
</details>
#### nimble/drivers/nrf52/src/ble_phy.c
<details>
```diff
@@ -324,8 +322,8 @@
#if MYNEWT_VAL(BLE_LL_FEM_PA) || MYNEWT_VAL(BLE_LL_FEM_LNA)
#define FEM_SINGLE_GPIO \
- (!MYNEWT_VAL(BLE_LL_FEM_PA) || !MYNEWT_VAL(BLE_LL_FEM_LNA) || \
- (MYNEWT_VAL(BLE_LL_FEM_PA_GPIO) == MYNEWT_VAL(BLE_LL_FEM_LNA_GPIO)))
+ (!MYNEWT_VAL(BLE_LL_FEM_PA) || !MYNEWT_VAL(BLE_LL_FEM_LNA) || \
+ (MYNEWT_VAL(BLE_LL_FEM_PA_GPIO) == MYNEWT_VAL(BLE_LL_FEM_LNA_GPIO)))
#if FEM_SINGLE_GPIO
static uint8_t fem_idx;
```
</details>
#### nimble/drivers/nrf5340/src/ble_phy.c
<details>
```diff
@@ -60,7 +60,7 @@
DPPIC_CHEN_CH3_Msk | DPPIC_CHEN_CH4_Msk | DPPIC_CHEN_CH5_Msk)
#define DPPI_CH_MASK_FEM (DPPI_CH_MASK(TIMER0_EVENTS_COMPARE_4) | \
- DPPI_CH_MASK(RADIO_EVENTS_DISABLED))
+ DPPI_CH_MASK(RADIO_EVENTS_DISABLED))
extern uint8_t g_nrf_num_irks;
extern uint32_t g_nrf_irk_list[];
@@ -247,8 +247,8 @@
#if MYNEWT_VAL(BLE_LL_FEM_PA) || MYNEWT_VAL(BLE_LL_FEM_LNA)
#define FEM_SINGLE_GPIO \
- (!MYNEWT_VAL(BLE_LL_FEM_PA) || !MYNEWT_VAL(BLE_LL_FEM_LNA) || \
- (MYNEWT_VAL(BLE_LL_FEM_PA_GPIO) == MYNEWT_VAL(BLE_LL_FEM_LNA_GPIO)))
+ (!MYNEWT_VAL(BLE_LL_FEM_PA) || !MYNEWT_VAL(BLE_LL_FEM_LNA) || \
+ (MYNEWT_VAL(BLE_LL_FEM_PA_GPIO) == MYNEWT_VAL(BLE_LL_FEM_LNA_GPIO)))
#if FEM_SINGLE_GPIO
static uint8_t fem_idx;
@@ -1257,20 +1258,20 @@
NRF_RADIO_NS->INTENCLR = RADIO_INTENCLR_DISABLED_Msk;
switch (g_ble_phy_data.phy_state) {
- case BLE_PHY_STATE_RX:
- ble_phy_fem_disable_lna();
- if (g_ble_phy_data.phy_rx_started) {
- ble_phy_rx_end_isr();
- } else {
- ble_ll_wfr_timer_exp(NULL);
- }
- break;
- case BLE_PHY_STATE_TX:
- ble_phy_fem_disable_pa();
- ble_phy_tx_end_isr();
- break;
- default:
- BLE_LL_ASSERT(0);
+ case BLE_PHY_STATE_RX:
+ ble_phy_fem_disable_lna();
+ if (g_ble_phy_data.phy_rx_started) {
+ ble_phy_rx_end_isr();
+ } else {
+ ble_ll_wfr_timer_exp(NULL);
+ }
+ break;
+ case BLE_PHY_STATE_TX:
+ ble_phy_fem_disable_pa();
+ ble_phy_tx_end_isr();
+ break;
+ default:
+ BLE_LL_ASSERT(0);
}
}
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1345: Improvements for SKY66112
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on PR #1345:
URL: https://github.com/apache/mynewt-nimble/pull/1345#issuecomment-1241824494
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### nimble/drivers/fem/sky66112/src/sky66112.c
<details>
```diff
@@ -24,11 +24,11 @@
#include "controller/ble_ll_fem.h"
static struct {
- uint8_t rx_bypass :1;
- uint8_t tx_bypass :1;
+ uint8_t rx_bypass : 1;
+ uint8_t tx_bypass : 1;
} sky66112_config = {
- .rx_bypass = MYNEWT_VAL(SKY66112_RX_BYPASS),
- .tx_bypass = MYNEWT_VAL(SKY66112_TX_BYPASS),
+ .rx_bypass = MYNEWT_VAL(SKY66112_RX_BYPASS),
+ .tx_bypass = MYNEWT_VAL(SKY66112_TX_BYPASS),
};
static void
@@ -100,7 +100,7 @@
int pin = MYNEWT_VAL(SKY66112_PIN_SEL);
if (pin >= 0) {
- switch(port) {
+ switch (port) {
case 0:
case 1:
hal_gpio_write(pin, 0);
```
</details>
#### nimble/drivers/nrf52/src/ble_phy.c
<details>
```diff
@@ -324,8 +322,8 @@
#if MYNEWT_VAL(BLE_LL_FEM_PA) || MYNEWT_VAL(BLE_LL_FEM_LNA)
#define FEM_SINGLE_GPIO \
- (!MYNEWT_VAL(BLE_LL_FEM_PA) || !MYNEWT_VAL(BLE_LL_FEM_LNA) || \
- (MYNEWT_VAL(BLE_LL_FEM_PA_GPIO) == MYNEWT_VAL(BLE_LL_FEM_LNA_GPIO)))
+ (!MYNEWT_VAL(BLE_LL_FEM_PA) || !MYNEWT_VAL(BLE_LL_FEM_LNA) || \
+ (MYNEWT_VAL(BLE_LL_FEM_PA_GPIO) == MYNEWT_VAL(BLE_LL_FEM_LNA_GPIO)))
#if FEM_SINGLE_GPIO
static uint8_t fem_idx;
```
</details>
#### nimble/drivers/nrf5340/src/ble_phy.c
<details>
```diff
@@ -60,7 +60,7 @@
DPPIC_CHEN_CH3_Msk | DPPIC_CHEN_CH4_Msk | DPPIC_CHEN_CH5_Msk)
#define DPPI_CH_MASK_FEM (DPPI_CH_MASK(TIMER0_EVENTS_COMPARE_4) | \
- DPPI_CH_MASK(RADIO_EVENTS_DISABLED))
+ DPPI_CH_MASK(RADIO_EVENTS_DISABLED))
extern uint8_t g_nrf_num_irks;
extern uint32_t g_nrf_irk_list[];
@@ -247,8 +247,8 @@
#if MYNEWT_VAL(BLE_LL_FEM_PA) || MYNEWT_VAL(BLE_LL_FEM_LNA)
#define FEM_SINGLE_GPIO \
- (!MYNEWT_VAL(BLE_LL_FEM_PA) || !MYNEWT_VAL(BLE_LL_FEM_LNA) || \
- (MYNEWT_VAL(BLE_LL_FEM_PA_GPIO) == MYNEWT_VAL(BLE_LL_FEM_LNA_GPIO)))
+ (!MYNEWT_VAL(BLE_LL_FEM_PA) || !MYNEWT_VAL(BLE_LL_FEM_LNA) || \
+ (MYNEWT_VAL(BLE_LL_FEM_PA_GPIO) == MYNEWT_VAL(BLE_LL_FEM_LNA_GPIO)))
#if FEM_SINGLE_GPIO
static uint8_t fem_idx;
@@ -1257,20 +1258,20 @@
NRF_RADIO_NS->INTENCLR = RADIO_INTENCLR_DISABLED_Msk;
switch (g_ble_phy_data.phy_state) {
- case BLE_PHY_STATE_RX:
- ble_phy_fem_disable_lna();
- if (g_ble_phy_data.phy_rx_started) {
- ble_phy_rx_end_isr();
- } else {
- ble_ll_wfr_timer_exp(NULL);
- }
- break;
- case BLE_PHY_STATE_TX:
- ble_phy_fem_disable_pa();
- ble_phy_tx_end_isr();
- break;
- default:
- BLE_LL_ASSERT(0);
+ case BLE_PHY_STATE_RX:
+ ble_phy_fem_disable_lna();
+ if (g_ble_phy_data.phy_rx_started) {
+ ble_phy_rx_end_isr();
+ } else {
+ ble_ll_wfr_timer_exp(NULL);
+ }
+ break;
+ case BLE_PHY_STATE_TX:
+ ble_phy_fem_disable_pa();
+ ble_phy_tx_end_isr();
+ break;
+ default:
+ BLE_LL_ASSERT(0);
}
}
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org