You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/08/02 08:22:54 UTC

[GitHub] [flink-table-store] tsreaper commented on a diff in pull request #259: [hotfix] Adjust the default value of WRITE_BUFFER_SIZE and NUM_SORTED_RUNS_STOP_TRIGGER

tsreaper commented on code in PR #259:
URL: https://github.com/apache/flink-table-store/pull/259#discussion_r935260471


##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/CoreOptions.java:
##########
@@ -191,7 +191,7 @@ public class CoreOptions implements Serializable {
     public static final ConfigOption<Integer> NUM_SORTED_RUNS_STOP_TRIGGER =
             ConfigOptions.key("num-sorted-run.stop-trigger")
                     .intType()
-                    .defaultValue(10)
+                    .noDefaultValue()
                     .withDescription(
                             "The number of sorted runs that trigger the stopping of writes.");

Review Comment:
   State that the default value equals to `numSortedRunCompactionTrigger + 1`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org