[GitHub] [nifi] jocovo edited a comment on pull request #5857: NIFI-9787: Increasing visibility of selected slickgrid row with 1px b…

[GitBox <gi...@apache.org>]

jocovo edited a comment on pull request #5857:
URL: https://github.com/apache/nifi/pull/5857#issuecomment-1065557556


   For those less familiar with the UI code, there are some not-readily-apparent things about my proposed changes I'd like to explain. First thing to know is that the UI uses the SlickGrid library to render the tables, which has two behaviors of note:
   - when a component designed to filter selectable results from a table is rendered, the first row is marked as "active"
   - when a row is marked as "active", SlickGrid will mark that row's cells as "selected"
   
   The next thing to know is that most of the elements in the UI are rendered with absolute positioning, which causes some headaches when making display changes to lists of elements. For example, when trying to get the top border to display for the first row in the table, modifying the _row's_ margin-top offset instead of the padding of the _cells_ causes SlickGrid's "getCellFromPoint()"'s offset math to not be able to find the cells it is attempting to apply the "selected" class to.
   The borders are applied to the cells for these reasons, which means the padding-top needs to account for the borders to keep the contents of the cells from visually moving.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org