[GitHub] [maven-surefire] slawekjaranowski commented on a change in pull request #400: [SUREFIRE-1964] Support for method filtering on excludesFile and includesFile

[GitBox <gi...@apache.org>]

slawekjaranowski commented on a change in pull request #400:
URL: https://github.com/apache/maven-surefire/pull/400#discussion_r782221367



##########
File path: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
##########
@@ -2292,23 +2291,52 @@ private void checkMethodFilterInIncludesExcludes( Iterable<String> patterns )
                 if ( pattern != null && pattern.contains( "#" ) )
                 {
                     throw new MojoFailureException( "Method filter prohibited in "
-                                                        + "includes|excludes|includesFile|excludesFile parameter: "
+                                                        + "includes|excludes parameter: "
                                                         + pattern );
                 }
             }
         }
     }
 
-    private TestListResolver getIncludedAndExcludedTests()
+    private TestListResolver solveIncludedAndExcludedTests()

Review comment:
       Method returns two values .... 
   
   One by standard `return` statement and second by call `setTest(...)` which changes `Mojo` state and can cause impact to other place ... 
   
   I didn't analyze flow where `solveIncludedAndExcludedTests` and `getTest` are used and what order are.
   
   Try to describe what does this method do ... 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org