You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/14 22:58:01 UTC
[GitHub] [airflow] kaxil opened a new pull request #13683: Update docs to register Operator Extra Links
kaxil opened a new pull request #13683:
URL: https://github.com/apache/airflow/pull/13683
closes https://github.com/apache/airflow/issues/13659
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13683: Update docs to register Operator Extra Links
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13683:
URL: https://github.com/apache/airflow/pull/13683#issuecomment-760536634
[The Workflow run](https://github.com/apache/airflow/actions/runs/486598723) is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13683: Update docs to register Operator Extra Links
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13683:
URL: https://github.com/apache/airflow/pull/13683#issuecomment-760793261
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #13683: Update docs to register Operator Extra Links
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #13683:
URL: https://github.com/apache/airflow/pull/13683#discussion_r558160460
##########
File path: docs/apache-airflow/howto/define_extra_link.rst
##########
@@ -54,6 +55,13 @@ The following code shows how to add extra links to an operator:
def execute(self, context):
self.log.info("Hello World!")
+ # Defining the plugin class
+ class AirflowExtraLinkPlugin(AirflowPlugin):
+ name = "extra_link_plugin"
+ operator_extra_links = [GoogleLink(), ]
+
+.. note:: Operator Extra Links should be registered via Airflow Plugins to work.
Review comment:
```suggestion
.. note:: Operator Extra Links should be registered via Airflow Plugins or custom Airflow Provider to work.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #13683: Update docs to register Operator Extra Links
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #13683:
URL: https://github.com/apache/airflow/pull/13683
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org