[GitHub] [tvm] mbs-octoml commented on a change in pull request #9282: [CORE][Relay] Swap and remove compile_engine with te_compiler followup of #8775

[GitBox <gi...@apache.org>]

mbs-octoml commented on a change in pull request #9282:
URL: https://github.com/apache/tvm/pull/9282#discussion_r731073648



##########
File path: python/tvm/autotvm/graph_tuner/utils/traverse_graph.py
##########
@@ -142,7 +142,7 @@ def _traverse_expr(node):
                     params.append(free_var)
                 call = relay.Call(node.op, params, node.attrs)
                 mod = tvm.IRModule.from_expr(relay.Function(params, call))
-                relay.backend.compile_engine.get().clear()
+                relay.backend.te_compiler.get().clear()

Review comment:
       I didn't realize there were so many uses of the dreaded global. Could you please file a JIRA issue to remove them? I suspect simply creating locally would be fine and this has been done just for 'efficiency'. If not we have bigger problems.  




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org