You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Travis Hegner <tr...@gmail.com> on 2016/02/02 19:50:55 UTC
Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is
deprectaed in Docker
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43093/
-----------------------------------------------------------
Review request for mesos and Benjamin Hindman.
Repository: mesos
Description
-------
Fixes [MESOS-4370]
Diffs
-----
src/docker/docker.cpp a831726
Diff: https://reviews.apache.org/r/43093/diff/
Testing
-------
This patch will first query the docker API for the HostConfig.NetworkMode, which is populated with the network name. (Essentially what was passed in --net <name> to the docker run command). This name is then used as a key in NetworkSettings.Networks.<name>.IPAddress to get the IP address that is currently in use by the container.
It appears that even though the docker API has been set up to allow for multiple networks, our testing has indicated that it's still only applying one network to the container (the last one via the --net argument on the run line). I can only speculate that the docker API will change again in the near future, but I can't speculate how, so at least this fixes the problem as it stands right now.
Tested and working with Docker 1.9.1, Mesos 0.27.0, on Ubuntu 14.04
Thanks,
Travis Hegner
Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field
is deprectaed in Docker
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43093/#review117461
-----------------------------------------------------------
Bad patch!
Reviews applied: [43093]
Failed command: ./support/apply-review.sh -n -r 43093
Error:
2016-02-02 20:06:11 URL:https://reviews.apache.org/r/43093/diff/raw/ [1765/1765] -> "43093.patch" [1]
Total errors found: 0
Checking 1 files
Error: Commit message summary (the first line) must end in a period.
Full log: https://builds.apache.org/job/mesos-reviewbot/11200/console
- Mesos ReviewBot
On Feb. 2, 2016, 6:52 p.m., Travis Hegner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43093/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2016, 6:52 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixes [MESOS-4370]
>
>
> Diffs
> -----
>
> src/docker/docker.cpp a831726
>
> Diff: https://reviews.apache.org/r/43093/diff/
>
>
> Testing
> -------
>
> This patch will first query the docker API for the HostConfig.NetworkMode, which is populated with the network name. (Essentially what was passed in --net <name> to the docker run command). This name is then used as a key in NetworkSettings.Networks.<name>.IPAddress to get the IP address that is currently in use by the container.
>
> It appears that even though the docker API has been set up to allow for multiple networks, our testing has indicated that it's still only applying one network to the container (the last one via the --net argument on the run line). I can only speculate that the docker API will change again in the near future, but I can't speculate how, so at least this fixes the problem as it stands right now.
>
> Tested and working with Docker 1.9.1, Mesos 0.27.0, on Ubuntu 14.04.
>
>
> Thanks,
>
> Travis Hegner
>
>
Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field
is deprectaed in Docker
Posted by Travis Hegner <tr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43093/
-----------------------------------------------------------
(Updated Feb. 2, 2016, 6:52 p.m.)
Review request for mesos and Benjamin Hindman.
Repository: mesos
Description
-------
Fixes [MESOS-4370]
Diffs
-----
src/docker/docker.cpp a831726
Diff: https://reviews.apache.org/r/43093/diff/
Testing (updated)
-------
This patch will first query the docker API for the HostConfig.NetworkMode, which is populated with the network name. (Essentially what was passed in --net <name> to the docker run command). This name is then used as a key in NetworkSettings.Networks.<name>.IPAddress to get the IP address that is currently in use by the container.
It appears that even though the docker API has been set up to allow for multiple networks, our testing has indicated that it's still only applying one network to the container (the last one via the --net argument on the run line). I can only speculate that the docker API will change again in the near future, but I can't speculate how, so at least this fixes the problem as it stands right now.
Tested and working with Docker 1.9.1, Mesos 0.27.0, on Ubuntu 14.04.
Thanks,
Travis Hegner