You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by Steve Loughran <st...@hortonworks.com> on 2017/09/06 14:20:52 UTC

why the doxia-snapshot dependency

Every morning my laptop downloads the doxia 1.8 snapshot for its build

[INFO] 
[INFO] --- maven-site-plugin:3.6:attach-descriptor (attach-descriptor) @ hadoop-main ---
Downloading: https://repository.apache.org/snapshots/org/apache/maven/doxia/doxia-module-markdown/1.8-SNAPSHOT/maven-metadata.xml
Downloaded: https://repository.apache.org/snapshots/org/apache/maven/doxia/doxia-module-markdown/1.8-SNAPSHOT/maven-metadata.xml (790 B at 0.7 KB/sec)
Downloading: https://repository.apache.org/snapshots/org/apache/maven/doxia/doxia-modules/1.8-SNAPSHOT/maven-metadata.xml
Downloaded: https://repository.apache.org/snapshots/org/apache/maven/doxia/doxia-modules/1.8-SNAPSHOT/maven-metadata.xml (820 B at 1.3 KB/sec)
Downloading: https://repository.apache.org/snapshots/org/apache/maven/doxia/doxia/1.8-SNAPSHOT/maven-metadata.xml
Downloaded: https://repository.apache.org/snapshots/org/apache/maven/doxia/doxia/1.8-SNAPSHOT/maven-metadata.xml (812 B at 1.3 KB/sec)
Downloading: https://repository.apache.org/snapshots/org/apache/maven/doxia/doxia-module-xhtml/1.8-SNAPSHOT/maven-metadata.xml
Downloaded: https://repository.apache.org/snapshots/org/apache/maven/doxia/doxia-module-xhtml/1.8-SNAPSHOT/maven-metadata.xml (787 B at 1.3 KB/sec)
Downloading: https://repository.apache.org/snapshots/org/apache/maven/doxia/doxia-core/1.8-SNAPSHOT/maven-metadata.xml
Downloaded: https://repository.apache.org/snapshots/org/apache/maven/doxia/doxia-core/1.8-SNAPSHOT/maven-metadata.xml (990 B at 1.6 KB/sec)
Downloading: https://repository.apache.org/snapshots/org/apache/maven/doxia/doxia-sink-api/1.8-SNAPSHOT/maven-metadata.xml
Downloaded: https://repository.apache.org/snapshots/org/apache/maven/doxia/doxia-sink-api/1.8-SNAPSHOT/maven-metadata.xml (783 B at 1.2 KB/sec)
Downloading: https://repository.apache.org/snapshots/org/apache/maven/doxia/doxia-logging-api/1.8-SNAPSHOT/maven-metadata.xml
Downloaded: https://repository.apache.org/snapshots/org/apache/maven/doxia/doxia-logging-api/1.8-SNAPSHOT/maven-metadata.xml (786 B at 1.3 KB/sec)

This implies that the build isn't reproducible, which isn't that bad for a short-lived dev branch, but not what we want for any releases


---------------------------------------------------------------------
To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-dev-help@hadoop.apache.org


Re: why the doxia-snapshot dependency

Posted by Kihwal Lee <ki...@oath.com.INVALID>.
Allen mentioned the reason in HADOOP-14364.  I guess 1.7 does not work. 1.8
is not released yet.

Kihwal

On Wed, Sep 6, 2017 at 9:20 AM, Steve Loughran <st...@hortonworks.com>
wrote:

>
> Every morning my laptop downloads the doxia 1.8 snapshot for its build
>
> [INFO]
> [INFO] --- maven-site-plugin:3.6:attach-descriptor (attach-descriptor) @
> hadoop-main ---
> Downloading: https://repository.apache.org/snapshots/org/apache/maven/
> doxia/doxia-module-markdown/1.8-SNAPSHOT/maven-metadata.xml
> Downloaded: https://repository.apache.org/snapshots/org/apache/maven/
> doxia/doxia-module-markdown/1.8-SNAPSHOT/maven-metadata.xml (790 B at 0.7
> KB/sec)
> Downloading: https://repository.apache.org/snapshots/org/apache/maven/
> doxia/doxia-modules/1.8-SNAPSHOT/maven-metadata.xml
> Downloaded: https://repository.apache.org/snapshots/org/apache/maven/
> doxia/doxia-modules/1.8-SNAPSHOT/maven-metadata.xml (820 B at 1.3 KB/sec)
> Downloading: https://repository.apache.org/snapshots/org/apache/maven/
> doxia/doxia/1.8-SNAPSHOT/maven-metadata.xml
> Downloaded: https://repository.apache.org/snapshots/org/apache/maven/
> doxia/doxia/1.8-SNAPSHOT/maven-metadata.xml (812 B at 1.3 KB/sec)
> Downloading: https://repository.apache.org/snapshots/org/apache/maven/
> doxia/doxia-module-xhtml/1.8-SNAPSHOT/maven-metadata.xml
> Downloaded: https://repository.apache.org/snapshots/org/apache/maven/
> doxia/doxia-module-xhtml/1.8-SNAPSHOT/maven-metadata.xml (787 B at 1.3
> KB/sec)
> Downloading: https://repository.apache.org/snapshots/org/apache/maven/
> doxia/doxia-core/1.8-SNAPSHOT/maven-metadata.xml
> Downloaded: https://repository.apache.org/snapshots/org/apache/maven/
> doxia/doxia-core/1.8-SNAPSHOT/maven-metadata.xml (990 B at 1.6 KB/sec)
> Downloading: https://repository.apache.org/snapshots/org/apache/maven/
> doxia/doxia-sink-api/1.8-SNAPSHOT/maven-metadata.xml
> Downloaded: https://repository.apache.org/snapshots/org/apache/maven/
> doxia/doxia-sink-api/1.8-SNAPSHOT/maven-metadata.xml (783 B at 1.2 KB/sec)
> Downloading: https://repository.apache.org/snapshots/org/apache/maven/
> doxia/doxia-logging-api/1.8-SNAPSHOT/maven-metadata.xml
> Downloaded: https://repository.apache.org/snapshots/org/apache/maven/
> doxia/doxia-logging-api/1.8-SNAPSHOT/maven-metadata.xml (786 B at 1.3
> KB/sec)
>
> This implies that the build isn't reproducible, which isn't that bad for a
> short-lived dev branch, but not what we want for any releases
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
> For additional commands, e-mail: common-dev-help@hadoop.apache.org
>
>

Re: why the doxia-snapshot dependency

Posted by Allen Wittenauer <aw...@effectivemachines.com>.
> On Sep 6, 2017, at 9:53 AM, Steve Loughran <st...@hortonworks.com> wrote:
> 
> Well, it turns out not to like depth-4 MD tags, of the form #### : DOXIA-533 , though that looks like a long-standing issue, not a regression

	Yup. 

> workaround: don't use level4 titles. And do check locally before bothering to upload the patch

	That’s actually one of the side-benefits.  Most contributors never check their javadoc or site generation, leaving that up to Yetus. It’s obviously less than ideal but whatcha gonna do? Anyway, if site goes into an infinite loop, it basically eats up resources on the QA boxes until maven GCs.  (Jenkins has trouble killing docker containers.  We probably need to write some trap code in Yetus.)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-dev-help@hadoop.apache.org


Re: why the doxia-snapshot dependency

Posted by Steve Loughran <st...@hortonworks.com>.
> On 6 Sep 2017, at 16:47, Allen Wittenauer <aw...@effectivemachines.com> wrote:
> 
> 
>> On Sep 6, 2017, at 7:20 AM, Steve Loughran <st...@hortonworks.com> wrote:
>> 
>> 
>> Every morning my laptop downloads the doxia 1.8 snapshot for its build
>> 
>> 
> 
> ….
> 
>> This implies that the build isn't reproducible, which isn't that bad for a short-lived dev branch, but not what we want for any releases
> 
> 
> 	This version of doxia includes an upgraded version of the markdown processor.  Combined with the upgraded maven-site-plugin, fixes two very important bugs:
> 
> 	* MUCH better handling of URLs.  Older versions would exit with failure if it hit hdfs:// as a URL, despite being perfectly legal. [I’ve been "hand-fixing” release notes and the like to avoid hitting this one.]
> 	* Parser doesn’t have the infinite loop bug when it hit certain combinations of broken markdown, usually tables.
> 
> 	I agree that it’s… less than ideal. 
> 
> 	When I wrote the original version of that patch months ago, I was hoping it was a stop-gap.  Worst case, we publish our own version of the plugin.  But given that users will be empowered to fetch their own notes at build time, I felt it was important that this be more bullet proof…
> 

Well, it turns out not to like depth-4 MD tags, of the form #### : DOXIA-533 , though that looks like a long-standing issue, not a regression

workaround: don't use level4 titles. And do check locally before bothering to upload the patch


[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 6.090 s
[INFO] Finished at: 2017-09-06T16:21:42+01:00
[INFO] Final Memory: 43M/604M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-site-plugin:3.6:site (default-cli) on project hadoop-aws: Execution default-cli of goal org.apache.maven.plugins:maven-site-plugin:3.6:site failed. EmptyStackException -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-site-plugin:3.6:site (default-cli) on project hadoop-aws: Execution default-cli of goal org.apache.maven.plugins:maven-site-plugin:3.6:site failed.
	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:212)
	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
	at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
	at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
	at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
	at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
	at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
	at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
	at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
	at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863)
	at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
	at org.apache.maven.cli.MavenCli.main(MavenCli.java:199)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
	at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
	at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
	at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
Caused by: org.apache.maven.plugin.PluginExecutionException: Execution default-cli of goal org.apache.maven.plugins:maven-site-plugin:3.6:site failed.
	at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:145)
	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:207)
	... 20 more
Caused by: java.util.EmptyStackException
	at java.util.Stack.peek(Stack.java:102)
	at org.apache.maven.doxia.index.IndexingSink.peek(IndexingSink.java:292)
	at org.apache.maven.doxia.index.IndexingSink.text(IndexingSink.java:239)
	at org.apache.maven.doxia.sink.impl.SinkAdapter.text(SinkAdapter.java:874)
	at org.apache.maven.doxia.parser.XhtmlBaseParser.handleText(XhtmlBaseParser.java:783)
	at org.apache.maven.doxia.parser.AbstractXmlParser.parseXml(AbstractXmlParser.java:254)
	at org.apache.maven.doxia.parser.AbstractXmlParser.parse(AbstractXmlParser.java:145)
	at org.apache.maven.doxia.parser.XhtmlBaseParser.parse(XhtmlBaseParser.java:96)
	at org.apache.maven.doxia.module.xhtml.XhtmlParser.parse(XhtmlParser.java:356)
	at org.apache.maven.doxia.macro.toc.TocMacro.execute(TocMacro.java:117)
	at org.apache.maven.doxia.parser.AbstractParser.executeMacro(AbstractParser.java:136)
	at org.apache.maven.doxia.module.xhtml.XhtmlParser.processMacro(XhtmlParser.java:268)
	at org.apache.maven.doxia.module.xhtml.XhtmlParser.handleComment(XhtmlParser.java:233)
	at org.apache.maven.doxia.parser.AbstractXmlParser.parseXml(AbstractXmlParser.java:263)
	at org.apache.maven.doxia.parser.AbstractXmlParser.parse(AbstractXmlParser.java:145)
	at org.apache.maven.doxia.parser.XhtmlBaseParser.parse(XhtmlBaseParser.java:96)
	at org.apache.maven.doxia.module.xhtml.XhtmlParser.parse(XhtmlParser.java:356)
	at org.apache.maven.doxia.module.markdown.MarkdownParser.parse(MarkdownParser.java:109)
	at org.apache.maven.doxia.DefaultDoxia.parse(DefaultDoxia.java:65)
	at org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.renderDocument(DefaultSiteRenderer.java:449)
	at org.apache.maven.doxia.siterenderer.DoxiaDocumentRenderer.renderDocument(DoxiaDocumentRenderer.java:53)
	at org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.render(DefaultSiteRenderer.java:337)
	at org.apache.maven.plugins.site.render.SiteMojo.renderDoxiaDocuments(SiteMojo.java:262)
	at org.apache.maven.plugins.site.render.SiteMojo.renderLocale(SiteMojo.java:168)
	at org.apache.maven.plugins.site.render.SiteMojo.execute(SiteMojo.java:132)
	at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
	... 21 more
[ERROR] 


Re: why the doxia-snapshot dependency

Posted by Allen Wittenauer <aw...@effectivemachines.com>.
> On Sep 6, 2017, at 7:20 AM, Steve Loughran <st...@hortonworks.com> wrote:
> 
> 
> Every morning my laptop downloads the doxia 1.8 snapshot for its build
> 
> 

….

> This implies that the build isn't reproducible, which isn't that bad for a short-lived dev branch, but not what we want for any releases


	This version of doxia includes an upgraded version of the markdown processor.  Combined with the upgraded maven-site-plugin, fixes two very important bugs:

	* MUCH better handling of URLs.  Older versions would exit with failure if it hit hdfs:// as a URL, despite being perfectly legal. [I’ve been "hand-fixing” release notes and the like to avoid hitting this one.]
	* Parser doesn’t have the infinite loop bug when it hit certain combinations of broken markdown, usually tables.

	I agree that it’s… less than ideal. 

	When I wrote the original version of that patch months ago, I was hoping it was a stop-gap.  Worst case, we publish our own version of the plugin.  But given that users will be empowered to fetch their own notes at build time, I felt it was important that this be more bullet proof…
---------------------------------------------------------------------
To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-dev-help@hadoop.apache.org