[jira] [Work logged] (BEAM-4393) Missing copyright notices for shaded packages

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BEAM-4393?focusedWorklogId=105415&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-105415 ]

ASF GitHub Bot logged work on BEAM-4393:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 24/May/18 00:29
            Start Date: 24/May/18 00:29
    Worklog Time Spent: 10m 
      Work Description: boyuanzz opened a new pull request #5461: [BEAM-4393] :Appending lacked LICENSE of shaded dependencies
URL: https://github.com/apache/beam/pull/5461
 
 
   Appending lacked LICENSE of shaded dependencies:
   
   Lacked LICENSE and source:
   protobuf: https://github.com/google/protobuf/blob/master/LICENSE
   jsr-305: https://github.com/amaembo/jsr-305/blob/master/ri/LICENSE
   janino: https://github.com/janino-compiler/janino/blob/master/LICENSE
   
   r: @lukecwik 
   cc: @apilloud 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 105415)
            Time Spent: 10m
    Remaining Estimate: 0h

> Missing copyright notices for shaded packages
> ---------------------------------------------
>
>                 Key: BEAM-4393
>                 URL: https://issues.apache.org/jira/browse/BEAM-4393
>             Project: Beam
>          Issue Type: Improvement
>          Components: build-system, sdk-java-core
>            Reporter: Scott Wegner
>            Assignee: Boyuan Zhang
>            Priority: Major
>             Fix For: 2.5.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> From [discussion on dev@|https://lists.apache.org/thread.html/6ef6630e908147ee83e1f1efd4befbda43efb2a59271c5cb49473103@%3Cdev.beam.apache.org%3E], it was recently discovered that we are missing copyright notices for packages that we are shading.
> The recommended fix from [~davor] (see linked conversation), is:
> {quote}
>  I'd suggest appending this sentence to the end of the LICENSE file: "A part of several convenience binary distributions of this software is licensed as follows", followed by the full license text (including its copyright, clauses and disclaimer) – for each such case separately. Don't edit the NOTICE file.
> {quote}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)