[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1497: MINIFICPP-1869 Metrics-related refactoring

["martinzink (via GitHub)" <gi...@apache.org>]

martinzink commented on code in PR #1497:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1497#discussion_r1106933800


##########
libminifi/include/core/state/nodes/MetricsBase.h:
##########
@@ -37,28 +37,28 @@ namespace org::apache::nifi::minifi::state::response {
 class ResponseNode : public core::Connectable, public PublishedMetricProvider {
  public:
   ResponseNode()
-      : core::Connectable("metric"),
-        is_array_(false) {
+    : core::Connectable("metric"),

Review Comment:
   Why did you change these? Shouldnt it be 4 space indent from the level of the constructor (which starts at 2)?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org