[GitHub] [nifi] markobean opened a new pull request, #6694: NIFI-10852 allows commons-compress to use groupid large groupid values

[GitBox <gi...@apache.org>]

markobean opened a new pull request, #6694:
URL: https://github.com/apache/nifi/pull/6694

   <!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
   <!-- contributor license agreements.  See the NOTICE file distributed with -->
   <!-- this work for additional information regarding copyright ownership. -->
   <!-- The ASF licenses this file to You under the Apache License, Version 2.0 -->
   <!-- (the "License"); you may not use this file except in compliance with -->
   <!-- the License.  You may obtain a copy of the License at -->
   <!--     http://www.apache.org/licenses/LICENSE-2.0 -->
   <!-- Unless required by applicable law or agreed to in writing, software -->
   <!-- distributed under the License is distributed on an "AS IS" BASIS, -->
   <!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -->
   <!-- See the License for the specific language governing permissions and -->
   <!-- limitations under the License. -->
   
   # Summary
   Some users are not able to perform a full build of Apache NiFi source code. Specifically, the C2 modules fails to pass unit test when the user's groupid value is large (>2097151). This PR addresses the issue by enabling "bigNumberMode" in org.apache.commons:commons-compress library where otherwise errors would occur.
   
   [NIFI-10852](https://issues.apache.org/jira/browse/NIFI-10852)
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
   
   ### Pull Request Tracking
   
   - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
   - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
   
   ### Pull Request Formatting
   
   - [X] Pull Request based on current revision of the `main` branch
   - [X] Pull Request refers to a feature branch with one commit containing changes
   
   # Verification
   To verify, a build which consistently failed (due to groupid value being too large) was able to complete successfully. To test, the user's groupid value must be > 2097151.
   
   ### Build
   
   - [X] Build completed using `mvn clean install -P contrib-check`
     - [ ] JDK 8
     - [X] JDK 11
     - [ ] JDK 17
   
   ### Licensing
   
   - [X] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] exceptionfactory closed pull request #6694: NIFI-10852 allows commons-compress to use groupid large groupid values

[GitBox <gi...@apache.org>]

exceptionfactory closed pull request #6694: NIFI-10852 allows commons-compress to use groupid large groupid values
URL: https://github.com/apache/nifi/pull/6694


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6694: NIFI-10852 allows commons-compress to use groupid large groupid values

[GitBox <gi...@apache.org>]

exceptionfactory commented on code in PR #6694:
URL: https://github.com/apache/nifi/pull/6694#discussion_r1028450214


##########
c2/c2-client-bundle/c2-client-service/src/main/java/org/apache/nifi/c2/client/service/operation/TransferDebugOperationHandler.java:
##########
@@ -178,6 +178,7 @@ private Optional<byte[]> createDebugBundle(List<Path> filePaths) {
         try (GzipCompressorOutputStream gzipCompressorOutputStream = new GzipCompressorOutputStream(byteOutputStream);
              TarArchiveOutputStream tarOutputStream = new TarArchiveOutputStream(gzipCompressorOutputStream)) {
             for (Path filePath : filePaths) {
+                tarOutputStream.setBigNumberMode(1);

Review Comment:
   Can you change this to `TarArchiveOutputStream.BIGNUMBER_POSIX`? The value of `1` is equivalent to `BIGNUMBER_STAR`, which does not appear to be as widely supported according to the [commons-compress documentation](https://commons.apache.org/proper/commons-compress/tar.html).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org