You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/10/19 10:15:47 UTC
[GitHub] [cloudstack] weizhouapache opened a new pull request #4413: systemvm: fix proc.find in CsProcess.py
weizhouapache opened a new pull request #4413:
URL: https://github.com/apache/cloudstack/pull/4413
## Description
<!--- Describe your changes in detail -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
This fixes the issues described in #4384 and #4386
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland merged pull request #4413: systemvm: fix proc.find in CsProcess.py
Posted by GitBox <gi...@apache.org>.
DaanHoogland merged pull request #4413:
URL: https://github.com/apache/cloudstack/pull/4413
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4413: systemvm: fix proc.find in CsProcess.py
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4413:
URL: https://github.com/apache/cloudstack/pull/4413#issuecomment-712190054
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4413: systemvm: fix proc.find in CsProcess.py
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #4413:
URL: https://github.com/apache/cloudstack/pull/4413#discussion_r507753867
##########
File path: systemvm/debian/opt/cloud/bin/cs/CsProcess.py
##########
@@ -40,9 +40,9 @@ def kill_all(self):
def find_pid(self):
self.pid = []
+ items = len(self.search)
for i in CsHelper.execute("ps aux"):
- items = len(self.search)
- proc = re.split(r"\s+", i)[items*-1:]
+ proc = re.split(r"\s+", i)[10:]
Review comment:
given this is null based the return is now the full cli as returned by `ps aux` ; :+1:
##########
File path: systemvm/debian/opt/cloud/bin/cs/CsProcess.py
##########
@@ -40,9 +40,9 @@ def kill_all(self):
def find_pid(self):
self.pid = []
+ items = len(self.search)
Review comment:
maybe we should think about renaming search; it actually means to be the process/command name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4413: systemvm: fix proc.find in CsProcess.py
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4413:
URL: https://github.com/apache/cloudstack/pull/4413#issuecomment-713831151
@DaanHoogland good .
let's see if there are still issues with test_vpc_redundant.py in trillian test of coming PRs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4413: systemvm: fix proc.find in CsProcess.py
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4413:
URL: https://github.com/apache/cloudstack/pull/4413#issuecomment-715882018
@DaanHoogland this has been merged into 4.14. it needs to be merged into master as well
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4413: systemvm: fix proc.find in CsProcess.py
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4413:
URL: https://github.com/apache/cloudstack/pull/4413#issuecomment-713495972
@davidjumani @borisstoyanov @andrijapanicsb @GabrielBrascher can we get more oks on this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4413: systemvm: fix proc.find in CsProcess.py
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4413:
URL: https://github.com/apache/cloudstack/pull/4413#issuecomment-712183836
Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2207
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4413: systemvm: fix proc.find in CsProcess.py
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4413:
URL: https://github.com/apache/cloudstack/pull/4413#issuecomment-713355727
ping @rhtyd , not sure who else was involved in the predecessors of this one, but i think we can merge this one now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4413: systemvm: fix proc.find in CsProcess.py
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4413:
URL: https://github.com/apache/cloudstack/pull/4413#issuecomment-712164933
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4413: systemvm: fix proc.find in CsProcess.py
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4413:
URL: https://github.com/apache/cloudstack/pull/4413#issuecomment-712189455
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache closed pull request #4413: systemvm: fix proc.find in CsProcess.py
Posted by GitBox <gi...@apache.org>.
weizhouapache closed pull request #4413:
URL: https://github.com/apache/cloudstack/pull/4413
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4413: systemvm: fix proc.find in CsProcess.py
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4413:
URL: https://github.com/apache/cloudstack/pull/4413#issuecomment-712164588
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4413: systemvm: fix proc.find in CsProcess.py
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4413:
URL: https://github.com/apache/cloudstack/pull/4413#issuecomment-712494938
<b>Trillian test result (tid-3007)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 29348 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4413-t3007-kvm-centos7.zip
Smoke tests completed. 83 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org