You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by Vladimir Sitnikov <si...@gmail.com> on 2023/12/22 10:30:23 UTC
Deprecate and remove ClearGui#clearGui method?
Hi,
Does anybody know what is the use of
org.apache.jmeter.gui.ClearGui#clearGui?
It looks like clearGui method does not add much value, so I am leaning
towards to removing it eventually.
We currently have "configure(TestElement element)" (update UI from the
values in TestElement) and "modifyTestElement(TestElement element)" (update
TestElement based on the values from UI),
so I see no reason why we should have "clearGui".
Vladimir
Re: Deprecate and remove ClearGui#clearGui method?
Posted by Vladimir Sitnikov <si...@gmail.com>.
For reference, I think `clearGui` is not needed for UI elements that
represent TestElement properties.
At the same time, clearGui might be needed to reset UI state which is not
connected to TestElement properties.
For instance, if there's a "tabbed pane", we might want resetting the UI to
its initial tab.
However, I think we should remove boilerplate code like
someField.setText("") from our clearGui implementations, see more details
in https://github.com/apache/jmeter/pull/6199
Vladimir