You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wink.apache.org by Bryant Luk <br...@gmail.com> on 2010/06/01 19:32:09 UTC
Re: Returned value from ClientResponseImpl.getStatusType ...
I changed the code to return a Response.Status enum whenever possible
based on the response status code. I think this will satisfy this
suggestion. Note that there is a potential possible bug here if for
some reason the message isn't the standard Not Found with 404, OK with
200, etc. and they call
ClientResponseImpl.getStatusType().getReasonPhrase().
BTW, the reason why I changed it to return the enum whenever possible
is that I don't think equals() is guaranteed to work across a
Response.Status enum and any other StatusType object now or in the
future.
On Sun, May 30, 2010 at 1:28 AM, Jason Dillon <ja...@planet57.com> wrote:
> So that one can do this:
>
> <snip>
> assertEquals(Response.Status.OK, status);
> </snip>
>
> instead of this:
>
> <snip>
> assertEquals(Response.Status.OK.getStatusCode(), status.getStatusCode());
> </snip>
>
> --jason
>
>
> On May 29, 2010, at 11:26 PM, Jason Dillon wrote:
>
>> ... should provide a toString(), and equals() and hashCode(), so that checking the equality of a Status to a StatusType works as one might expect it would (or as I expect it should).
>>
>> --jason
>
>
Re: Returned value from ClientResponseImpl.getStatusType ...
Posted by Jason Dillon <ja...@planet57.com>.
Sounds good. Thanks.
--jason
On Jun 1, 2010, at 10:32 AM, Bryant Luk wrote:
> I changed the code to return a Response.Status enum whenever possible
> based on the response status code. I think this will satisfy this
> suggestion. Note that there is a potential possible bug here if for
> some reason the message isn't the standard Not Found with 404, OK with
> 200, etc. and they call
> ClientResponseImpl.getStatusType().getReasonPhrase().
>
> BTW, the reason why I changed it to return the enum whenever possible
> is that I don't think equals() is guaranteed to work across a
> Response.Status enum and any other StatusType object now or in the
> future.
>
> On Sun, May 30, 2010 at 1:28 AM, Jason Dillon <ja...@planet57.com> wrote:
>> So that one can do this:
>>
>> <snip>
>> assertEquals(Response.Status.OK, status);
>> </snip>
>>
>> instead of this:
>>
>> <snip>
>> assertEquals(Response.Status.OK.getStatusCode(), status.getStatusCode());
>> </snip>
>>
>> --jason
>>
>>
>> On May 29, 2010, at 11:26 PM, Jason Dillon wrote:
>>
>>> ... should provide a toString(), and equals() and hashCode(), so that checking the equality of a Status to a StatusType works as one might expect it would (or as I expect it should).
>>>
>>> --jason
>>
>>