You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by dj...@apache.org on 2016/12/21 08:28:57 UTC
[text] Clarify whether varargs are being used in test (squashes
warning).
Repository: commons-text
Updated Branches:
refs/heads/master 120409051 -> 322fe2723
Clarify whether varargs are being used in test (squashes warning).
Project: http://git-wip-us.apache.org/repos/asf/commons-text/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-text/commit/322fe272
Tree: http://git-wip-us.apache.org/repos/asf/commons-text/tree/322fe272
Diff: http://git-wip-us.apache.org/repos/asf/commons-text/diff/322fe272
Branch: refs/heads/master
Commit: 322fe272311bedffe4c2f5275c816cc196a74890
Parents: 1204090
Author: duncan <du...@wortharead.com>
Authored: Wed Dec 21 08:28:47 2016 +0000
Committer: duncan <du...@wortharead.com>
Committed: Wed Dec 21 08:28:47 2016 +0000
----------------------------------------------------------------------
.../org/apache/commons/text/translate/AggregateTranslatorTest.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/commons-text/blob/322fe272/src/test/java/org/apache/commons/text/translate/AggregateTranslatorTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/text/translate/AggregateTranslatorTest.java b/src/test/java/org/apache/commons/text/translate/AggregateTranslatorTest.java
index f58f2da..6ac6622 100644
--- a/src/test/java/org/apache/commons/text/translate/AggregateTranslatorTest.java
+++ b/src/test/java/org/apache/commons/text/translate/AggregateTranslatorTest.java
@@ -32,7 +32,7 @@ public class AggregateTranslatorTest {
@Test
public void testNullConstructor() throws NoSuchFieldException, IllegalAccessException {
- final AggregateTranslator subject = new AggregateTranslator(null);
+ final AggregateTranslator subject = new AggregateTranslator((CharSequenceTranslator[]) null);
final Field field = AggregateTranslator.class.getDeclaredField("translators");
field.setAccessible(Boolean.TRUE);
assertNull(field.get(subject));
Re: [text] Clarify whether varargs are being used in test (squashes
warning).
Posted by Duncan Jones <du...@wortharead.com>.
> On 21 Dec 2016, at 08:28, djones@apache.org wrote:
>
> Repository: commons-text
> Updated Branches:
> refs/heads/master 120409051 -> 322fe2723
>
>
> Clarify whether varargs are being used in test (squashes warning).
Note: I’m really not a big fan of using reflection to inspect fields in a unit test. I’ll try to find a way to refactor this to test externally observable behaviour.
>
> Project: http://git-wip-us.apache.org/repos/asf/commons-text/repo
> Commit: http://git-wip-us.apache.org/repos/asf/commons-text/commit/322fe272
> Tree: http://git-wip-us.apache.org/repos/asf/commons-text/tree/322fe272
> Diff: http://git-wip-us.apache.org/repos/asf/commons-text/diff/322fe272
>
> Branch: refs/heads/master
> Commit: 322fe272311bedffe4c2f5275c816cc196a74890
> Parents: 1204090
> Author: duncan <du...@wortharead.com>
> Authored: Wed Dec 21 08:28:47 2016 +0000
> Committer: duncan <du...@wortharead.com>
> Committed: Wed Dec 21 08:28:47 2016 +0000
>
> ----------------------------------------------------------------------
> .../org/apache/commons/text/translate/AggregateTranslatorTest.java | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/commons-text/blob/322fe272/src/test/java/org/apache/commons/text/translate/AggregateTranslatorTest.java
> ----------------------------------------------------------------------
> diff --git a/src/test/java/org/apache/commons/text/translate/AggregateTranslatorTest.java b/src/test/java/org/apache/commons/text/translate/AggregateTranslatorTest.java
> index f58f2da..6ac6622 100644
> --- a/src/test/java/org/apache/commons/text/translate/AggregateTranslatorTest.java
> +++ b/src/test/java/org/apache/commons/text/translate/AggregateTranslatorTest.java
> @@ -32,7 +32,7 @@ public class AggregateTranslatorTest {
>
> @Test
> public void testNullConstructor() throws NoSuchFieldException, IllegalAccessException {
> - final AggregateTranslator subject = new AggregateTranslator(null);
> + final AggregateTranslator subject = new AggregateTranslator((CharSequenceTranslator[]) null);
> final Field field = AggregateTranslator.class.getDeclaredField("translators");
> field.setAccessible(Boolean.TRUE);
> assertNull(field.get(subject));
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org