[GitHub] [datasketches-java] davecromberge edited a comment on pull request #348: Made parallel APIs for SetOperations in Theta, and Tuple (generics).

[GitBox <gi...@apache.org>]

davecromberge edited a comment on pull request #348:
URL: https://github.com/apache/datasketches-java/pull/348#issuecomment-775404905


   > We already have a clear statement of "not-thread-safe" in our documentation ... do we need to say more?
   
   I agree with you - you raise a good point that "stateless" does not imply concurrent.  This is just something that I thought of in passing, and admittedly it's a contrived scenario, based on one or two that may have come up on the mailing list.  Personally, I don't see any reason to reuse a set operation builder, and in our use case we construct a virgin instance for every union or intersection operation - despite serving many concurrent requests.
   
   The documentation you have linked to is clear and explicit about the concerns raised in my comment.  Thanks for. your response and additional detail.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org