You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2013/10/22 14:24:07 UTC

svn commit: r1534612 - /tomcat/trunk/java/org/apache/tomcat/util/net/SocketWrapper.java

Author: markt
Date: Tue Oct 22 12:24:06 2013
New Revision: 1534612

URL: http://svn.apache.org/r1534612
Log:
Improve debug logging of SocketWrapper that just uses toString()

Modified:
    tomcat/trunk/java/org/apache/tomcat/util/net/SocketWrapper.java

Modified: tomcat/trunk/java/org/apache/tomcat/util/net/SocketWrapper.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/SocketWrapper.java?rev=1534612&r1=1534611&r2=1534612&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/tomcat/util/net/SocketWrapper.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/SocketWrapper.java Tue Oct 22 12:24:06 2013
@@ -162,4 +162,16 @@ public class SocketWrapper<E> {
         this.timeout = timeout;
         upgraded = false;
     }
+
+    /**
+     * Overridden for debug purposes. No guarantees are made about the format of
+     * this message which may vary significantly between poitn releases.
+     * <p>
+     * {@inheritDoc}
+     */
+    @Override
+    public String toString() {
+        return super.toString() + ":" +
+                (socket == null ? "null" : socket.toString());
+    }
 }



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: svn commit: r1534612 - /tomcat/trunk/java/org/apache/tomcat/util/net/SocketWrapper.java

Posted by Konstantin Kolinko <kn...@gmail.com>.
2013/10/22  <ma...@apache.org>:
> Author: markt
> Date: Tue Oct 22 12:24:06 2013
> New Revision: 1534612
>
> URL: http://svn.apache.org/r1534612
> Log:
> Improve debug logging of SocketWrapper that just uses toString()
>
> Modified:
>     tomcat/trunk/java/org/apache/tomcat/util/net/SocketWrapper.java
>
> Modified: tomcat/trunk/java/org/apache/tomcat/util/net/SocketWrapper.java
> URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/SocketWrapper.java?rev=1534612&r1=1534611&r2=1534612&view=diff
> ==============================================================================
> --- tomcat/trunk/java/org/apache/tomcat/util/net/SocketWrapper.java (original)
> +++ tomcat/trunk/java/org/apache/tomcat/util/net/SocketWrapper.java Tue Oct 22 12:24:06 2013
> @@ -162,4 +162,16 @@ public class SocketWrapper<E> {
>          this.timeout = timeout;
>          upgraded = false;
>      }
> +
> +    /**
> +     * Overridden for debug purposes. No guarantees are made about the format of
> +     * this message which may vary significantly between poitn releases.

s/poitn/point/

> +     * <p>
> +     * {@inheritDoc}
> +     */
> +    @Override
> +    public String toString() {
> +        return super.toString() + ":" +
> +                (socket == null ? "null" : socket.toString());

String.valueOf(socket) will print the same with less code.

> +    }
>  }
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org