You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "rusackas (via GitHub)" <gi...@apache.org> on 2026/02/06 21:51:24 UTC
[PR] chore: consolidate ErrorBoundary to @superset-ui/core [superset]
rusackas opened a new pull request, #37766:
URL: https://github.com/apache/superset/pull/37766
## Summary
This PR consolidates the ErrorBoundary implementation by moving it to `@superset-ui/core` and removing the `react-error-boundary` npm dependency.
Changes:
- Creates a new `ErrorBoundary` component in `@superset-ui/core` based on the react-error-boundary API
- Removes the `react-error-boundary` npm dependency
- Updates all usages across the codebase to import from `@superset-ui/core`
- Deletes the old `src/components/ErrorBoundary` directory
The new ErrorBoundary supports:
- `FallbackComponent` prop for custom error UI
- `fallbackRender` prop for render function fallback
- `onError` callback for error reporting
- `resetErrorBoundary` function for error recovery
When no fallback is provided, errors are caught silently (returns null), which matches the previous `showMessage={false}` behavior.
## Test plan
- [x] Pre-commit hooks pass
- [x] SuperChart tests pass
- [ ] CI passes
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: consolidate ErrorBoundary to @superset-ui/core [superset]
Posted by "EnxDev (via GitHub)" <gi...@apache.org>.
EnxDev commented on PR #37766:
URL: https://github.com/apache/superset/pull/37766#issuecomment-3887095834
Hey @rusackas, ping me if you want to fight this with me!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: consolidate ErrorBoundary to @superset-ui/core [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed pull request #37766: chore: consolidate ErrorBoundary to @superset-ui/core
URL: https://github.com/apache/superset/pull/37766
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: consolidate ErrorBoundary to @superset-ui/core [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #37766:
URL: https://github.com/apache/superset/pull/37766#issuecomment-3863928729
> I'm not sure we should vendor ErrorBoundary component from react-error-boundary since the library is still actively developed and having our own implementation means we gotta maintain it instead of the lib's author.
Thanks for the honest take @hainenber - I agree. I'll move this to draft for now, and see if there's a better approach, if we want to tackle this at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: consolidate ErrorBoundary to @superset-ui/core [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #37766:
URL: https://github.com/apache/superset/pull/37766#issuecomment-3886036861
Killing this for now... I'll come back another day.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: consolidate ErrorBoundary to @superset-ui/core [superset]
Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber commented on PR #37766:
URL: https://github.com/apache/superset/pull/37766#issuecomment-3863375354
I'm not sure we should vendor ErrorBoundary component from `react-error-boundary` since the library is still actively developed and having our own implementation means we gotta maintain it instead of the lib's author.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: consolidate ErrorBoundary to @superset-ui/core [superset]
Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #37766:
URL: https://github.com/apache/superset/pull/37766#issuecomment-3866892158
### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | 6390411c48b3b6f06a06a0142b9bc7943bf259dc |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/69886118b4f5c80008058c74 |
|<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-37766--superset-docs-preview.netlify.app](https://deploy-preview-37766--superset-docs-preview.netlify.app) |
|<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br /><br /><br />_Use your smartphone camera to open QR code link._</details> |
---
<!-- [superset-docs-preview Preview](https://deploy-preview-37766--superset-docs-preview.netlify.app) -->
_To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: consolidate ErrorBoundary to @superset-ui/core [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #37766:
URL: https://github.com/apache/superset/pull/37766#issuecomment-3862711620
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org