[GitHub] [nifi] Freedom9339 commented on a diff in pull request #7461: NIFI-11303 Added a go-to entry on the right click context menu for th…

["Freedom9339 (via GitHub)" <gi...@apache.org>]

Freedom9339 commented on code in PR #7461:
URL: https://github.com/apache/nifi/pull/7461#discussion_r1291303707


##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/provenance/nf-provenance-table.js:
##########
@@ -1213,6 +1195,9 @@
                     }
                 };
 
+                // used to access provenance data when outside of scope
+                var provenanceData;
+

Review Comment:
   @mtien-apache Thank you for the review! This variable is used here:
   
   https://github.com/apache/nifi/blob/7012bfe58da3a5c131896e09fef6888ed300e736/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/provenance/nf-provenance-table.js#L707
   
   And it is being set so we can call getItemByID() in the goTo() function:
   
   https://github.com/apache/nifi/blob/7012bfe58da3a5c131896e09fef6888ed300e736/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/provenance/nf-provenance-table.js#L1238-L1243



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org