You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@beam.apache.org by Daniel Collins <dp...@google.com> on 2021/09/16 17:13:20 UTC
Cherrypick requested for 2.33.0 release
Hello all,
I'd like to request that PR #15418 and #15515 be merged into the 2.33.0
release branch. These two PRs are isolated to a single area of the repo and
should not affect any other modules or validation. The first contains
multiple fixes backported from the Pub/Sub Lite repo, and the second is a
one line test only fix. The first PR missed the release cut by a few days,
and I would greatly appreciate merging this so I do not have to wait
another 1-2 months to remove the external clone and unify our documentation
on which I/O artifact should be used.
-Daniel
Re: Cherrypick requested for 2.33.0 release
Posted by Daniel Collins <dp...@google.com>.
Thanks Udi. https://github.com/apache/beam/pull/15608 is the cherrypick of
the main CL, I can't figure out how to cherrypick two at once, but the
second is just a test flake fix. I'll cherrypick the second once
https://github.com/apache/beam/pull/15608 is merged.
On Tue, Sep 28, 2021 at 12:51 PM Udi Meiri <eh...@google.com> wrote:
> Sure Daniel, send me a PR please
>
> On Mon, Sep 27, 2021 at 6:41 PM Daniel Collins <dp...@google.com>
> wrote:
>
>> Hello,
>>
>> Given that we are doing an RC2, would you consider cherrypicking these?
>>
>> -Daniel
>>
>> On Fri, Sep 17, 2021 at 7:30 PM Ahmet Altay <al...@google.com> wrote:
>>
>>> Given how close we are to the RC I would suggest not including this in
>>> RC1. I am happy to revise my position if there will be an RC2.
>>>
>>> On Thu, Sep 16, 2021 at 12:10 PM Udi Meiri <eh...@google.com> wrote:
>>>
>>>> My current decision as release manager is to not accept a
>>>> cherrypick for these PRs as they are not fixing a regression. [1]
>>>>
>>>> [1]
>>>> https://beam.apache.org/contribute/release-guide/#review-cherry-picks
>>>>
>>>>
>>>> On Thu, Sep 16, 2021 at 10:13 AM Daniel Collins <dp...@google.com>
>>>> wrote:
>>>>
>>>>> Hello all,
>>>>>
>>>>> I'd like to request that PR #15418 and #15515 be merged into the
>>>>> 2.33.0 release branch. These two PRs are isolated to a single area of the
>>>>> repo and should not affect any other modules or validation. The first
>>>>> contains multiple fixes backported from the Pub/Sub Lite repo, and the
>>>>> second is a one line test only fix. The first PR missed the release cut by
>>>>> a few days, and I would greatly appreciate merging this so I do not have to
>>>>> wait another 1-2 months to remove the external clone and unify our
>>>>> documentation on which I/O artifact should be used.
>>>>>
>>>>> -Daniel
>>>>>
>>>>
Re: Cherrypick requested for 2.33.0 release
Posted by Udi Meiri <eh...@google.com>.
Sure Daniel, send me a PR please
On Mon, Sep 27, 2021 at 6:41 PM Daniel Collins <dp...@google.com> wrote:
> Hello,
>
> Given that we are doing an RC2, would you consider cherrypicking these?
>
> -Daniel
>
> On Fri, Sep 17, 2021 at 7:30 PM Ahmet Altay <al...@google.com> wrote:
>
>> Given how close we are to the RC I would suggest not including this in
>> RC1. I am happy to revise my position if there will be an RC2.
>>
>> On Thu, Sep 16, 2021 at 12:10 PM Udi Meiri <eh...@google.com> wrote:
>>
>>> My current decision as release manager is to not accept a cherrypick for
>>> these PRs as they are not fixing a regression. [1]
>>>
>>> [1]
>>> https://beam.apache.org/contribute/release-guide/#review-cherry-picks
>>>
>>>
>>> On Thu, Sep 16, 2021 at 10:13 AM Daniel Collins <dp...@google.com>
>>> wrote:
>>>
>>>> Hello all,
>>>>
>>>> I'd like to request that PR #15418 and #15515 be merged into the 2.33.0
>>>> release branch. These two PRs are isolated to a single area of the repo and
>>>> should not affect any other modules or validation. The first contains
>>>> multiple fixes backported from the Pub/Sub Lite repo, and the second is a
>>>> one line test only fix. The first PR missed the release cut by a few days,
>>>> and I would greatly appreciate merging this so I do not have to wait
>>>> another 1-2 months to remove the external clone and unify our documentation
>>>> on which I/O artifact should be used.
>>>>
>>>> -Daniel
>>>>
>>>
Re: Cherrypick requested for 2.33.0 release
Posted by Daniel Collins <dp...@google.com>.
Hello,
Given that we are doing an RC2, would you consider cherrypicking these?
-Daniel
On Fri, Sep 17, 2021 at 7:30 PM Ahmet Altay <al...@google.com> wrote:
> Given how close we are to the RC I would suggest not including this in
> RC1. I am happy to revise my position if there will be an RC2.
>
> On Thu, Sep 16, 2021 at 12:10 PM Udi Meiri <eh...@google.com> wrote:
>
>> My current decision as release manager is to not accept a cherrypick for
>> these PRs as they are not fixing a regression. [1]
>>
>> [1] https://beam.apache.org/contribute/release-guide/#review-cherry-picks
>>
>>
>> On Thu, Sep 16, 2021 at 10:13 AM Daniel Collins <dp...@google.com>
>> wrote:
>>
>>> Hello all,
>>>
>>> I'd like to request that PR #15418 and #15515 be merged into the 2.33.0
>>> release branch. These two PRs are isolated to a single area of the repo and
>>> should not affect any other modules or validation. The first contains
>>> multiple fixes backported from the Pub/Sub Lite repo, and the second is a
>>> one line test only fix. The first PR missed the release cut by a few days,
>>> and I would greatly appreciate merging this so I do not have to wait
>>> another 1-2 months to remove the external clone and unify our documentation
>>> on which I/O artifact should be used.
>>>
>>> -Daniel
>>>
>>
Re: Cherrypick requested for 2.33.0 release
Posted by Ahmet Altay <al...@google.com>.
Given how close we are to the RC I would suggest not including this in RC1.
I am happy to revise my position if there will be an RC2.
On Thu, Sep 16, 2021 at 12:10 PM Udi Meiri <eh...@google.com> wrote:
> My current decision as release manager is to not accept a cherrypick for
> these PRs as they are not fixing a regression. [1]
>
> [1] https://beam.apache.org/contribute/release-guide/#review-cherry-picks
>
>
> On Thu, Sep 16, 2021 at 10:13 AM Daniel Collins <dp...@google.com>
> wrote:
>
>> Hello all,
>>
>> I'd like to request that PR #15418 and #15515 be merged into the 2.33.0
>> release branch. These two PRs are isolated to a single area of the repo and
>> should not affect any other modules or validation. The first contains
>> multiple fixes backported from the Pub/Sub Lite repo, and the second is a
>> one line test only fix. The first PR missed the release cut by a few days,
>> and I would greatly appreciate merging this so I do not have to wait
>> another 1-2 months to remove the external clone and unify our documentation
>> on which I/O artifact should be used.
>>
>> -Daniel
>>
>
Re: Cherrypick requested for 2.33.0 release
Posted by Udi Meiri <eh...@google.com>.
My current decision as release manager is to not accept a cherrypick for
these PRs as they are not fixing a regression. [1]
[1] https://beam.apache.org/contribute/release-guide/#review-cherry-picks
On Thu, Sep 16, 2021 at 10:13 AM Daniel Collins <dp...@google.com>
wrote:
> Hello all,
>
> I'd like to request that PR #15418 and #15515 be merged into the 2.33.0
> release branch. These two PRs are isolated to a single area of the repo and
> should not affect any other modules or validation. The first contains
> multiple fixes backported from the Pub/Sub Lite repo, and the second is a
> one line test only fix. The first PR missed the release cut by a few days,
> and I would greatly appreciate merging this so I do not have to wait
> another 1-2 months to remove the external clone and unify our documentation
> on which I/O artifact should be used.
>
> -Daniel
>