You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "psalagnac (via GitHub)" <gi...@apache.org> on 2023/03/16 17:59:34 UTC
[GitHub] [solr] psalagnac opened a new pull request, #1465: SOLR-16705: Remove useless Zookeeper checks
psalagnac opened a new pull request, #1465:
URL: https://github.com/apache/solr/pull/1465
https://issues.apache.org/jira/browse/SOLR-16705
<!--
_(If you are a project committer then you may remove some/all of the following template.)_
Before creating a pull request, please file an issue in the ASF Jira system for Solr:
* https://issues.apache.org/jira/projects/SOLR
For something minor (i.e. that wouldn't be worth putting in release notes), you can skip JIRA.
To create a Jira issue, you will need to create an account there first.
The title of the PR should reference the Jira issue number in the form:
* SOLR-####: <short description of problem or changes>
SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
# Description
In class `ShardLeaderElectionContext`, call to method `areAllReplicasParticipating()` is useless and we ignore the returned value.
# Solution
Remove some useless code with ZK calls in shard leader election.
# Tests
No test added for this.
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `main` branch.
- [x] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] psalagnac commented on pull request #1465: SOLR-16705: Remove useless Zookeeper checks
Posted by "psalagnac (via GitHub)" <gi...@apache.org>.
psalagnac commented on PR #1465:
URL: https://github.com/apache/solr/pull/1465#issuecomment-1486416452
Hi @markrmiller,
Thanks for looking into this.
Is this change good to be merged? Is something else required?
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] murblanc commented on pull request #1465: SOLR-16705: Remove useless Zookeeper checks
Posted by "murblanc (via GitHub)" <gi...@apache.org>.
murblanc commented on PR #1465:
URL: https://github.com/apache/solr/pull/1465#issuecomment-1495674869
@markrmiller @noblepaul I plan to merge this 5 days from now (April 9th) if there's no disagreement
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] markrmiller commented on pull request #1465: SOLR-16705: Remove useless Zookeeper checks
Posted by "markrmiller (via GitHub)" <gi...@apache.org>.
markrmiller commented on PR #1465:
URL: https://github.com/apache/solr/pull/1465#issuecomment-1482930966
> areAllReplicasParticipating
This should have been made obsolete with the introduction of the LIR term work. Which is probably why the return value is not used, but obviously the call wasn't removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] murblanc merged pull request #1465: SOLR-16705: Remove useless Zookeeper checks
Posted by "murblanc (via GitHub)" <gi...@apache.org>.
murblanc merged PR #1465:
URL: https://github.com/apache/solr/pull/1465
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org