You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by superpiggy <gi...@git.apache.org> on 2015/04/07 14:09:23 UTC
[GitHub] tajo pull request: TAJO-1537: Implement a virtual table for sessio...
GitHub user superpiggy opened a pull request:
https://github.com/apache/tajo/pull/523
TAJO-1537: Implement a virtual table for sessions
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/superpiggy/tajo TAJO-1537
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/523.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #523
----
commit 1eda15d0736f95bcab7e695e6d9122eb83ffd736
Author: Yongjin Choi <su...@gmail.com>
Date: 2015-04-07T08:13:39Z
TAJO-1537: implement session virtual table
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1537: Implement a virtual table for sessio...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/523#issuecomment-103011763
In addition, this patch allows each user to see all session variables of all other users. It seems to be dangerous. It would be better to allow a user to see its own session's variables. I'll change it as I mentioned.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1537: Implement a virtual table for sessio...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tajo/pull/523
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1537: Implement a virtual table for sessio...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/523#issuecomment-103011097
This work looks good to me. But, it only handles pre-defined session variables. It would be better if this session table can handle all user session variables.
You look busy. If you don't mind, I'll improve the session table to support all user variables.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---