You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "wjones127 (via GitHub)" <gi...@apache.org> on 2023/02/05 23:29:16 UTC

[GitHub] [arrow-adbc] wjones127 commented on a diff in pull request #417: format(api!): clarify const-ness of some pointers

wjones127 commented on code in PR #417:
URL: https://github.com/apache/arrow-adbc/pull/417#discussion_r1096829035


##########
adbc.h:
##########
@@ -729,7 +729,8 @@ AdbcStatusCode AdbcConnectionSetOption(struct AdbcConnection* connection, const
 /// as well.
 ADBC_EXPORT
 AdbcStatusCode AdbcConnectionInit(struct AdbcConnection* connection,
-                                  struct AdbcDatabase* database, struct AdbcError* error);
+                                  const struct AdbcDatabase* database,

Review Comment:
   I am the least confident about this one, admittedly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org