[GitHub] [fineract-cn-mobile] PatelVatsalB21 commented on a change in pull request #186: Add edit check to the edit activities

[GitBox <gi...@apache.org>]

PatelVatsalB21 commented on a change in pull request #186:
URL: https://github.com/apache/fineract-cn-mobile/pull/186#discussion_r618098525



##########
File path: app/src/main/res/values/strings.xml
##########
@@ -412,6 +412,12 @@
     <string name="please_wait">Please wait &#8230;</string>
     <string name="logging_in">Logging in…</string>
 
+    <!--Edit Check Messages-->
+    <string name="customer_edit_check_msg">Information not edited for the customer %1$s</string>
+    <string name="group_edit_check_msg">Information not edited for the group %1$s</string>
+    <string name="payroll_edit_check_msg">Information not edited for the payroll with customer identifier %1$s</string>
+    <string name="identification_edit_check_msg">Information not edited for the identification type %1$s</string>
+

Review comment:
       @EGOR-IND Its good to check if user has changed so that unnecessary operations are not performed. But it would suggest that its ok if you dont notify user that he/she has not changed info as user would know it. Instead if user changed info **save and exit** and if not **do quiet exit**. What do you say are toasts mandatory?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org