You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/10/29 07:45:49 UTC
[GitHub] [hudi] manojpec opened a new pull request #3889: [HUDI-2443] Hudi KVComparator for all HFile writer usages
manojpec opened a new pull request #3889:
URL: https://github.com/apache/hudi/pull/3889
## What is the purpose of the pull request
Hudi relies on custom class shading for Hbase's KeyValue.KVComparator to
avoid versioning and class loading issues. There are few places which are
still using the Hbase's comparator class directly and version upgrades
would make them obsolete. Refactoring the HoodieKVComparator and making
all HFile writer creation using the same shaded class.
## Brief change log
Moved HoodieKVComparator class from HFileBootstrapIndex to a standalone
class and made all HFile creation places use this new shaded class.
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #3889: [HUDI-2443] Hudi KVComparator for all HFile writer usages
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3889:
URL: https://github.com/apache/hudi/pull/3889#issuecomment-976556941
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2958",
"triggerID" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"triggerType" : "PUSH"
}, {
"hash" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2978",
"triggerID" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"triggerType" : "PUSH"
}, {
"hash" : "3d6ba4abbfb00a7df4d47ba95ea388080b8606f2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3016",
"triggerID" : "3d6ba4abbfb00a7df4d47ba95ea388080b8606f2",
"triggerType" : "PUSH"
}, {
"hash" : "76d82d70b311caaf68288927c0bb0f9b3be81ad6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3044",
"triggerID" : "76d82d70b311caaf68288927c0bb0f9b3be81ad6",
"triggerType" : "PUSH"
}, {
"hash" : "1d0a5b1ccb4dc4d09dfcfd78392d8a21a8412438",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3295",
"triggerID" : "1d0a5b1ccb4dc4d09dfcfd78392d8a21a8412438",
"triggerType" : "PUSH"
}, {
"hash" : "7921e8fd700bf1694f07acc49ee6a99d8cea2a96",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3303",
"triggerID" : "7921e8fd700bf1694f07acc49ee6a99d8cea2a96",
"triggerType" : "PUSH"
}, {
"hash" : "4fb8df69496faf0431e8222b365ca77c7a33e3a0",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3640",
"triggerID" : "4fb8df69496faf0431e8222b365ca77c7a33e3a0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4fb8df69496faf0431e8222b365ca77c7a33e3a0 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3640)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar merged pull request #3889: [HUDI-2443] Hudi KVComparator for all HFile writer usages
Posted by GitBox <gi...@apache.org>.
vinothchandar merged pull request #3889:
URL: https://github.com/apache/hudi/pull/3889
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3889: [HUDI-2443] Hudi KVComparator for all HFile writer usages
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3889:
URL: https://github.com/apache/hudi/pull/3889#issuecomment-954508326
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2958",
"triggerID" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"triggerType" : "PUSH"
}, {
"hash" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2978",
"triggerID" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"triggerType" : "PUSH"
}, {
"hash" : "3d6ba4abbfb00a7df4d47ba95ea388080b8606f2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3016",
"triggerID" : "3d6ba4abbfb00a7df4d47ba95ea388080b8606f2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3d6ba4abbfb00a7df4d47ba95ea388080b8606f2 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3016)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3889: [HUDI-2443] Hudi KVComparator for all HFile writer usages
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3889:
URL: https://github.com/apache/hudi/pull/3889#issuecomment-954508326
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2958",
"triggerID" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"triggerType" : "PUSH"
}, {
"hash" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2978",
"triggerID" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"triggerType" : "PUSH"
}, {
"hash" : "3d6ba4abbfb00a7df4d47ba95ea388080b8606f2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3d6ba4abbfb00a7df4d47ba95ea388080b8606f2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 62c235d87ecd3cd04d847a1ca69b32eb24a1af61 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2978)
* 3d6ba4abbfb00a7df4d47ba95ea388080b8606f2 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3889: [HUDI-2443] Hudi KVComparator for all HFile writer usages
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3889:
URL: https://github.com/apache/hudi/pull/3889#issuecomment-954508326
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3889: [HUDI-2443] Hudi KVComparator for all HFile writer usages
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3889:
URL: https://github.com/apache/hudi/pull/3889#issuecomment-954508326
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2958",
"triggerID" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"triggerType" : "PUSH"
}, {
"hash" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2978",
"triggerID" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 62c235d87ecd3cd04d847a1ca69b32eb24a1af61 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2978)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #3889: [HUDI-2443] Hudi KVComparator for all HFile writer usages
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3889:
URL: https://github.com/apache/hudi/pull/3889#issuecomment-954508326
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2958",
"triggerID" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"triggerType" : "PUSH"
}, {
"hash" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2978",
"triggerID" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"triggerType" : "PUSH"
}, {
"hash" : "3d6ba4abbfb00a7df4d47ba95ea388080b8606f2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3016",
"triggerID" : "3d6ba4abbfb00a7df4d47ba95ea388080b8606f2",
"triggerType" : "PUSH"
}, {
"hash" : "76d82d70b311caaf68288927c0bb0f9b3be81ad6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3044",
"triggerID" : "76d82d70b311caaf68288927c0bb0f9b3be81ad6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 76d82d70b311caaf68288927c0bb0f9b3be81ad6 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3044)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar commented on a change in pull request #3889: [HUDI-2443] Hudi KVComparator for all HFile writer usages
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on a change in pull request #3889:
URL: https://github.com/apache/hudi/pull/3889#discussion_r743971409
##########
File path: hudi-common/src/main/java/org/apache/hudi/common/util/HoodieKVComparator.java
##########
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.hudi.common.util;
Review comment:
`util` is not a great name IMO. lets have this in `common.io.storage`
##########
File path: hudi-common/src/main/java/org/apache/hudi/common/table/log/block/HoodieHFileDataBlock.java
##########
@@ -103,7 +104,7 @@ public HoodieLogBlockType getBlockType() {
FSDataOutputStream ostream = new FSDataOutputStream(baos, null);
HFile.Writer writer = HFile.getWriterFactory(conf, cacheConfig)
- .withOutputStream(ostream).withFileContext(context).create();
+ .withOutputStream(ostream).withFileContext(context).withComparator(new HoodieKVComparator()).create();
Review comment:
Lets make sure bootstrap index writing does not use this code path. again problematic
##########
File path: hudi-common/src/main/java/org/apache/hudi/common/bootstrap/index/HFileBootstrapIndex.java
##########
@@ -577,10 +578,4 @@ public String getName() {
}
}
- /**
- * This class is explicitly used as Key Comparator to workaround hard coded
- * legacy format class names inside HBase. Otherwise we will face issues with shading.
- */
- public static class HoodieKVComparator extends KeyValue.KVComparator {
Review comment:
we cannot remove this, since bootstrap index already uses this. lets retain this here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #3889: [HUDI-2443] Hudi KVComparator for all HFile writer usages
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3889:
URL: https://github.com/apache/hudi/pull/3889#issuecomment-965955176
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2958",
"triggerID" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"triggerType" : "PUSH"
}, {
"hash" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2978",
"triggerID" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"triggerType" : "PUSH"
}, {
"hash" : "3d6ba4abbfb00a7df4d47ba95ea388080b8606f2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3016",
"triggerID" : "3d6ba4abbfb00a7df4d47ba95ea388080b8606f2",
"triggerType" : "PUSH"
}, {
"hash" : "76d82d70b311caaf68288927c0bb0f9b3be81ad6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3044",
"triggerID" : "76d82d70b311caaf68288927c0bb0f9b3be81ad6",
"triggerType" : "PUSH"
}, {
"hash" : "1d0a5b1ccb4dc4d09dfcfd78392d8a21a8412438",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3295",
"triggerID" : "1d0a5b1ccb4dc4d09dfcfd78392d8a21a8412438",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1d0a5b1ccb4dc4d09dfcfd78392d8a21a8412438 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3295)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3889: [HUDI-2443] Hudi KVComparator for all HFile writer usages
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3889:
URL: https://github.com/apache/hudi/pull/3889#issuecomment-954508326
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2958",
"triggerID" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"triggerType" : "PUSH"
}, {
"hash" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2978",
"triggerID" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"triggerType" : "PUSH"
}, {
"hash" : "3d6ba4abbfb00a7df4d47ba95ea388080b8606f2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3016",
"triggerID" : "3d6ba4abbfb00a7df4d47ba95ea388080b8606f2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 62c235d87ecd3cd04d847a1ca69b32eb24a1af61 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2978)
* 3d6ba4abbfb00a7df4d47ba95ea388080b8606f2 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3016)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #3889: [HUDI-2443] Hudi KVComparator for all HFile writer usages
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3889:
URL: https://github.com/apache/hudi/pull/3889#issuecomment-977562233
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2958",
"triggerID" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"triggerType" : "PUSH"
}, {
"hash" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2978",
"triggerID" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"triggerType" : "PUSH"
}, {
"hash" : "3d6ba4abbfb00a7df4d47ba95ea388080b8606f2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3016",
"triggerID" : "3d6ba4abbfb00a7df4d47ba95ea388080b8606f2",
"triggerType" : "PUSH"
}, {
"hash" : "76d82d70b311caaf68288927c0bb0f9b3be81ad6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3044",
"triggerID" : "76d82d70b311caaf68288927c0bb0f9b3be81ad6",
"triggerType" : "PUSH"
}, {
"hash" : "1d0a5b1ccb4dc4d09dfcfd78392d8a21a8412438",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3295",
"triggerID" : "1d0a5b1ccb4dc4d09dfcfd78392d8a21a8412438",
"triggerType" : "PUSH"
}, {
"hash" : "7921e8fd700bf1694f07acc49ee6a99d8cea2a96",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3303",
"triggerID" : "7921e8fd700bf1694f07acc49ee6a99d8cea2a96",
"triggerType" : "PUSH"
}, {
"hash" : "4fb8df69496faf0431e8222b365ca77c7a33e3a0",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3640",
"triggerID" : "4fb8df69496faf0431e8222b365ca77c7a33e3a0",
"triggerType" : "PUSH"
}, {
"hash" : "c934b7ef0f4654b9258f82aff03b27910fcf4573",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c934b7ef0f4654b9258f82aff03b27910fcf4573",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4fb8df69496faf0431e8222b365ca77c7a33e3a0 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3640)
* c934b7ef0f4654b9258f82aff03b27910fcf4573 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #3889: [HUDI-2443] Hudi KVComparator for all HFile writer usages
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3889:
URL: https://github.com/apache/hudi/pull/3889#issuecomment-976556941
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2958",
"triggerID" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"triggerType" : "PUSH"
}, {
"hash" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2978",
"triggerID" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"triggerType" : "PUSH"
}, {
"hash" : "3d6ba4abbfb00a7df4d47ba95ea388080b8606f2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3016",
"triggerID" : "3d6ba4abbfb00a7df4d47ba95ea388080b8606f2",
"triggerType" : "PUSH"
}, {
"hash" : "76d82d70b311caaf68288927c0bb0f9b3be81ad6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3044",
"triggerID" : "76d82d70b311caaf68288927c0bb0f9b3be81ad6",
"triggerType" : "PUSH"
}, {
"hash" : "1d0a5b1ccb4dc4d09dfcfd78392d8a21a8412438",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3295",
"triggerID" : "1d0a5b1ccb4dc4d09dfcfd78392d8a21a8412438",
"triggerType" : "PUSH"
}, {
"hash" : "7921e8fd700bf1694f07acc49ee6a99d8cea2a96",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3303",
"triggerID" : "7921e8fd700bf1694f07acc49ee6a99d8cea2a96",
"triggerType" : "PUSH"
}, {
"hash" : "4fb8df69496faf0431e8222b365ca77c7a33e3a0",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3640",
"triggerID" : "4fb8df69496faf0431e8222b365ca77c7a33e3a0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4fb8df69496faf0431e8222b365ca77c7a33e3a0 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3640)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] manojpec commented on a change in pull request #3889: [HUDI-2443] Hudi KVComparator for all HFile writer usages
Posted by GitBox <gi...@apache.org>.
manojpec commented on a change in pull request #3889:
URL: https://github.com/apache/hudi/pull/3889#discussion_r747156624
##########
File path: hudi-common/src/main/java/org/apache/hudi/common/bootstrap/index/HFileBootstrapIndex.java
##########
@@ -577,10 +578,4 @@ public String getName() {
}
}
- /**
- * This class is explicitly used as Key Comparator to workaround hard coded
- * legacy format class names inside HBase. Otherwise we will face issues with shading.
- */
- public static class HoodieKVComparator extends KeyValue.KVComparator {
Review comment:
Brought the old one back to this same place. Can you please help me with the test plan for this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] manojpec commented on a change in pull request #3889: [HUDI-2443] Hudi KVComparator for all HFile writer usages
Posted by GitBox <gi...@apache.org>.
manojpec commented on a change in pull request #3889:
URL: https://github.com/apache/hudi/pull/3889#discussion_r747156739
##########
File path: hudi-common/src/main/java/org/apache/hudi/common/table/log/block/HoodieHFileDataBlock.java
##########
@@ -103,7 +104,7 @@ public HoodieLogBlockType getBlockType() {
FSDataOutputStream ostream = new FSDataOutputStream(baos, null);
HFile.Writer writer = HFile.getWriterFactory(conf, cacheConfig)
- .withOutputStream(ostream).withFileContext(context).create();
+ .withOutputStream(ostream).withFileContext(context).withComparator(new HoodieKVComparator()).create();
Review comment:
Planning to manually test the bootstrapping case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #3889: [HUDI-2443] Hudi KVComparator for all HFile writer usages
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3889:
URL: https://github.com/apache/hudi/pull/3889#issuecomment-966102227
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2958",
"triggerID" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"triggerType" : "PUSH"
}, {
"hash" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2978",
"triggerID" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"triggerType" : "PUSH"
}, {
"hash" : "3d6ba4abbfb00a7df4d47ba95ea388080b8606f2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3016",
"triggerID" : "3d6ba4abbfb00a7df4d47ba95ea388080b8606f2",
"triggerType" : "PUSH"
}, {
"hash" : "76d82d70b311caaf68288927c0bb0f9b3be81ad6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3044",
"triggerID" : "76d82d70b311caaf68288927c0bb0f9b3be81ad6",
"triggerType" : "PUSH"
}, {
"hash" : "1d0a5b1ccb4dc4d09dfcfd78392d8a21a8412438",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3295",
"triggerID" : "1d0a5b1ccb4dc4d09dfcfd78392d8a21a8412438",
"triggerType" : "PUSH"
}, {
"hash" : "7921e8fd700bf1694f07acc49ee6a99d8cea2a96",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3303",
"triggerID" : "7921e8fd700bf1694f07acc49ee6a99d8cea2a96",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1d0a5b1ccb4dc4d09dfcfd78392d8a21a8412438 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3295)
* 7921e8fd700bf1694f07acc49ee6a99d8cea2a96 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3303)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on a change in pull request #3889: [HUDI-2443] Hudi KVComparator for all HFile writer usages
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on a change in pull request #3889:
URL: https://github.com/apache/hudi/pull/3889#discussion_r739601400
##########
File path: hudi-common/src/main/java/org/apache/hudi/common/bootstrap/index/HoodieKVComparator.java
##########
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.hudi.common.bootstrap.index;
Review comment:
since we are using this comparator for metadata table as well, should we move this to org.apache.hudi.util module may be?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3889: [HUDI-2443] Hudi KVComparator for all HFile writer usages
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3889:
URL: https://github.com/apache/hudi/pull/3889#issuecomment-954508326
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2958",
"triggerID" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"triggerType" : "PUSH"
}, {
"hash" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2978",
"triggerID" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 658ed16a52becdf55e17193ace2a380834a3b7f5 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2958)
* 62c235d87ecd3cd04d847a1ca69b32eb24a1af61 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2978)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #3889: [HUDI-2443] Hudi KVComparator for all HFile writer usages
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3889:
URL: https://github.com/apache/hudi/pull/3889#issuecomment-977563513
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2958",
"triggerID" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"triggerType" : "PUSH"
}, {
"hash" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2978",
"triggerID" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"triggerType" : "PUSH"
}, {
"hash" : "3d6ba4abbfb00a7df4d47ba95ea388080b8606f2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3016",
"triggerID" : "3d6ba4abbfb00a7df4d47ba95ea388080b8606f2",
"triggerType" : "PUSH"
}, {
"hash" : "76d82d70b311caaf68288927c0bb0f9b3be81ad6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3044",
"triggerID" : "76d82d70b311caaf68288927c0bb0f9b3be81ad6",
"triggerType" : "PUSH"
}, {
"hash" : "1d0a5b1ccb4dc4d09dfcfd78392d8a21a8412438",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3295",
"triggerID" : "1d0a5b1ccb4dc4d09dfcfd78392d8a21a8412438",
"triggerType" : "PUSH"
}, {
"hash" : "7921e8fd700bf1694f07acc49ee6a99d8cea2a96",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3303",
"triggerID" : "7921e8fd700bf1694f07acc49ee6a99d8cea2a96",
"triggerType" : "PUSH"
}, {
"hash" : "4fb8df69496faf0431e8222b365ca77c7a33e3a0",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3640",
"triggerID" : "4fb8df69496faf0431e8222b365ca77c7a33e3a0",
"triggerType" : "PUSH"
}, {
"hash" : "c934b7ef0f4654b9258f82aff03b27910fcf4573",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3672",
"triggerID" : "c934b7ef0f4654b9258f82aff03b27910fcf4573",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4fb8df69496faf0431e8222b365ca77c7a33e3a0 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3640)
* c934b7ef0f4654b9258f82aff03b27910fcf4573 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3672)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #3889: [HUDI-2443] Hudi KVComparator for all HFile writer usages
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3889:
URL: https://github.com/apache/hudi/pull/3889#issuecomment-976481606
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2958",
"triggerID" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"triggerType" : "PUSH"
}, {
"hash" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2978",
"triggerID" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"triggerType" : "PUSH"
}, {
"hash" : "3d6ba4abbfb00a7df4d47ba95ea388080b8606f2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3016",
"triggerID" : "3d6ba4abbfb00a7df4d47ba95ea388080b8606f2",
"triggerType" : "PUSH"
}, {
"hash" : "76d82d70b311caaf68288927c0bb0f9b3be81ad6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3044",
"triggerID" : "76d82d70b311caaf68288927c0bb0f9b3be81ad6",
"triggerType" : "PUSH"
}, {
"hash" : "1d0a5b1ccb4dc4d09dfcfd78392d8a21a8412438",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3295",
"triggerID" : "1d0a5b1ccb4dc4d09dfcfd78392d8a21a8412438",
"triggerType" : "PUSH"
}, {
"hash" : "7921e8fd700bf1694f07acc49ee6a99d8cea2a96",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3303",
"triggerID" : "7921e8fd700bf1694f07acc49ee6a99d8cea2a96",
"triggerType" : "PUSH"
}, {
"hash" : "4fb8df69496faf0431e8222b365ca77c7a33e3a0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4fb8df69496faf0431e8222b365ca77c7a33e3a0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7921e8fd700bf1694f07acc49ee6a99d8cea2a96 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3303)
* 4fb8df69496faf0431e8222b365ca77c7a33e3a0 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #3889: [HUDI-2443] Hudi KVComparator for all HFile writer usages
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3889:
URL: https://github.com/apache/hudi/pull/3889#issuecomment-976481606
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2958",
"triggerID" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"triggerType" : "PUSH"
}, {
"hash" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2978",
"triggerID" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"triggerType" : "PUSH"
}, {
"hash" : "3d6ba4abbfb00a7df4d47ba95ea388080b8606f2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3016",
"triggerID" : "3d6ba4abbfb00a7df4d47ba95ea388080b8606f2",
"triggerType" : "PUSH"
}, {
"hash" : "76d82d70b311caaf68288927c0bb0f9b3be81ad6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3044",
"triggerID" : "76d82d70b311caaf68288927c0bb0f9b3be81ad6",
"triggerType" : "PUSH"
}, {
"hash" : "1d0a5b1ccb4dc4d09dfcfd78392d8a21a8412438",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3295",
"triggerID" : "1d0a5b1ccb4dc4d09dfcfd78392d8a21a8412438",
"triggerType" : "PUSH"
}, {
"hash" : "7921e8fd700bf1694f07acc49ee6a99d8cea2a96",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3303",
"triggerID" : "7921e8fd700bf1694f07acc49ee6a99d8cea2a96",
"triggerType" : "PUSH"
}, {
"hash" : "4fb8df69496faf0431e8222b365ca77c7a33e3a0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4fb8df69496faf0431e8222b365ca77c7a33e3a0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7921e8fd700bf1694f07acc49ee6a99d8cea2a96 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3303)
* 4fb8df69496faf0431e8222b365ca77c7a33e3a0 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #3889: [HUDI-2443] Hudi KVComparator for all HFile writer usages
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on pull request #3889:
URL: https://github.com/apache/hudi/pull/3889#issuecomment-956856529
@hudi-bot azure run
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #3889: [HUDI-2443] Hudi KVComparator for all HFile writer usages
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3889:
URL: https://github.com/apache/hudi/pull/3889#issuecomment-965935553
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2958",
"triggerID" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"triggerType" : "PUSH"
}, {
"hash" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2978",
"triggerID" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"triggerType" : "PUSH"
}, {
"hash" : "3d6ba4abbfb00a7df4d47ba95ea388080b8606f2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3016",
"triggerID" : "3d6ba4abbfb00a7df4d47ba95ea388080b8606f2",
"triggerType" : "PUSH"
}, {
"hash" : "76d82d70b311caaf68288927c0bb0f9b3be81ad6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3044",
"triggerID" : "76d82d70b311caaf68288927c0bb0f9b3be81ad6",
"triggerType" : "PUSH"
}, {
"hash" : "1d0a5b1ccb4dc4d09dfcfd78392d8a21a8412438",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1d0a5b1ccb4dc4d09dfcfd78392d8a21a8412438",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 76d82d70b311caaf68288927c0bb0f9b3be81ad6 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3044)
* 1d0a5b1ccb4dc4d09dfcfd78392d8a21a8412438 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #3889: [HUDI-2443] Hudi KVComparator for all HFile writer usages
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3889:
URL: https://github.com/apache/hudi/pull/3889#issuecomment-966102227
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2958",
"triggerID" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"triggerType" : "PUSH"
}, {
"hash" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2978",
"triggerID" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"triggerType" : "PUSH"
}, {
"hash" : "3d6ba4abbfb00a7df4d47ba95ea388080b8606f2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3016",
"triggerID" : "3d6ba4abbfb00a7df4d47ba95ea388080b8606f2",
"triggerType" : "PUSH"
}, {
"hash" : "76d82d70b311caaf68288927c0bb0f9b3be81ad6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3044",
"triggerID" : "76d82d70b311caaf68288927c0bb0f9b3be81ad6",
"triggerType" : "PUSH"
}, {
"hash" : "1d0a5b1ccb4dc4d09dfcfd78392d8a21a8412438",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3295",
"triggerID" : "1d0a5b1ccb4dc4d09dfcfd78392d8a21a8412438",
"triggerType" : "PUSH"
}, {
"hash" : "7921e8fd700bf1694f07acc49ee6a99d8cea2a96",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3303",
"triggerID" : "7921e8fd700bf1694f07acc49ee6a99d8cea2a96",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1d0a5b1ccb4dc4d09dfcfd78392d8a21a8412438 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3295)
* 7921e8fd700bf1694f07acc49ee6a99d8cea2a96 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3303)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #3889: [HUDI-2443] Hudi KVComparator for all HFile writer usages
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3889:
URL: https://github.com/apache/hudi/pull/3889#issuecomment-965955176
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2958",
"triggerID" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"triggerType" : "PUSH"
}, {
"hash" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2978",
"triggerID" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"triggerType" : "PUSH"
}, {
"hash" : "3d6ba4abbfb00a7df4d47ba95ea388080b8606f2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3016",
"triggerID" : "3d6ba4abbfb00a7df4d47ba95ea388080b8606f2",
"triggerType" : "PUSH"
}, {
"hash" : "76d82d70b311caaf68288927c0bb0f9b3be81ad6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3044",
"triggerID" : "76d82d70b311caaf68288927c0bb0f9b3be81ad6",
"triggerType" : "PUSH"
}, {
"hash" : "1d0a5b1ccb4dc4d09dfcfd78392d8a21a8412438",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3295",
"triggerID" : "1d0a5b1ccb4dc4d09dfcfd78392d8a21a8412438",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1d0a5b1ccb4dc4d09dfcfd78392d8a21a8412438 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3295)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #3889: [HUDI-2443] Hudi KVComparator for all HFile writer usages
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3889:
URL: https://github.com/apache/hudi/pull/3889#issuecomment-954508326
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 658ed16a52becdf55e17193ace2a380834a3b7f5 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #3889: [HUDI-2443] Hudi KVComparator for all HFile writer usages
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3889:
URL: https://github.com/apache/hudi/pull/3889#issuecomment-977563513
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2958",
"triggerID" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"triggerType" : "PUSH"
}, {
"hash" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2978",
"triggerID" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"triggerType" : "PUSH"
}, {
"hash" : "3d6ba4abbfb00a7df4d47ba95ea388080b8606f2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3016",
"triggerID" : "3d6ba4abbfb00a7df4d47ba95ea388080b8606f2",
"triggerType" : "PUSH"
}, {
"hash" : "76d82d70b311caaf68288927c0bb0f9b3be81ad6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3044",
"triggerID" : "76d82d70b311caaf68288927c0bb0f9b3be81ad6",
"triggerType" : "PUSH"
}, {
"hash" : "1d0a5b1ccb4dc4d09dfcfd78392d8a21a8412438",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3295",
"triggerID" : "1d0a5b1ccb4dc4d09dfcfd78392d8a21a8412438",
"triggerType" : "PUSH"
}, {
"hash" : "7921e8fd700bf1694f07acc49ee6a99d8cea2a96",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3303",
"triggerID" : "7921e8fd700bf1694f07acc49ee6a99d8cea2a96",
"triggerType" : "PUSH"
}, {
"hash" : "4fb8df69496faf0431e8222b365ca77c7a33e3a0",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3640",
"triggerID" : "4fb8df69496faf0431e8222b365ca77c7a33e3a0",
"triggerType" : "PUSH"
}, {
"hash" : "c934b7ef0f4654b9258f82aff03b27910fcf4573",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3672",
"triggerID" : "c934b7ef0f4654b9258f82aff03b27910fcf4573",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4fb8df69496faf0431e8222b365ca77c7a33e3a0 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3640)
* c934b7ef0f4654b9258f82aff03b27910fcf4573 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3672)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #3889: [HUDI-2443] Hudi KVComparator for all HFile writer usages
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3889:
URL: https://github.com/apache/hudi/pull/3889#issuecomment-976484834
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2958",
"triggerID" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"triggerType" : "PUSH"
}, {
"hash" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2978",
"triggerID" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"triggerType" : "PUSH"
}, {
"hash" : "3d6ba4abbfb00a7df4d47ba95ea388080b8606f2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3016",
"triggerID" : "3d6ba4abbfb00a7df4d47ba95ea388080b8606f2",
"triggerType" : "PUSH"
}, {
"hash" : "76d82d70b311caaf68288927c0bb0f9b3be81ad6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3044",
"triggerID" : "76d82d70b311caaf68288927c0bb0f9b3be81ad6",
"triggerType" : "PUSH"
}, {
"hash" : "1d0a5b1ccb4dc4d09dfcfd78392d8a21a8412438",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3295",
"triggerID" : "1d0a5b1ccb4dc4d09dfcfd78392d8a21a8412438",
"triggerType" : "PUSH"
}, {
"hash" : "7921e8fd700bf1694f07acc49ee6a99d8cea2a96",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3303",
"triggerID" : "7921e8fd700bf1694f07acc49ee6a99d8cea2a96",
"triggerType" : "PUSH"
}, {
"hash" : "4fb8df69496faf0431e8222b365ca77c7a33e3a0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3640",
"triggerID" : "4fb8df69496faf0431e8222b365ca77c7a33e3a0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7921e8fd700bf1694f07acc49ee6a99d8cea2a96 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3303)
* 4fb8df69496faf0431e8222b365ca77c7a33e3a0 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3640)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #3889: [HUDI-2443] Hudi KVComparator for all HFile writer usages
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3889:
URL: https://github.com/apache/hudi/pull/3889#issuecomment-976484834
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2958",
"triggerID" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"triggerType" : "PUSH"
}, {
"hash" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2978",
"triggerID" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"triggerType" : "PUSH"
}, {
"hash" : "3d6ba4abbfb00a7df4d47ba95ea388080b8606f2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3016",
"triggerID" : "3d6ba4abbfb00a7df4d47ba95ea388080b8606f2",
"triggerType" : "PUSH"
}, {
"hash" : "76d82d70b311caaf68288927c0bb0f9b3be81ad6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3044",
"triggerID" : "76d82d70b311caaf68288927c0bb0f9b3be81ad6",
"triggerType" : "PUSH"
}, {
"hash" : "1d0a5b1ccb4dc4d09dfcfd78392d8a21a8412438",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3295",
"triggerID" : "1d0a5b1ccb4dc4d09dfcfd78392d8a21a8412438",
"triggerType" : "PUSH"
}, {
"hash" : "7921e8fd700bf1694f07acc49ee6a99d8cea2a96",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3303",
"triggerID" : "7921e8fd700bf1694f07acc49ee6a99d8cea2a96",
"triggerType" : "PUSH"
}, {
"hash" : "4fb8df69496faf0431e8222b365ca77c7a33e3a0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3640",
"triggerID" : "4fb8df69496faf0431e8222b365ca77c7a33e3a0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7921e8fd700bf1694f07acc49ee6a99d8cea2a96 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3303)
* 4fb8df69496faf0431e8222b365ca77c7a33e3a0 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3640)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3889: [HUDI-2443] Hudi KVComparator for all HFile writer usages
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3889:
URL: https://github.com/apache/hudi/pull/3889#issuecomment-954508326
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2958",
"triggerID" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"triggerType" : "PUSH"
}, {
"hash" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2978",
"triggerID" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"triggerType" : "PUSH"
}, {
"hash" : "3d6ba4abbfb00a7df4d47ba95ea388080b8606f2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3016",
"triggerID" : "3d6ba4abbfb00a7df4d47ba95ea388080b8606f2",
"triggerType" : "PUSH"
}, {
"hash" : "76d82d70b311caaf68288927c0bb0f9b3be81ad6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "76d82d70b311caaf68288927c0bb0f9b3be81ad6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3d6ba4abbfb00a7df4d47ba95ea388080b8606f2 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3016)
* 76d82d70b311caaf68288927c0bb0f9b3be81ad6 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] manojpec commented on pull request #3889: [HUDI-2443] Hudi KVComparator for all HFile writer usages
Posted by GitBox <gi...@apache.org>.
manojpec commented on pull request #3889:
URL: https://github.com/apache/hudi/pull/3889#issuecomment-957096349
@hudi-bot azure run
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3889: [HUDI-2443] Hudi KVComparator for all HFile writer usages
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3889:
URL: https://github.com/apache/hudi/pull/3889#issuecomment-954508326
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2958",
"triggerID" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 658ed16a52becdf55e17193ace2a380834a3b7f5 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2958)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #3889: [HUDI-2443] Hudi KVComparator for all HFile writer usages
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on pull request #3889:
URL: https://github.com/apache/hudi/pull/3889#issuecomment-955137258
@umehrot2 : Can you loop in Ryan to review the patch. May I know how to test this out ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codope commented on a change in pull request #3889: [HUDI-2443] Hudi KVComparator for all HFile writer usages
Posted by GitBox <gi...@apache.org>.
codope commented on a change in pull request #3889:
URL: https://github.com/apache/hudi/pull/3889#discussion_r755106037
##########
File path: hudi-common/src/main/java/org/apache/hudi/io/storage/HoodieHBaseComparators.java
##########
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.hudi.io.storage;
+
+import org.apache.hadoop.hbase.KeyValue;
+
+/**
+ * This class is explicitly used as Key Comparator to work around the hard coded
+ * legacy format class names inside HBase. Otherwise, we will face issues with shading.
+ */
+public class HoodieHBaseComparators {
+ public static class HoodieHBaseKVComparator
Review comment:
Thought of keeping it static just like `HoodieKVComparator`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar commented on a change in pull request #3889: [HUDI-2443] Hudi KVComparator for all HFile writer usages
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on a change in pull request #3889:
URL: https://github.com/apache/hudi/pull/3889#discussion_r755096705
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/storage/HoodieFileWriterFactory.java
##########
@@ -81,8 +84,13 @@
TaskContextSupplier taskContextSupplier) throws IOException {
BloomFilter filter = createBloomFilter(config);
- HoodieHFileConfig hfileConfig = new HoodieHFileConfig(hoodieTable.getHadoopConf(),
- config.getHFileCompressionAlgorithm(), config.getHFileBlockSize(), config.getHFileMaxFileSize(), filter);
+ HoodieHFileConfig hfileConfig;
+ if (!StringUtils.isNullOrEmpty(config.getHFileComparatorClassName())) {
Review comment:
can we have add a . `HoodieCommonKVComparator` and set this to be the default. that way you ll always have a comparator here. This is a third comparator, which can be common, in case we need it going forward.
##########
File path: hudi-common/src/main/java/org/apache/hudi/io/storage/HoodieHBaseComparators.java
##########
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.hudi.io.storage;
+
+import org.apache.hadoop.hbase.KeyValue;
+
+/**
+ * This class is explicitly used as Key Comparator to work around the hard coded
+ * legacy format class names inside HBase. Otherwise, we will face issues with shading.
+ */
+public class HoodieHBaseComparators {
+ public static class HoodieHBaseKVComparator
Review comment:
why nest this? just a simple top level class?
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/storage/HoodieHFileConfig.java
##########
@@ -34,19 +40,23 @@
private boolean dropBehindCacheCompaction;
private Configuration hadoopConf;
private BloomFilter bloomFilter;
-
- // This is private in CacheConfig so have been copied here.
- private static boolean DROP_BEHIND_CACHE_COMPACTION_DEFAULT = true;
+ private KeyValue.KVComparator hfileComparator;
public HoodieHFileConfig(Configuration hadoopConf, Compression.Algorithm compressionAlgorithm, int blockSize,
long maxFileSize, BloomFilter bloomFilter) {
this(hadoopConf, compressionAlgorithm, blockSize, maxFileSize, CacheConfig.DEFAULT_PREFETCH_ON_OPEN,
- HColumnDescriptor.DEFAULT_CACHE_DATA_IN_L1, DROP_BEHIND_CACHE_COMPACTION_DEFAULT, bloomFilter);
+ HColumnDescriptor.DEFAULT_CACHE_DATA_IN_L1, DROP_BEHIND_CACHE_COMPACTION_DEFAULT, bloomFilter, defaultHFileComparator);
+ }
+
+ public HoodieHFileConfig(Configuration hadoopConf, Compression.Algorithm compressionAlgorithm, int blockSize,
Review comment:
have 1 constructor that always takes a comparator?
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieStorageConfig.java
##########
@@ -83,6 +83,14 @@
.withDocumentation("Lower values increase the size of metadata tracked within HFile, but can offer potentially "
+ "faster lookup times.");
+ public static final ConfigProperty<String> HFILE_COMPARATOR_CLASS_NAME = ConfigProperty
Review comment:
I am not sure we need to expose a user config here. All HFile usages are more internal.
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/storage/HoodieFileWriterFactory.java
##########
@@ -81,8 +84,13 @@
TaskContextSupplier taskContextSupplier) throws IOException {
BloomFilter filter = createBloomFilter(config);
- HoodieHFileConfig hfileConfig = new HoodieHFileConfig(hoodieTable.getHadoopConf(),
- config.getHFileCompressionAlgorithm(), config.getHFileBlockSize(), config.getHFileMaxFileSize(), filter);
+ HoodieHFileConfig hfileConfig;
+ if (!StringUtils.isNullOrEmpty(config.getHFileComparatorClassName())) {
Review comment:
I guess `HoodieHBaseComparators.HoodieHBaseKVComparator()` is that? can we just pass it in from here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codope commented on a change in pull request #3889: [HUDI-2443] Hudi KVComparator for all HFile writer usages
Posted by GitBox <gi...@apache.org>.
codope commented on a change in pull request #3889:
URL: https://github.com/apache/hudi/pull/3889#discussion_r755116364
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieStorageConfig.java
##########
@@ -83,6 +83,14 @@
.withDocumentation("Lower values increase the size of metadata tracked within HFile, but can offer potentially "
+ "faster lookup times.");
+ public static final ConfigProperty<String> HFILE_COMPARATOR_CLASS_NAME = ConfigProperty
Review comment:
I exposed this config as a way to set legacy comparator class in case something breaks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] manojpec commented on pull request #3889: [HUDI-2443] Hudi KVComparator for all HFile writer usages
Posted by GitBox <gi...@apache.org>.
manojpec commented on pull request #3889:
URL: https://github.com/apache/hudi/pull/3889#issuecomment-957096349
@hudi-bot azure run
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #3889: [HUDI-2443] Hudi KVComparator for all HFile writer usages
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3889:
URL: https://github.com/apache/hudi/pull/3889#issuecomment-965935553
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2958",
"triggerID" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"triggerType" : "PUSH"
}, {
"hash" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2978",
"triggerID" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"triggerType" : "PUSH"
}, {
"hash" : "3d6ba4abbfb00a7df4d47ba95ea388080b8606f2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3016",
"triggerID" : "3d6ba4abbfb00a7df4d47ba95ea388080b8606f2",
"triggerType" : "PUSH"
}, {
"hash" : "76d82d70b311caaf68288927c0bb0f9b3be81ad6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3044",
"triggerID" : "76d82d70b311caaf68288927c0bb0f9b3be81ad6",
"triggerType" : "PUSH"
}, {
"hash" : "1d0a5b1ccb4dc4d09dfcfd78392d8a21a8412438",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1d0a5b1ccb4dc4d09dfcfd78392d8a21a8412438",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 76d82d70b311caaf68288927c0bb0f9b3be81ad6 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3044)
* 1d0a5b1ccb4dc4d09dfcfd78392d8a21a8412438 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] prashantwason commented on a change in pull request #3889: [HUDI-2443] Hudi KVComparator for all HFile writer usages
Posted by GitBox <gi...@apache.org>.
prashantwason commented on a change in pull request #3889:
URL: https://github.com/apache/hudi/pull/3889#discussion_r748694504
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/storage/HoodieHFileWriter.java
##########
@@ -85,14 +86,18 @@ public HoodieHFileWriter(String instantTime, Path file, HoodieHFileConfig hfileC
this.taskContextSupplier = taskContextSupplier;
HFileContext context = new HFileContextBuilder().withBlockSize(hfileConfig.getBlockSize())
- .withCompression(hfileConfig.getCompressionAlgorithm())
- .build();
+ .withCompression(hfileConfig.getCompressionAlgorithm())
+ .build();
conf.set(CacheConfig.PREFETCH_BLOCKS_ON_OPEN_KEY, String.valueOf(hfileConfig.shouldPrefetchBlocksOnOpen()));
conf.set(HColumnDescriptor.CACHE_DATA_IN_L1, String.valueOf(hfileConfig.shouldCacheDataInL1()));
conf.set(DROP_BEHIND_CACHE_COMPACTION_KEY, String.valueOf(hfileConfig.shouldDropBehindCacheCompaction()));
CacheConfig cacheConfig = new CacheConfig(conf);
- this.writer = HFile.getWriterFactory(conf, cacheConfig).withPath(this.fs, this.file).withFileContext(context).create();
+ this.writer = HFile.getWriterFactory(conf, cacheConfig)
+ .withPath(this.fs, this.file)
+ .withFileContext(context)
+ .withComparator(new HoodieMetadataKVComparator())
Review comment:
Why not read this class from the hfileConfig instead of hardcoding it here?
By calling this HoodieMetadataKVComparator, this implies that somehow the HoodieHFileWriter is ONLY for metadata table. As currently implemented, we can have the dataset itself use hfile file format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codope commented on a change in pull request #3889: [HUDI-2443] Hudi KVComparator for all HFile writer usages
Posted by GitBox <gi...@apache.org>.
codope commented on a change in pull request #3889:
URL: https://github.com/apache/hudi/pull/3889#discussion_r755820177
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieStorageConfig.java
##########
@@ -83,6 +83,14 @@
.withDocumentation("Lower values increase the size of metadata tracked within HFile, but can offer potentially "
+ "faster lookup times.");
+ public static final ConfigProperty<String> HFILE_COMPARATOR_CLASS_NAME = ConfigProperty
Review comment:
removed the config.. does not add too much value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #3889: [HUDI-2443] Hudi KVComparator for all HFile writer usages
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3889:
URL: https://github.com/apache/hudi/pull/3889#issuecomment-961588754
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2958",
"triggerID" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"triggerType" : "PUSH"
}, {
"hash" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2978",
"triggerID" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"triggerType" : "PUSH"
}, {
"hash" : "3d6ba4abbfb00a7df4d47ba95ea388080b8606f2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3016",
"triggerID" : "3d6ba4abbfb00a7df4d47ba95ea388080b8606f2",
"triggerType" : "PUSH"
}, {
"hash" : "76d82d70b311caaf68288927c0bb0f9b3be81ad6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3044",
"triggerID" : "76d82d70b311caaf68288927c0bb0f9b3be81ad6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 76d82d70b311caaf68288927c0bb0f9b3be81ad6 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3044)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #3889: [HUDI-2443] Hudi KVComparator for all HFile writer usages
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3889:
URL: https://github.com/apache/hudi/pull/3889#issuecomment-954508326
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2958",
"triggerID" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"triggerType" : "PUSH"
}, {
"hash" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2978",
"triggerID" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"triggerType" : "PUSH"
}, {
"hash" : "3d6ba4abbfb00a7df4d47ba95ea388080b8606f2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3016",
"triggerID" : "3d6ba4abbfb00a7df4d47ba95ea388080b8606f2",
"triggerType" : "PUSH"
}, {
"hash" : "76d82d70b311caaf68288927c0bb0f9b3be81ad6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3044",
"triggerID" : "76d82d70b311caaf68288927c0bb0f9b3be81ad6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 76d82d70b311caaf68288927c0bb0f9b3be81ad6 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3044)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #3889: [HUDI-2443] Hudi KVComparator for all HFile writer usages
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3889:
URL: https://github.com/apache/hudi/pull/3889#issuecomment-954508326
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2958",
"triggerID" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"triggerType" : "PUSH"
}, {
"hash" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2978",
"triggerID" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"triggerType" : "PUSH"
}, {
"hash" : "3d6ba4abbfb00a7df4d47ba95ea388080b8606f2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3016",
"triggerID" : "3d6ba4abbfb00a7df4d47ba95ea388080b8606f2",
"triggerType" : "PUSH"
}, {
"hash" : "76d82d70b311caaf68288927c0bb0f9b3be81ad6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3044",
"triggerID" : "76d82d70b311caaf68288927c0bb0f9b3be81ad6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 76d82d70b311caaf68288927c0bb0f9b3be81ad6 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3044)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #3889: [HUDI-2443] Hudi KVComparator for all HFile writer usages
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3889:
URL: https://github.com/apache/hudi/pull/3889#issuecomment-961588754
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2958",
"triggerID" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"triggerType" : "PUSH"
}, {
"hash" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2978",
"triggerID" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"triggerType" : "PUSH"
}, {
"hash" : "3d6ba4abbfb00a7df4d47ba95ea388080b8606f2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3016",
"triggerID" : "3d6ba4abbfb00a7df4d47ba95ea388080b8606f2",
"triggerType" : "PUSH"
}, {
"hash" : "76d82d70b311caaf68288927c0bb0f9b3be81ad6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3044",
"triggerID" : "76d82d70b311caaf68288927c0bb0f9b3be81ad6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 76d82d70b311caaf68288927c0bb0f9b3be81ad6 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3044)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #3889: [HUDI-2443] Hudi KVComparator for all HFile writer usages
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3889:
URL: https://github.com/apache/hudi/pull/3889#issuecomment-965936521
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2958",
"triggerID" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"triggerType" : "PUSH"
}, {
"hash" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2978",
"triggerID" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"triggerType" : "PUSH"
}, {
"hash" : "3d6ba4abbfb00a7df4d47ba95ea388080b8606f2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3016",
"triggerID" : "3d6ba4abbfb00a7df4d47ba95ea388080b8606f2",
"triggerType" : "PUSH"
}, {
"hash" : "76d82d70b311caaf68288927c0bb0f9b3be81ad6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3044",
"triggerID" : "76d82d70b311caaf68288927c0bb0f9b3be81ad6",
"triggerType" : "PUSH"
}, {
"hash" : "1d0a5b1ccb4dc4d09dfcfd78392d8a21a8412438",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3295",
"triggerID" : "1d0a5b1ccb4dc4d09dfcfd78392d8a21a8412438",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 76d82d70b311caaf68288927c0bb0f9b3be81ad6 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3044)
* 1d0a5b1ccb4dc4d09dfcfd78392d8a21a8412438 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3295)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #3889: [HUDI-2443] Hudi KVComparator for all HFile writer usages
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3889:
URL: https://github.com/apache/hudi/pull/3889#issuecomment-961588754
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2958",
"triggerID" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"triggerType" : "PUSH"
}, {
"hash" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2978",
"triggerID" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"triggerType" : "PUSH"
}, {
"hash" : "3d6ba4abbfb00a7df4d47ba95ea388080b8606f2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3016",
"triggerID" : "3d6ba4abbfb00a7df4d47ba95ea388080b8606f2",
"triggerType" : "PUSH"
}, {
"hash" : "76d82d70b311caaf68288927c0bb0f9b3be81ad6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3044",
"triggerID" : "76d82d70b311caaf68288927c0bb0f9b3be81ad6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 76d82d70b311caaf68288927c0bb0f9b3be81ad6 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3044)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] manojpec commented on a change in pull request #3889: [HUDI-2443] Hudi KVComparator for all HFile writer usages
Posted by GitBox <gi...@apache.org>.
manojpec commented on a change in pull request #3889:
URL: https://github.com/apache/hudi/pull/3889#discussion_r747297948
##########
File path: hudi-common/src/main/java/org/apache/hudi/common/bootstrap/index/HFileBootstrapIndex.java
##########
@@ -577,10 +578,4 @@ public String getName() {
}
}
- /**
- * This class is explicitly used as Key Comparator to workaround hard coded
- * legacy format class names inside HBase. Otherwise we will face issues with shading.
- */
- public static class HoodieKVComparator extends KeyValue.KVComparator {
Review comment:
Discussed and have the test plan. Will test it out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] manojpec commented on pull request #3889: [HUDI-2443] Hudi KVComparator for all HFile writer usages
Posted by GitBox <gi...@apache.org>.
manojpec commented on pull request #3889:
URL: https://github.com/apache/hudi/pull/3889#issuecomment-957096349
@hudi-bot azure run
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #3889: [HUDI-2443] Hudi KVComparator for all HFile writer usages
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3889:
URL: https://github.com/apache/hudi/pull/3889#issuecomment-966149827
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2958",
"triggerID" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"triggerType" : "PUSH"
}, {
"hash" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2978",
"triggerID" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"triggerType" : "PUSH"
}, {
"hash" : "3d6ba4abbfb00a7df4d47ba95ea388080b8606f2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3016",
"triggerID" : "3d6ba4abbfb00a7df4d47ba95ea388080b8606f2",
"triggerType" : "PUSH"
}, {
"hash" : "76d82d70b311caaf68288927c0bb0f9b3be81ad6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3044",
"triggerID" : "76d82d70b311caaf68288927c0bb0f9b3be81ad6",
"triggerType" : "PUSH"
}, {
"hash" : "1d0a5b1ccb4dc4d09dfcfd78392d8a21a8412438",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3295",
"triggerID" : "1d0a5b1ccb4dc4d09dfcfd78392d8a21a8412438",
"triggerType" : "PUSH"
}, {
"hash" : "7921e8fd700bf1694f07acc49ee6a99d8cea2a96",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3303",
"triggerID" : "7921e8fd700bf1694f07acc49ee6a99d8cea2a96",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7921e8fd700bf1694f07acc49ee6a99d8cea2a96 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3303)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #3889: [HUDI-2443] Hudi KVComparator for all HFile writer usages
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3889:
URL: https://github.com/apache/hudi/pull/3889#issuecomment-977562233
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2958",
"triggerID" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"triggerType" : "PUSH"
}, {
"hash" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2978",
"triggerID" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"triggerType" : "PUSH"
}, {
"hash" : "3d6ba4abbfb00a7df4d47ba95ea388080b8606f2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3016",
"triggerID" : "3d6ba4abbfb00a7df4d47ba95ea388080b8606f2",
"triggerType" : "PUSH"
}, {
"hash" : "76d82d70b311caaf68288927c0bb0f9b3be81ad6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3044",
"triggerID" : "76d82d70b311caaf68288927c0bb0f9b3be81ad6",
"triggerType" : "PUSH"
}, {
"hash" : "1d0a5b1ccb4dc4d09dfcfd78392d8a21a8412438",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3295",
"triggerID" : "1d0a5b1ccb4dc4d09dfcfd78392d8a21a8412438",
"triggerType" : "PUSH"
}, {
"hash" : "7921e8fd700bf1694f07acc49ee6a99d8cea2a96",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3303",
"triggerID" : "7921e8fd700bf1694f07acc49ee6a99d8cea2a96",
"triggerType" : "PUSH"
}, {
"hash" : "4fb8df69496faf0431e8222b365ca77c7a33e3a0",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3640",
"triggerID" : "4fb8df69496faf0431e8222b365ca77c7a33e3a0",
"triggerType" : "PUSH"
}, {
"hash" : "c934b7ef0f4654b9258f82aff03b27910fcf4573",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c934b7ef0f4654b9258f82aff03b27910fcf4573",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4fb8df69496faf0431e8222b365ca77c7a33e3a0 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3640)
* c934b7ef0f4654b9258f82aff03b27910fcf4573 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #3889: [HUDI-2443] Hudi KVComparator for all HFile writer usages
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3889:
URL: https://github.com/apache/hudi/pull/3889#issuecomment-977600225
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2958",
"triggerID" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"triggerType" : "PUSH"
}, {
"hash" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2978",
"triggerID" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"triggerType" : "PUSH"
}, {
"hash" : "3d6ba4abbfb00a7df4d47ba95ea388080b8606f2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3016",
"triggerID" : "3d6ba4abbfb00a7df4d47ba95ea388080b8606f2",
"triggerType" : "PUSH"
}, {
"hash" : "76d82d70b311caaf68288927c0bb0f9b3be81ad6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3044",
"triggerID" : "76d82d70b311caaf68288927c0bb0f9b3be81ad6",
"triggerType" : "PUSH"
}, {
"hash" : "1d0a5b1ccb4dc4d09dfcfd78392d8a21a8412438",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3295",
"triggerID" : "1d0a5b1ccb4dc4d09dfcfd78392d8a21a8412438",
"triggerType" : "PUSH"
}, {
"hash" : "7921e8fd700bf1694f07acc49ee6a99d8cea2a96",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3303",
"triggerID" : "7921e8fd700bf1694f07acc49ee6a99d8cea2a96",
"triggerType" : "PUSH"
}, {
"hash" : "4fb8df69496faf0431e8222b365ca77c7a33e3a0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3640",
"triggerID" : "4fb8df69496faf0431e8222b365ca77c7a33e3a0",
"triggerType" : "PUSH"
}, {
"hash" : "c934b7ef0f4654b9258f82aff03b27910fcf4573",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3672",
"triggerID" : "c934b7ef0f4654b9258f82aff03b27910fcf4573",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c934b7ef0f4654b9258f82aff03b27910fcf4573 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3672)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codope commented on a change in pull request #3889: [HUDI-2443] Hudi KVComparator for all HFile writer usages
Posted by GitBox <gi...@apache.org>.
codope commented on a change in pull request #3889:
URL: https://github.com/apache/hudi/pull/3889#discussion_r755819747
##########
File path: hudi-common/src/main/java/org/apache/hudi/io/storage/HoodieHBaseComparators.java
##########
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.hudi.io.storage;
+
+import org.apache.hadoop.hbase.KeyValue;
+
+/**
+ * This class is explicitly used as Key Comparator to work around the hard coded
+ * legacy format class names inside HBase. Otherwise, we will face issues with shading.
+ */
+public class HoodieHBaseComparators {
+ public static class HoodieHBaseKVComparator
Review comment:
made it a top level class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #3889: [HUDI-2443] Hudi KVComparator for all HFile writer usages
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3889:
URL: https://github.com/apache/hudi/pull/3889#issuecomment-965936521
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2958",
"triggerID" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"triggerType" : "PUSH"
}, {
"hash" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2978",
"triggerID" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"triggerType" : "PUSH"
}, {
"hash" : "3d6ba4abbfb00a7df4d47ba95ea388080b8606f2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3016",
"triggerID" : "3d6ba4abbfb00a7df4d47ba95ea388080b8606f2",
"triggerType" : "PUSH"
}, {
"hash" : "76d82d70b311caaf68288927c0bb0f9b3be81ad6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3044",
"triggerID" : "76d82d70b311caaf68288927c0bb0f9b3be81ad6",
"triggerType" : "PUSH"
}, {
"hash" : "1d0a5b1ccb4dc4d09dfcfd78392d8a21a8412438",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3295",
"triggerID" : "1d0a5b1ccb4dc4d09dfcfd78392d8a21a8412438",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 76d82d70b311caaf68288927c0bb0f9b3be81ad6 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3044)
* 1d0a5b1ccb4dc4d09dfcfd78392d8a21a8412438 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3295)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codope commented on a change in pull request #3889: [HUDI-2443] Hudi KVComparator for all HFile writer usages
Posted by GitBox <gi...@apache.org>.
codope commented on a change in pull request #3889:
URL: https://github.com/apache/hudi/pull/3889#discussion_r755819973
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/storage/HoodieHFileConfig.java
##########
@@ -34,19 +40,23 @@
private boolean dropBehindCacheCompaction;
private Configuration hadoopConf;
private BloomFilter bloomFilter;
-
- // This is private in CacheConfig so have been copied here.
- private static boolean DROP_BEHIND_CACHE_COMPACTION_DEFAULT = true;
+ private KeyValue.KVComparator hfileComparator;
public HoodieHFileConfig(Configuration hadoopConf, Compression.Algorithm compressionAlgorithm, int blockSize,
long maxFileSize, BloomFilter bloomFilter) {
this(hadoopConf, compressionAlgorithm, blockSize, maxFileSize, CacheConfig.DEFAULT_PREFETCH_ON_OPEN,
- HColumnDescriptor.DEFAULT_CACHE_DATA_IN_L1, DROP_BEHIND_CACHE_COMPACTION_DEFAULT, bloomFilter);
+ HColumnDescriptor.DEFAULT_CACHE_DATA_IN_L1, DROP_BEHIND_CACHE_COMPACTION_DEFAULT, bloomFilter, defaultHFileComparator);
+ }
+
+ public HoodieHFileConfig(Configuration hadoopConf, Compression.Algorithm compressionAlgorithm, int blockSize,
Review comment:
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codope commented on a change in pull request #3889: [HUDI-2443] Hudi KVComparator for all HFile writer usages
Posted by GitBox <gi...@apache.org>.
codope commented on a change in pull request #3889:
URL: https://github.com/apache/hudi/pull/3889#discussion_r755820492
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/storage/HoodieFileWriterFactory.java
##########
@@ -81,8 +84,13 @@
TaskContextSupplier taskContextSupplier) throws IOException {
BloomFilter filter = createBloomFilter(config);
- HoodieHFileConfig hfileConfig = new HoodieHFileConfig(hoodieTable.getHadoopConf(),
- config.getHFileCompressionAlgorithm(), config.getHFileBlockSize(), config.getHFileMaxFileSize(), filter);
+ HoodieHFileConfig hfileConfig;
+ if (!StringUtils.isNullOrEmpty(config.getHFileComparatorClassName())) {
Review comment:
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codope commented on a change in pull request #3889: [HUDI-2443] Hudi KVComparator for all HFile writer usages
Posted by GitBox <gi...@apache.org>.
codope commented on a change in pull request #3889:
URL: https://github.com/apache/hudi/pull/3889#discussion_r755113737
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/storage/HoodieFileWriterFactory.java
##########
@@ -81,8 +84,13 @@
TaskContextSupplier taskContextSupplier) throws IOException {
BloomFilter filter = createBloomFilter(config);
- HoodieHFileConfig hfileConfig = new HoodieHFileConfig(hoodieTable.getHadoopConf(),
- config.getHFileCompressionAlgorithm(), config.getHFileBlockSize(), config.getHFileMaxFileSize(), filter);
+ HoodieHFileConfig hfileConfig;
+ if (!StringUtils.isNullOrEmpty(config.getHFileComparatorClassName())) {
Review comment:
Yeah that's the one. I made it default in `HoodieHFileConfig`. Will make it default in `HoodieStorageConfig` itself.
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/storage/HoodieHFileConfig.java
##########
@@ -34,19 +40,23 @@
private boolean dropBehindCacheCompaction;
private Configuration hadoopConf;
private BloomFilter bloomFilter;
-
- // This is private in CacheConfig so have been copied here.
- private static boolean DROP_BEHIND_CACHE_COMPACTION_DEFAULT = true;
+ private KeyValue.KVComparator hfileComparator;
public HoodieHFileConfig(Configuration hadoopConf, Compression.Algorithm compressionAlgorithm, int blockSize,
long maxFileSize, BloomFilter bloomFilter) {
this(hadoopConf, compressionAlgorithm, blockSize, maxFileSize, CacheConfig.DEFAULT_PREFETCH_ON_OPEN,
- HColumnDescriptor.DEFAULT_CACHE_DATA_IN_L1, DROP_BEHIND_CACHE_COMPACTION_DEFAULT, bloomFilter);
+ HColumnDescriptor.DEFAULT_CACHE_DATA_IN_L1, DROP_BEHIND_CACHE_COMPACTION_DEFAULT, bloomFilter, defaultHFileComparator);
+ }
+
+ public HoodieHFileConfig(Configuration hadoopConf, Compression.Algorithm compressionAlgorithm, int blockSize,
Review comment:
Yeah we can do that if we set default value in the storage config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3889: [HUDI-2443] Hudi KVComparator for all HFile writer usages
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3889:
URL: https://github.com/apache/hudi/pull/3889#issuecomment-954508326
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2958",
"triggerID" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"triggerType" : "PUSH"
}, {
"hash" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2978",
"triggerID" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"triggerType" : "PUSH"
}, {
"hash" : "3d6ba4abbfb00a7df4d47ba95ea388080b8606f2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3016",
"triggerID" : "3d6ba4abbfb00a7df4d47ba95ea388080b8606f2",
"triggerType" : "PUSH"
}, {
"hash" : "76d82d70b311caaf68288927c0bb0f9b3be81ad6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3044",
"triggerID" : "76d82d70b311caaf68288927c0bb0f9b3be81ad6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 76d82d70b311caaf68288927c0bb0f9b3be81ad6 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3044)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3889: [HUDI-2443] Hudi KVComparator for all HFile writer usages
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3889:
URL: https://github.com/apache/hudi/pull/3889#issuecomment-954508326
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2958",
"triggerID" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"triggerType" : "PUSH"
}, {
"hash" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 658ed16a52becdf55e17193ace2a380834a3b7f5 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2958)
* 62c235d87ecd3cd04d847a1ca69b32eb24a1af61 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] manojpec commented on a change in pull request #3889: [HUDI-2443] Hudi KVComparator for all HFile writer usages
Posted by GitBox <gi...@apache.org>.
manojpec commented on a change in pull request #3889:
URL: https://github.com/apache/hudi/pull/3889#discussion_r740284558
##########
File path: hudi-common/src/main/java/org/apache/hudi/common/bootstrap/index/HoodieKVComparator.java
##########
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.hudi.common.bootstrap.index;
Review comment:
Right, not specific to bootstrap anymore. Moved the comparator to util.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #3889: [HUDI-2443] Hudi KVComparator for all HFile writer usages
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on pull request #3889:
URL: https://github.com/apache/hudi/pull/3889#issuecomment-956856529
@hudi-bot azure run
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar commented on pull request #3889: [HUDI-2443] Hudi KVComparator for all HFile writer usages
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on pull request #3889:
URL: https://github.com/apache/hudi/pull/3889#issuecomment-962177782
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3889: [HUDI-2443] Hudi KVComparator for all HFile writer usages
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3889:
URL: https://github.com/apache/hudi/pull/3889#issuecomment-954508326
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #3889: [HUDI-2443] Hudi KVComparator for all HFile writer usages
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on pull request #3889:
URL: https://github.com/apache/hudi/pull/3889#issuecomment-956856529
@hudi-bot azure run
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3889: [HUDI-2443] Hudi KVComparator for all HFile writer usages
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3889:
URL: https://github.com/apache/hudi/pull/3889#issuecomment-954508326
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2958",
"triggerID" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"triggerType" : "PUSH"
}, {
"hash" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2978",
"triggerID" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"triggerType" : "PUSH"
}, {
"hash" : "3d6ba4abbfb00a7df4d47ba95ea388080b8606f2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3016",
"triggerID" : "3d6ba4abbfb00a7df4d47ba95ea388080b8606f2",
"triggerType" : "PUSH"
}, {
"hash" : "76d82d70b311caaf68288927c0bb0f9b3be81ad6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3044",
"triggerID" : "76d82d70b311caaf68288927c0bb0f9b3be81ad6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3d6ba4abbfb00a7df4d47ba95ea388080b8606f2 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3016)
* 76d82d70b311caaf68288927c0bb0f9b3be81ad6 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3044)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3889: [HUDI-2443] Hudi KVComparator for all HFile writer usages
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3889:
URL: https://github.com/apache/hudi/pull/3889#issuecomment-954508326
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2958",
"triggerID" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 658ed16a52becdf55e17193ace2a380834a3b7f5 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2958)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #3889: [HUDI-2443] Hudi KVComparator for all HFile writer usages
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3889:
URL: https://github.com/apache/hudi/pull/3889#issuecomment-961588754
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2958",
"triggerID" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"triggerType" : "PUSH"
}, {
"hash" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2978",
"triggerID" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"triggerType" : "PUSH"
}, {
"hash" : "3d6ba4abbfb00a7df4d47ba95ea388080b8606f2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3016",
"triggerID" : "3d6ba4abbfb00a7df4d47ba95ea388080b8606f2",
"triggerType" : "PUSH"
}, {
"hash" : "76d82d70b311caaf68288927c0bb0f9b3be81ad6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3044",
"triggerID" : "76d82d70b311caaf68288927c0bb0f9b3be81ad6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 76d82d70b311caaf68288927c0bb0f9b3be81ad6 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3044)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #3889: [HUDI-2443] Hudi KVComparator for all HFile writer usages
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3889:
URL: https://github.com/apache/hudi/pull/3889#issuecomment-966100570
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2958",
"triggerID" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"triggerType" : "PUSH"
}, {
"hash" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2978",
"triggerID" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"triggerType" : "PUSH"
}, {
"hash" : "3d6ba4abbfb00a7df4d47ba95ea388080b8606f2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3016",
"triggerID" : "3d6ba4abbfb00a7df4d47ba95ea388080b8606f2",
"triggerType" : "PUSH"
}, {
"hash" : "76d82d70b311caaf68288927c0bb0f9b3be81ad6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3044",
"triggerID" : "76d82d70b311caaf68288927c0bb0f9b3be81ad6",
"triggerType" : "PUSH"
}, {
"hash" : "1d0a5b1ccb4dc4d09dfcfd78392d8a21a8412438",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3295",
"triggerID" : "1d0a5b1ccb4dc4d09dfcfd78392d8a21a8412438",
"triggerType" : "PUSH"
}, {
"hash" : "7921e8fd700bf1694f07acc49ee6a99d8cea2a96",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7921e8fd700bf1694f07acc49ee6a99d8cea2a96",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1d0a5b1ccb4dc4d09dfcfd78392d8a21a8412438 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3295)
* 7921e8fd700bf1694f07acc49ee6a99d8cea2a96 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] manojpec commented on a change in pull request #3889: [HUDI-2443] Hudi KVComparator for all HFile writer usages
Posted by GitBox <gi...@apache.org>.
manojpec commented on a change in pull request #3889:
URL: https://github.com/apache/hudi/pull/3889#discussion_r747156373
##########
File path: hudi-common/src/main/java/org/apache/hudi/common/util/HoodieKVComparator.java
##########
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.hudi.common.util;
Review comment:
Moved to common.io.storage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #3889: [HUDI-2443] Hudi KVComparator for all HFile writer usages
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3889:
URL: https://github.com/apache/hudi/pull/3889#issuecomment-966100570
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2958",
"triggerID" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"triggerType" : "PUSH"
}, {
"hash" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2978",
"triggerID" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"triggerType" : "PUSH"
}, {
"hash" : "3d6ba4abbfb00a7df4d47ba95ea388080b8606f2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3016",
"triggerID" : "3d6ba4abbfb00a7df4d47ba95ea388080b8606f2",
"triggerType" : "PUSH"
}, {
"hash" : "76d82d70b311caaf68288927c0bb0f9b3be81ad6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3044",
"triggerID" : "76d82d70b311caaf68288927c0bb0f9b3be81ad6",
"triggerType" : "PUSH"
}, {
"hash" : "1d0a5b1ccb4dc4d09dfcfd78392d8a21a8412438",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3295",
"triggerID" : "1d0a5b1ccb4dc4d09dfcfd78392d8a21a8412438",
"triggerType" : "PUSH"
}, {
"hash" : "7921e8fd700bf1694f07acc49ee6a99d8cea2a96",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7921e8fd700bf1694f07acc49ee6a99d8cea2a96",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1d0a5b1ccb4dc4d09dfcfd78392d8a21a8412438 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3295)
* 7921e8fd700bf1694f07acc49ee6a99d8cea2a96 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #3889: [HUDI-2443] Hudi KVComparator for all HFile writer usages
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3889:
URL: https://github.com/apache/hudi/pull/3889#issuecomment-966149827
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2958",
"triggerID" : "658ed16a52becdf55e17193ace2a380834a3b7f5",
"triggerType" : "PUSH"
}, {
"hash" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2978",
"triggerID" : "62c235d87ecd3cd04d847a1ca69b32eb24a1af61",
"triggerType" : "PUSH"
}, {
"hash" : "3d6ba4abbfb00a7df4d47ba95ea388080b8606f2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3016",
"triggerID" : "3d6ba4abbfb00a7df4d47ba95ea388080b8606f2",
"triggerType" : "PUSH"
}, {
"hash" : "76d82d70b311caaf68288927c0bb0f9b3be81ad6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3044",
"triggerID" : "76d82d70b311caaf68288927c0bb0f9b3be81ad6",
"triggerType" : "PUSH"
}, {
"hash" : "1d0a5b1ccb4dc4d09dfcfd78392d8a21a8412438",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3295",
"triggerID" : "1d0a5b1ccb4dc4d09dfcfd78392d8a21a8412438",
"triggerType" : "PUSH"
}, {
"hash" : "7921e8fd700bf1694f07acc49ee6a99d8cea2a96",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3303",
"triggerID" : "7921e8fd700bf1694f07acc49ee6a99d8cea2a96",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7921e8fd700bf1694f07acc49ee6a99d8cea2a96 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3303)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org