You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/07/30 14:33:27 UTC

[GitHub] [kafka] YeonCheolGit commented on a diff in pull request #12444: KAFKA-14101: Improve documentation for consuming from embedded Kafka cluster topics in Connect integration testing framework

YeonCheolGit commented on code in PR #12444:
URL: https://github.com/apache/kafka/pull/12444#discussion_r933815183


##########
connect/runtime/src/test/java/org/apache/kafka/connect/integration/ExampleConnectIntegrationTest.java:
##########
@@ -157,7 +157,7 @@ public void testSinkConnector() throws Exception {
 
         // consume all records from the source topic or fail, to ensure that they were correctly produced.

Review Comment:
   For me `consume all records` comments are different from `consumeAtLeast()` what you are intending for?
   
   Maybe remove `all` ? 
   ```suggestion
           // consume records from the source topic or fail, to ensure that they were correctly produced.
   ```
   



##########
connect/runtime/src/test/java/org/apache/kafka/connect/integration/RebalanceSourceConnectorsIntegrationTest.java:
##########
@@ -161,7 +161,7 @@ public void testReconfigConnector() throws Exception {
         long recordTransferDurationMs = TimeUnit.SECONDS.toMillis(30);
 
         // consume all records from the source topic or fail, to ensure that they were correctly produced

Review Comment:
   Maybe this is the same comment?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org