[GitHub] [incubator-streampark] 1996fanrui commented on pull request #1866: [Feature] Reference variables as placeholders in program args and Flink SQL

[GitBox <gi...@apache.org>]

1996fanrui commented on PR #1866:
URL: https://github.com/apache/incubator-streampark/pull/1866#issuecomment-1286885978

   > hi @macksonmu: thanks for your hard work. have a little suggestion: Currently, placeholder-start char and end char is hard-coded , Can they be made configurable in application.yml? e.g:
   > 
   > ```
   > streampark:
   >   variable:
   >     placeholder-start: ${
   >     placeholder-end: }
   > ```
   
   If the placeholder is changed, all old variables in SQL or args will be invalidated. So I'm not sure whether we need to support change the `placeholder-start` and `placeholder-end`.
   
   I have 2 questions:
   1. Do users really need to modify it?
   2. If users really need it, how to compatible with old variables?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org