You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@maka.apache.org by "Adarsh-Me (via GitHub)" <gi...@apache.org> on 2026/10/14 06:52:31 UTC

Re: [I] fix(desktop): connection base URL gate is looser than the Runtime Host contract, so a rejected endpoint reports a misleading error [maka]

Adarsh-Me commented on issue #3672:
URL: https://github.com/apache/maka/issues/3672#issuecomment-6162684038

   Taking #3672. Measured on `main` b9cac4e3: `validateConnectionBaseUrl` (`packages/core/src/llm-connections.ts:650`) checks only length, parseability and scheme — lines 668-671 never reject userinfo, query or fragment, so `https://user:pw@host/v1?k=1` passes. Plan: reject those three in the validator, mirroring the Runtime Host contract, with unit tests in `packages/core`. @shaokeyibb — #3673 closed unmerged 10-03; if you're still on it, I'll step back.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org