You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/05/31 19:25:17 UTC

[GitHub] [spark] srowen commented on a change in pull request #24762: [SPARK-27907][SQL] HiveUDAF with 0 rows throw NPE when try to serialize

srowen commented on a change in pull request #24762: [SPARK-27907][SQL] HiveUDAF with 0 rows throw NPE when try to serialize
URL: https://github.com/apache/spark/pull/24762#discussion_r289521914
 
 

 ##########
 File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveUDAFSuite.scala
 ##########
 @@ -149,6 +149,14 @@ class HiveUDAFSuite extends QueryTest with TestHiveSingleton with SQLTestUtils {
       }
     }
   }
+
+  test("HiveUDAF with 0 rows throws NPE") {
+    sql("create table abc(a int)")
+    sql("insert into abc values (1)")
+    sql("insert into abc values (2)")
+    sql("select histogram_numeric(a,2) from abc").show
 
 Review comment:
   Are these two lines above needed for the test?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org