You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "liaozan (via GitHub)" <gi...@apache.org> on 2023/03/15 07:48:09 UTC
[GitHub] [dubbo] liaozan opened a new issue, #11833: dubbo-common 模块中的 json 相关依赖是否应该是 optional 的？
liaozan opened a new issue, #11833:
URL: https://github.com/apache/dubbo/issues/11833
```xml
<dependency>
<groupId>com.alibaba</groupId>
<artifactId>fastjson</artifactId>
<scope>provided</scope>
</dependency>
```
```xml
<dependency>
<groupId>com.google.code.gson</groupId>
<artifactId>gson</artifactId>
<scope>provided</scope>
</dependency>
```
这 2 个依赖从语义上来看，应该是 optional 的吧？
现在 scope 是 provider 的，如果应用程序中，两个 json 框架都没引入，虽然最终都会抛异常提醒用户进行 json 框架的引入
但是从语义上来说，可能改成 optional 的会不会更合适呢？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] liaozan commented on issue #11833: dubbo-common 模块中的 json 相关依赖是否应该是 optional 的？
Posted by "liaozan (via GitHub)" <gi...@apache.org>.
liaozan commented on issue #11833:
URL: https://github.com/apache/dubbo/issues/11833#issuecomment-1473160880
review pls @AlbumenJ @mytang0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] mytang0 commented on issue #11833: dubbo-common 模块中的 json 相关依赖是否应该是 optional 的？
Posted by "mytang0 (via GitHub)" <gi...@apache.org>.
mytang0 commented on issue #11833:
URL: https://github.com/apache/dubbo/issues/11833#issuecomment-1471218670
I agree with your suggestion, you can raise a PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ closed issue #11833: dubbo-common 模块中的 json 相关依赖是否应该是 optional 的？
Posted by "AlbumenJ (via GitHub)" <gi...@apache.org>.
AlbumenJ closed issue #11833: dubbo-common 模块中的 json 相关依赖是否应该是 optional 的？
URL: https://github.com/apache/dubbo/issues/11833
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ commented on issue #11833: dubbo-common 模块中的 json 相关依赖是否应该是 optional 的？
Posted by "AlbumenJ (via GitHub)" <gi...@apache.org>.
AlbumenJ commented on issue #11833:
URL: https://github.com/apache/dubbo/issues/11833#issuecomment-1473153677
agree
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org