[GitHub] [spark] Ngone51 commented on a diff in pull request #43112: [SPARK-45310][CORE] Report shuffle block status should respect shuffle service during decommission migration

["Ngone51 (via GitHub)" <gi...@apache.org>]

Ngone51 commented on code in PR #43112:
URL: https://github.com/apache/spark/pull/43112#discussion_r1336600007


##########
core/src/main/scala/org/apache/spark/storage/BlockManager.scala:
##########
@@ -527,7 +527,9 @@ private[spark] class BlockManager(
       logInfo(s"external shuffle service port = $externalShuffleServicePort")
       shuffleServerId = BlockManagerId(executorId, blockTransferService.hostName,
         externalShuffleServicePort)
-      if (!isDriver) {
+      // Do not try to register with the external shuffle server under testing since none of
+      // test modes (local, local-cluster) enables shuffle service.
+      if (!isDriver && !Utils.isTesting) {

Review Comment:
   Without this, the test can't run due to the `BlockManager` creation will fail on this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org