You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2020/03/07 09:01:37 UTC
Review Request 72210: Added a test
`ROOT_CGROUPS_CFS_CommandTaskInfiniteLimits`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72210/
-----------------------------------------------------------
Review request for mesos, Andrei Budnik and Greg Mann.
Repository: mesos
Description
-------
Added a test `ROOT_CGROUPS_CFS_CommandTaskInfiniteLimits`.
Diffs
-----
src/tests/containerizer/cgroups_isolator_tests.cpp f72e6cdab417368e63349915114aeed586e0ef0e
Diff: https://reviews.apache.org/r/72210/diff/1/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 72210: Added a test
`ROOT_CGROUPS_CFS_CommandTaskInfiniteLimits`.
Posted by Qian Zhang <zh...@gmail.com>.
> On March 16, 2020, 8:31 p.m., Greg Mann wrote:
> > src/tests/containerizer/cgroups_isolator_tests.cpp
> > Lines 842-845 (patched)
> > <https://reviews.apache.org/r/72210/diff/2/?file=2214048#file2214048line842>
> >
> > Will this be true on all systems? Can we just check that the task cgroup's memory limit is -1?
I think it will be true on all systems since root cgroup's limits cannot be modified (you can search `"we cannot set any limits on the root cgroup"` in https://www.kernel.org/doc/Documentation/cgroup-v1/memory.txt ). -1 represents infinite limit for CPU CFS quota but not memory limit which uses something like `9223372036854771712`.
- Qian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72210/#review219955
-----------------------------------------------------------
On March 16, 2020, 9:51 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72210/
> -----------------------------------------------------------
>
> (Updated March 16, 2020, 9:51 p.m.)
>
>
> Review request for mesos, Andrei Budnik and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test `ROOT_CGROUPS_CFS_CommandTaskInfiniteLimits`.
>
>
> Diffs
> -----
>
> src/tests/containerizer/cgroups_isolator_tests.cpp f72e6cdab417368e63349915114aeed586e0ef0e
>
>
> Diff: https://reviews.apache.org/r/72210/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 72210: Added a test
`ROOT_CGROUPS_CFS_CommandTaskInfiniteLimits`.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72210/#review219955
-----------------------------------------------------------
src/tests/containerizer/cgroups_isolator_tests.cpp
Lines 842-845 (patched)
<https://reviews.apache.org/r/72210/#comment308193>
Will this be true on all systems? Can we just check that the task cgroup's memory limit is -1?
- Greg Mann
On March 16, 2020, 9:14 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72210/
> -----------------------------------------------------------
>
> (Updated March 16, 2020, 9:14 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test `ROOT_CGROUPS_CFS_CommandTaskInfiniteLimits`.
>
>
> Diffs
> -----
>
> src/tests/containerizer/cgroups_isolator_tests.cpp f72e6cdab417368e63349915114aeed586e0ef0e
>
>
> Diff: https://reviews.apache.org/r/72210/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 72210: Added a test
`ROOT_CGROUPS_CFS_CommandTaskInfiniteLimits`.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72210/#review219974
-----------------------------------------------------------
Ship it!
Ship It!
- Greg Mann
On March 17, 2020, 7:08 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72210/
> -----------------------------------------------------------
>
> (Updated March 17, 2020, 7:08 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test `ROOT_CGROUPS_CFS_CommandTaskInfiniteLimits`.
>
>
> Diffs
> -----
>
> src/tests/containerizer/cgroups_isolator_tests.cpp f72e6cdab417368e63349915114aeed586e0ef0e
>
>
> Diff: https://reviews.apache.org/r/72210/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 72210: Added a test
`ROOT_CGROUPS_CFS_CommandTaskInfiniteLimits`.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72210/
-----------------------------------------------------------
(Updated March 17, 2020, 3:08 p.m.)
Review request for mesos, Andrei Budnik and Greg Mann.
Changes
-------
Updated a comment in the code.
Repository: mesos
Description
-------
Added a test `ROOT_CGROUPS_CFS_CommandTaskInfiniteLimits`.
Diffs (updated)
-----
src/tests/containerizer/cgroups_isolator_tests.cpp f72e6cdab417368e63349915114aeed586e0ef0e
Diff: https://reviews.apache.org/r/72210/diff/4/
Changes: https://reviews.apache.org/r/72210/diff/3-4/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 72210: Added a test
`ROOT_CGROUPS_CFS_CommandTaskInfiniteLimits`.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72210/
-----------------------------------------------------------
(Updated March 16, 2020, 9:51 p.m.)
Review request for mesos, Andrei Budnik and Greg Mann.
Changes
-------
Minor change.
Repository: mesos
Description
-------
Added a test `ROOT_CGROUPS_CFS_CommandTaskInfiniteLimits`.
Diffs (updated)
-----
src/tests/containerizer/cgroups_isolator_tests.cpp f72e6cdab417368e63349915114aeed586e0ef0e
Diff: https://reviews.apache.org/r/72210/diff/3/
Changes: https://reviews.apache.org/r/72210/diff/2-3/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 72210: Added a test
`ROOT_CGROUPS_CFS_CommandTaskInfiniteLimits`.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72210/
-----------------------------------------------------------
(Updated March 16, 2020, 5:14 p.m.)
Review request for mesos, Andrei Budnik and Greg Mann.
Changes
-------
Rebased.
Repository: mesos
Description
-------
Added a test `ROOT_CGROUPS_CFS_CommandTaskInfiniteLimits`.
Diffs (updated)
-----
src/tests/containerizer/cgroups_isolator_tests.cpp f72e6cdab417368e63349915114aeed586e0ef0e
Diff: https://reviews.apache.org/r/72210/diff/2/
Changes: https://reviews.apache.org/r/72210/diff/1-2/
Testing
-------
Thanks,
Qian Zhang