You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by "plainheart (via GitHub)" <gi...@apache.org> on 2023/02/23 10:49:09 UTC
[GitHub] [echarts] plainheart commented on a diff in pull request #18301: Ignore file '\asset\contributing-inspect.png' when publish to npm
plainheart commented on code in PR #18301:
URL: https://github.com/apache/echarts/pull/18301#discussion_r1115506865
##########
.npmignore:
##########
@@ -10,5 +10,6 @@
.DS_Store
Thumbs.db
Desktop.ini
+/asset/contributing-inspect.png
Review Comment:
We can ignore the whole `asset` folder and the `CONTRIBUTING.md` seems also unnecessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org