You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/02/07 13:20:43 UTC
[GitHub] [airflow] ashb opened a new pull request #14123: Template k8s.V1EnvVar without adding custom attributes to dict.
ashb opened a new pull request #14123:
URL: https://github.com/apache/airflow/pull/14123
The previous attempt at this worked, but ended up breaking other tests
as the `__eq__` method on this compared to dict.
This customizes the render method to have the variable templated, but
without needing to add an attribute to the V1EnvVar class.
This fixes the broken tests introduced by #14083
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14123: Template k8s.V1EnvVar without adding custom attributes to dict.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14123:
URL: https://github.com/apache/airflow/pull/14123#issuecomment-774677451
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb merged pull request #14123: Template k8s.V1EnvVar without adding custom attributes to dict.
Posted by GitBox <gi...@apache.org>.
ashb merged pull request #14123:
URL: https://github.com/apache/airflow/pull/14123
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #14123: Template k8s.V1EnvVar without adding custom attributes to dict.
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #14123:
URL: https://github.com/apache/airflow/pull/14123#issuecomment-774673542
Hopefully this one show now run the kind tests too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org