You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by lun gao <lu...@intel.com> on 2015/07/03 05:35:32 UTC
Review Request 36156: HIVE-11053: Add more tests for HIVE-10844[Spark
Branch]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36156/
-----------------------------------------------------------
Review request for hive and chengxiang li.
Bugs: HIVE-11053
https://issues.apache.org/jira/browse/HIVE-11053
Repository: hive-git
Description
-------
Add some test cases for self union, self-join, CWE, and repeated sub-queries to verify the job of combining quivalent works in HIVE-10844.
Diffs
-----
ql/src/test/queries/clientpositive/Dynamic_RDD_Cache.q f5b40ea
ql/src/test/results/clientpositive/spark/Dynamic_RDD_Cache.q.out f52100a
Diff: https://reviews.apache.org/r/36156/diff/
Testing
-------
Thanks,
lun gao
Re: Review Request 36156: HIVE-11053: Add more tests for
HIVE-10844[Spark Branch]
Posted by chengxiang li <ch...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36156/#review90859
-----------------------------------------------------------
Ship it!
Ship It!
- chengxiang li
On 七月 8, 2015, 3:05 a.m., lun gao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36156/
> -----------------------------------------------------------
>
> (Updated 七月 8, 2015, 3:05 a.m.)
>
>
> Review request for hive and chengxiang li.
>
>
> Bugs: HIVE-11053
> https://issues.apache.org/jira/browse/HIVE-11053
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Add some test cases for self union, self-join, CWE, and repeated sub-queries to verify the job of combining quivalent works in HIVE-10844.
>
>
> Diffs
> -----
>
> itests/src/test/resources/testconfiguration.properties 4f2de12
> ql/src/test/queries/clientpositive/dynamic_rdd_cache.q PRE-CREATION
> ql/src/test/results/clientpositive/dynamic_rdd_cache.q.out PRE-CREATION
> ql/src/test/results/clientpositive/spark/dynamic_rdd_cache.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/36156/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> lun gao
>
>
Re: Review Request 36156: HIVE-11053: Add more tests for
HIVE-10844[Spark Branch]
Posted by cheng xu <ch...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36156/#review90860
-----------------------------------------------------------
Ship it!
Ship It!
- cheng xu
On July 8, 2015, 11:05 a.m., lun gao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36156/
> -----------------------------------------------------------
>
> (Updated July 8, 2015, 11:05 a.m.)
>
>
> Review request for hive and chengxiang li.
>
>
> Bugs: HIVE-11053
> https://issues.apache.org/jira/browse/HIVE-11053
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Add some test cases for self union, self-join, CWE, and repeated sub-queries to verify the job of combining quivalent works in HIVE-10844.
>
>
> Diffs
> -----
>
> itests/src/test/resources/testconfiguration.properties 4f2de12
> ql/src/test/queries/clientpositive/dynamic_rdd_cache.q PRE-CREATION
> ql/src/test/results/clientpositive/dynamic_rdd_cache.q.out PRE-CREATION
> ql/src/test/results/clientpositive/spark/dynamic_rdd_cache.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/36156/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> lun gao
>
>
Re: Review Request 36156: HIVE-11053: Add more tests for
HIVE-10844[Spark Branch]
Posted by lun gao <lu...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36156/
-----------------------------------------------------------
(Updated July 8, 2015, 3:05 a.m.)
Review request for hive and chengxiang li.
Changes
-------
Delete the meaningless space.
Bugs: HIVE-11053
https://issues.apache.org/jira/browse/HIVE-11053
Repository: hive-git
Description
-------
Add some test cases for self union, self-join, CWE, and repeated sub-queries to verify the job of combining quivalent works in HIVE-10844.
Diffs (updated)
-----
itests/src/test/resources/testconfiguration.properties 4f2de12
ql/src/test/queries/clientpositive/dynamic_rdd_cache.q PRE-CREATION
ql/src/test/results/clientpositive/dynamic_rdd_cache.q.out PRE-CREATION
ql/src/test/results/clientpositive/spark/dynamic_rdd_cache.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/36156/diff/
Testing
-------
Thanks,
lun gao
Re: Review Request 36156: HIVE-11053: Add more tests for
HIVE-10844[Spark Branch]
Posted by cheng xu <ch...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36156/#review90854
-----------------------------------------------------------
ql/src/test/queries/clientpositive/dynamic_rdd_cache.q (line 6)
<https://reviews.apache.org/r/36156/#comment144012>
Minor issue: Please remove the tailing space in the qfile. Thank you!
- cheng xu
On July 8, 2015, 10:13 a.m., lun gao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36156/
> -----------------------------------------------------------
>
> (Updated July 8, 2015, 10:13 a.m.)
>
>
> Review request for hive and chengxiang li.
>
>
> Bugs: HIVE-11053
> https://issues.apache.org/jira/browse/HIVE-11053
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Add some test cases for self union, self-join, CWE, and repeated sub-queries to verify the job of combining quivalent works in HIVE-10844.
>
>
> Diffs
> -----
>
> itests/src/test/resources/testconfiguration.properties 4f2de12
> ql/src/test/queries/clientpositive/dynamic_rdd_cache.q PRE-CREATION
> ql/src/test/results/clientpositive/dynamic_rdd_cache.q.out PRE-CREATION
> ql/src/test/results/clientpositive/spark/dynamic_rdd_cache.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/36156/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> lun gao
>
>
Re: Review Request 36156: HIVE-11053: Add more tests for
HIVE-10844[Spark Branch]
Posted by lun gao <lu...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36156/
-----------------------------------------------------------
(Updated July 8, 2015, 2:13 a.m.)
Review request for hive and chengxiang li.
Changes
-------
Add outfile made by TestCliDriver and modify the configuration file.
Bugs: HIVE-11053
https://issues.apache.org/jira/browse/HIVE-11053
Repository: hive-git
Description
-------
Add some test cases for self union, self-join, CWE, and repeated sub-queries to verify the job of combining quivalent works in HIVE-10844.
Diffs (updated)
-----
itests/src/test/resources/testconfiguration.properties 4f2de12
ql/src/test/queries/clientpositive/dynamic_rdd_cache.q PRE-CREATION
ql/src/test/results/clientpositive/dynamic_rdd_cache.q.out PRE-CREATION
ql/src/test/results/clientpositive/spark/dynamic_rdd_cache.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/36156/diff/
Testing
-------
Thanks,
lun gao
Re: Review Request 36156: HIVE-11053: Add more tests for
HIVE-10844[Spark Branch]
Posted by lun gao <lu...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36156/
-----------------------------------------------------------
(Updated July 7, 2015, 3:49 p.m.)
Review request for hive and chengxiang li.
Changes
-------
Delete some meaningless lines.
Bugs: HIVE-11053
https://issues.apache.org/jira/browse/HIVE-11053
Repository: hive-git
Description
-------
Add some test cases for self union, self-join, CWE, and repeated sub-queries to verify the job of combining quivalent works in HIVE-10844.
Diffs (updated)
-----
ql/src/test/queries/clientpositive/dynamic_rdd_cache.q PRE-CREATION
ql/src/test/results/clientpositive/spark/dynamic_rdd_cache.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/36156/diff/
Testing
-------
Thanks,
lun gao
Re: Review Request 36156: HIVE-11053: Add more tests for
HIVE-10844[Spark Branch]
Posted by chengxiang li <ch...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36156/#review90647
-----------------------------------------------------------
ql/src/test/queries/clientpositive/dynamic_rdd_cache.q (line 21)
<https://reviews.apache.org/r/36156/#comment143770>
Are the temp table X/Y/Z be created actually?
- chengxiang li
On 七月 6, 2015, 6:35 a.m., lun gao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36156/
> -----------------------------------------------------------
>
> (Updated 七月 6, 2015, 6:35 a.m.)
>
>
> Review request for hive and chengxiang li.
>
>
> Bugs: HIVE-11053
> https://issues.apache.org/jira/browse/HIVE-11053
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Add some test cases for self union, self-join, CWE, and repeated sub-queries to verify the job of combining quivalent works in HIVE-10844.
>
>
> Diffs
> -----
>
> ql/src/test/queries/clientpositive/dynamic_rdd_cache.q PRE-CREATION
> ql/src/test/results/clientpositive/spark/dynamic_rdd_cache.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/36156/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> lun gao
>
>
Re: Review Request 36156: HIVE-11053: Add more tests for
HIVE-10844[Spark Branch]
Posted by lun gao <lu...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36156/
-----------------------------------------------------------
(Updated July 6, 2015, 6:35 a.m.)
Review request for hive and chengxiang li.
Changes
-------
format corrected.
Bugs: HIVE-11053
https://issues.apache.org/jira/browse/HIVE-11053
Repository: hive-git
Description
-------
Add some test cases for self union, self-join, CWE, and repeated sub-queries to verify the job of combining quivalent works in HIVE-10844.
Diffs (updated)
-----
ql/src/test/queries/clientpositive/dynamic_rdd_cache.q PRE-CREATION
ql/src/test/results/clientpositive/spark/dynamic_rdd_cache.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/36156/diff/
Testing
-------
Thanks,
lun gao
Re: Review Request 36156: HIVE-11053: Add more tests for
HIVE-10844[Spark Branch]
Posted by chengxiang li <ch...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36156/#review90314
-----------------------------------------------------------
ql/src/test/queries/clientpositive/dynamic_rdd_cache.q (line 78)
<https://reviews.apache.org/r/36156/#comment143335>
this query is quite same as the previous one, we shoud just need one of thoese.
- chengxiang li
On 七月 3, 2015, 7:34 a.m., lun gao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36156/
> -----------------------------------------------------------
>
> (Updated 七月 3, 2015, 7:34 a.m.)
>
>
> Review request for hive and chengxiang li.
>
>
> Bugs: HIVE-11053
> https://issues.apache.org/jira/browse/HIVE-11053
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Add some test cases for self union, self-join, CWE, and repeated sub-queries to verify the job of combining quivalent works in HIVE-10844.
>
>
> Diffs
> -----
>
> ql/src/test/queries/clientpositive/dynamic_rdd_cache.q PRE-CREATION
> ql/src/test/results/clientpositive/spark/dynamic_rdd_cache.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/36156/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> lun gao
>
>
Re: Review Request 36156: HIVE-11053: Add more tests for
HIVE-10844[Spark Branch]
Posted by chengxiang li <ch...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36156/#review90312
-----------------------------------------------------------
ql/src/test/queries/clientpositive/dynamic_rdd_cache.q (line 102)
<https://reviews.apache.org/r/36156/#comment143334>
drop temp table at the end.
- chengxiang li
On 七月 3, 2015, 7:34 a.m., lun gao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36156/
> -----------------------------------------------------------
>
> (Updated 七月 3, 2015, 7:34 a.m.)
>
>
> Review request for hive and chengxiang li.
>
>
> Bugs: HIVE-11053
> https://issues.apache.org/jira/browse/HIVE-11053
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Add some test cases for self union, self-join, CWE, and repeated sub-queries to verify the job of combining quivalent works in HIVE-10844.
>
>
> Diffs
> -----
>
> ql/src/test/queries/clientpositive/dynamic_rdd_cache.q PRE-CREATION
> ql/src/test/results/clientpositive/spark/dynamic_rdd_cache.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/36156/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> lun gao
>
>
Re: Review Request 36156: HIVE-11053: Add more tests for
HIVE-10844[Spark Branch]
Posted by lun gao <lu...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36156/
-----------------------------------------------------------
(Updated July 3, 2015, 7:34 a.m.)
Review request for hive and chengxiang li.
Changes
-------
Add new test
Bugs: HIVE-11053
https://issues.apache.org/jira/browse/HIVE-11053
Repository: hive-git
Description
-------
Add some test cases for self union, self-join, CWE, and repeated sub-queries to verify the job of combining quivalent works in HIVE-10844.
Diffs (updated)
-----
ql/src/test/queries/clientpositive/dynamic_rdd_cache.q PRE-CREATION
ql/src/test/results/clientpositive/spark/dynamic_rdd_cache.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/36156/diff/
Testing
-------
Thanks,
lun gao