You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by DaveBirdsall <gi...@git.apache.org> on 2016/12/06 23:04:30 UTC
[GitHub] incubator-trafodion pull request #870: [TRAFODION-2389] Update some messages...
GitHub user DaveBirdsall opened a pull request:
https://github.com/apache/incubator-trafodion/pull/870
[TRAFODION-2389] Update some messages in the range 1000-1059
This is the first part of the changes needed for JIRA TRAFODION-2389.
In this set of changes:
1. The following messages were added to the Messages Guide: 1018, 1032, 1034, 1052 and 1055.
2. The following messages were updated in the Messages Guide: 1004, 1013, 1027, 1030, 1036, 1037, 1039, 1048 and 1058.
3. The following messages were updated in SqlciErrors.txt (note none of these occur in any existing regress tests): 1020, 1034 and 1039.
4. The following messages were removed as they are obsolete: 1019, 1038, 1054, 1055 and 1057.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DaveBirdsall/incubator-trafodion Trafodion2389
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafodion/pull/870.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #870
----
commit 03b4dce0412ae1059dec2edd5d1792c092c5cac1
Author: Dave Birdsall <db...@apache.org>
Date: 2016-12-06T22:56:03Z
[TRAFODION-2389] Update some messages in the range 1000-1059
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request #870: [TRAFODION-2389] Update some messages...
Posted by robertamarton <gi...@git.apache.org>.
Github user robertamarton commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/870#discussion_r91205088
--- Diff: docs/messages_guide/src/asciidoc/_chapters/ddl_msgs.adoc ---
@@ -486,62 +534,52 @@ catalog name and resubmit.
== SQL 1036
```
-Only super ID can execute DROP SQL.
+Authorization ID <auth-id-1> cannot grant to authorization ID <auth-id-2> because it could create a circular dependency.
```
-*Cause:* An attempt was made to drop SQL by a user who is not the super
-ID.
+Where <auth-id-1> is the authorization ID performing the GRANT.
+
+Where <auth-id-2> is the authorization ID that is the target of the GRANT.
+
+*Cause:* There is a chain of grants leading from <auth-id-2> back to <auth-id-1>. Granting
+this request might create a circular dependency.
*Effect:* The operation fails.
-*Recovery:* The super ID needs to issue the DROP SCHEMA statement.
+*Recovery:* None.
<<<
[[SQL-1037]]
== SQL 1037
```
-{project-name} is not installed on system <node>.
+Revoke failed because of a dependent grant between authorization ID <auth-id-1> and authorization ID <auth-id-2>.
```
-Where <node> is the name of the node referenced by the operation.
-
-*Cause:* In a replication or distribution context: An operation
-attempted to create a catalog reference or a partition on a node where
-the {project-name} database has not been installed.
-
-*Effect:* The operation fails.
-
-*Recovery:* Either reissue the statement specifying a different node, or
-install the {project-name} database on <node> and resubmit.
-
-[[SQL-1038]]
-== SQL 1038
-
-```
-Not all user catalogs have been dropped from the system.
-```
+Where <auth-id-1> and <auth-id-2> are authorization IDs.
-*Cause:* You attempted to drop SQL while one or more user-created
-catalogs existed.
+*Cause:* You attempted to revoke a privilege from <auth-id-1>, but
+that user or role has granted that privilege to a third authorization ID.
*Effect:* The operation fails.
-*Recovery:* You must drop all user-created catalogs before dropping SQL.
+*Recovery:* None.
<<<
[[SQL-1039]]
== SQL 1039
```
-The DROP SQL statement could not be executed.
+No privileges were revoked. You lack the grant option for the specified privilege(s).
```
-*Cause:* See the accompanying error message for the cause.
+*Cause:* You attempted to revoke privileges from an authorization ID
+that does not have the grant option for those privileges.
--- End diff --
Cause: you attempted to revoke privileges from an authorization ID but you do not have ability (grant option) to perform this operation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request #870: [TRAFODION-2389] Update some messages...
Posted by robertamarton <gi...@git.apache.org>.
Github user robertamarton commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/870#discussion_r91205877
--- Diff: docs/messages_guide/src/asciidoc/_chapters/ddl_msgs.adoc ---
@@ -761,40 +814,42 @@ constraint specified in the CREATE INDEX statement.
change the rows in the table to remove duplicates. Then reissue the
statement.
-<<<
-[[SQL-1057]]
-== SQL 1057
+[[SQL-1055]]
+== SQL 1055
```
-{project-name} objects cannot be created on <volume-name>: File system error <error-number>.
+Object <privilege-object> already exists.
```
-Where <volume-name> is the name of a volume.
+Where <privilege-object> is an object you specified on a REGISTER statement.
-Where <error-number> is the file system error number.
+*Cause:* You attempted to register a new privilege object in the
+{project-name} database but this object already exists.
-*Cause:* An attempt to create a file on volume <volume-name> resulted in
-file system error <error-number>.
+*Effect:* The operation takes no action.
-*Effect:* The operation fails.
-
-*Recovery:* For information about file system errors, see <<file_system_errors,File-System Errors>>.
+*Recovery:* If the object name is incorrect, correct and resubmit.
+<<<
[[SQL-1058]]
== SQL 1058
```
-Lock <lock-name> already exists.
+Unable to create histogram table <table-name>.
```
-Where <lock-name> is the name of the DDL lock.
+Where <table-name> is the name of the histogram table that could not be created.
-*Cause:* The statement required creation of a lock with a unique lock
-name, which was not generated.
+*Cause:* You attempted to execute a CREATE SCHEMA statement, but one
+of the histogram tables needed for the schema could not be created.
+This message may be accompanied by other messages that shed more light
+on the problem.
--- End diff --
Consistency: in a previous message (1034) you stated "Additional error messages may give insight to the cause. " Here you state "This message may be accompanied by other messages that shed more light on the problem." Probably should say the same thing ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request #870: [TRAFODION-2389] Update some messages...
Posted by robertamarton <gi...@git.apache.org>.
Github user robertamarton commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/870#discussion_r91203013
--- Diff: docs/messages_guide/src/asciidoc/_chapters/ddl_msgs.adoc ---
@@ -254,6 +254,24 @@ local super ID can perform a replication operation for a catalog and for
multiple schemas in a single catalog. Additionally, the schema owner can
perform a replication operation for a single schema.
+[[SQL-1018]]
+== SQL 1018
+
+```
+Grant of role or privilege <privilege> from <user-or-role-1> to <user-or-role-2> not found, revoke request ignored.
+```
+
+Where <privilege> is a {project-name} privilege and <user-or-role-1> and <user-or-role-2> are user IDs or roles.
+
--- End diff --
user-or-role-2 can be the special role PUBLIC but user-or_role-1 cannot be PUBLIC
You might want to call the <authorization IDs> like other messages.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request #870: [TRAFODION-2389] Update some messages...
Posted by robertamarton <gi...@git.apache.org>.
Github user robertamarton commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/870#discussion_r91204102
--- Diff: docs/messages_guide/src/asciidoc/_chapters/ddl_msgs.adoc ---
@@ -761,40 +814,42 @@ constraint specified in the CREATE INDEX statement.
change the rows in the table to remove duplicates. Then reissue the
statement.
-<<<
-[[SQL-1057]]
-== SQL 1057
+[[SQL-1055]]
+== SQL 1055
```
-{project-name} objects cannot be created on <volume-name>: File system error <error-number>.
+Object <privilege-object> already exists.
```
-Where <volume-name> is the name of a volume.
+Where <privilege-object> is an object you specified on a REGISTER statement.
-Where <error-number> is the file system error number.
+*Cause:* You attempted to register a new privilege object in the
--- End diff --
Actually, a <privilege-object> is a component object name. So perhaps:
"Where <privilege-object> is a component object name you specified for a REGISTER COMPONENT statement."
"Cause: You attempted to register a new component in the {project-name} database but this component object has already been registered."
...
"Recovery: If the component object name is incorrect, correct and resubmit."
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request #870: [TRAFODION-2389] Update some messages...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafodion/pull/870
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request #870: [TRAFODION-2389] Update some messages...
Posted by robertamarton <gi...@git.apache.org>.
Github user robertamarton commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/870#discussion_r91204885
--- Diff: docs/messages_guide/src/asciidoc/_chapters/ddl_msgs.adoc ---
@@ -486,62 +534,52 @@ catalog name and resubmit.
== SQL 1036
```
-Only super ID can execute DROP SQL.
+Authorization ID <auth-id-1> cannot grant to authorization ID <auth-id-2> because it could create a circular dependency.
```
-*Cause:* An attempt was made to drop SQL by a user who is not the super
-ID.
+Where <auth-id-1> is the authorization ID performing the GRANT.
+
+Where <auth-id-2> is the authorization ID that is the target of the GRANT.
+
+*Cause:* There is a chain of grants leading from <auth-id-2> back to <auth-id-1>. Granting
+this request might create a circular dependency.
*Effect:* The operation fails.
-*Recovery:* The super ID needs to issue the DROP SCHEMA statement.
+*Recovery:* None.
<<<
[[SQL-1037]]
== SQL 1037
```
-{project-name} is not installed on system <node>.
+Revoke failed because of a dependent grant between authorization ID <auth-id-1> and authorization ID <auth-id-2>.
```
-Where <node> is the name of the node referenced by the operation.
-
-*Cause:* In a replication or distribution context: An operation
-attempted to create a catalog reference or a partition on a node where
-the {project-name} database has not been installed.
-
-*Effect:* The operation fails.
-
-*Recovery:* Either reissue the statement specifying a different node, or
-install the {project-name} database on <node> and resubmit.
-
-[[SQL-1038]]
-== SQL 1038
-
-```
-Not all user catalogs have been dropped from the system.
-```
+Where <auth-id-1> and <auth-id-2> are authorization IDs.
-*Cause:* You attempted to drop SQL while one or more user-created
-catalogs existed.
+*Cause:* You attempted to revoke a privilege from <auth-id-1>, but
+that user or role has granted that privilege to a third authorization ID.
*Effect:* The operation fails.
-*Recovery:* You must drop all user-created catalogs before dropping SQL.
+*Recovery:* None.
--- End diff --
Recovery: Reconnect to the {project-name} database using an authorization ID
that can revoke privileges from <auth-id-2> that were granted by <auth-id-1> and resubmit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---