[GitHub] [ozone] sadanand48 commented on a diff in pull request #3906: HDDS-5866. Discrepancy in Trash directory in ofs vs o3fs.

[GitBox <gi...@apache.org>]

sadanand48 commented on code in PR #3906:
URL: https://github.com/apache/ozone/pull/3906#discussion_r1007802502


##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestRootedOzoneFileSystem.java:
##########
@@ -1523,39 +1521,6 @@ public void testGetTrashRoots() throws IOException {
     Assert.assertTrue(volume1.setOwner(prevOwner));
   }
 
-  /**
-   * Check that  files are moved to trash since it is enabled by
-   * fs.rename(src, dst, options).
-   */
-  @Test
-  @Flaky({"HDDS-5819", "HDDS-6451"})

Review Comment:
   This test is flaky as it checks for existence of key in /Current but the checkpoint interval is in milliseconds so it might already be in checkpoint directory. This part is already tested in testTrash , hence removing this test.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org