You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mc...@gmail.com> on 2015/04/26 09:14:25 UTC
Review Request 33569: mesos: Removed and switched
from tuples:: to std::.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33569/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Cody Maloney, and Joris Van Remoortere.
Bugs: MESOS-2663
https://issues.apache.org/jira/browse/MESOS-2663
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/slave/containerizer/external_containerizer.hpp 726a97fc3ea27b3a39503406d572d1980bb8b808
src/slave/containerizer/external_containerizer.cpp 9a72acb930d883d026d0e470e64b69ff0393c7b7
src/slave/containerizer/isolators/posix/disk.cpp 73059bd624145af8aeed5c3c17fbba371683d95d
src/zookeeper/zookeeper.cpp d4c24cd500b74d3b979a471b4a32def78958f04a
Diff: https://reviews.apache.org/r/33569/diff/
Testing
-------
make check
Thanks,
Michael Park
Re: Review Request 33569: mesos: Removed and
switched from tuples:: to std::.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33569/#review81611
-----------------------------------------------------------
Patch looks great!
Reviews applied: [33560, 33561, 33562, 33564, 33565, 33566, 33567, 33568, 33569]
All tests passed.
- Mesos ReviewBot
On April 26, 2015, 7:14 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33569/
> -----------------------------------------------------------
>
> (Updated April 26, 2015, 7:14 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Cody Maloney, and Joris Van Remoortere.
>
>
> Bugs: MESOS-2663
> https://issues.apache.org/jira/browse/MESOS-2663
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/containerizer/external_containerizer.hpp 726a97fc3ea27b3a39503406d572d1980bb8b808
> src/slave/containerizer/external_containerizer.cpp 9a72acb930d883d026d0e470e64b69ff0393c7b7
> src/slave/containerizer/isolators/posix/disk.cpp 73059bd624145af8aeed5c3c17fbba371683d95d
> src/zookeeper/zookeeper.cpp d4c24cd500b74d3b979a471b4a32def78958f04a
>
> Diff: https://reviews.apache.org/r/33569/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 33569: mesos: Removed and
switched from tuples:: to std::.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33569/#review81632
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On April 26, 2015, 7:14 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33569/
> -----------------------------------------------------------
>
> (Updated April 26, 2015, 7:14 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Cody Maloney, and Joris Van Remoortere.
>
>
> Bugs: MESOS-2663
> https://issues.apache.org/jira/browse/MESOS-2663
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/containerizer/external_containerizer.hpp 726a97fc3ea27b3a39503406d572d1980bb8b808
> src/slave/containerizer/external_containerizer.cpp 9a72acb930d883d026d0e470e64b69ff0393c7b7
> src/slave/containerizer/isolators/posix/disk.cpp 73059bd624145af8aeed5c3c17fbba371683d95d
> src/zookeeper/zookeeper.cpp d4c24cd500b74d3b979a471b4a32def78958f04a
>
> Diff: https://reviews.apache.org/r/33569/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Michael Park
>
>